Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user dmabry commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218765751
I tested this in our 4.8 HW Lab and it worked as expected. I found the
MASTER VR for a TEST VPC with a private gateway configured. I started a ping
to the private
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218743823
Can I get one more review on this one?
@remibergsma are you choosing not to squash because you are not the
original author of some of the commits? If that is th
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218706540
LGTM did a code walk through and I know of a production install this code
is running in.
---
If your project is set up for it, you can reply to this email and
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1483#discussion_r62985942
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -466,7 +466,7 @@ public boolean deletePrivateGateway(final
Priva
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-218649701
I need some code review on this one. Thanks...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-217605374
### CI RESULTS
```
Tests Run: 85
Skipped: 0
Failed: 1
Errors: 1
Duration: 10h 26m 38s
```
**Summary of the
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216560940
Thank you sir...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517829
Well, the open version of it - PR 1483
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-216517631
I'm about to start testing this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-216227701
@remibergsma please squash changes to a single commit, and push -f
tag:needlove
---
If your project is set up for it, you can reply to this email and have yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208794235
@swill force pushed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208755644
@kiwiflyer
I'm currently working on CLOUDSTACK-9339 to resolve the issues that I
mentioned in #1413 - I don't think this PR breaks anything that currently
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-208522087
@remibergsma
Is this exactly the same PR as the one Wilder closed last week, or does it
have some changes in it?
Also, there are some comments f
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1483#issuecomment-207988893
@alexandrelimassantana please make a pull request to the branch that the PR
is created from, Remi can include you change in this one by pulling it to his
branc
Github user alexandrelimassantana commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1483#discussion_r59121072
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -466,7 +466,7 @@ public boolean deletePrivateGateway(fin
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1483
CLOUDSTACK-9287 - Fix unique mac address per rVPC router
This is work by @wilderrodrigues, see PR #1413 It contains important fixes
and I think it needs to be included so I send the PR agai
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205831656
Thank you. I've raised CLOUDSTACK-9339 on Jira about the non-VPC RvR
issues. As my company needs those issues solved in the short term I'll begin
working on a fix f
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205820963
@dsclose This bug exists as far back as 4.6 I believe, as that was when RvR
for VPC was introduced. So you might want base your patch on 4.7 and then it
can be pu
6 14:28
To: dev@cloudstack.apache.org
Subject: [GitHub] cloudstack pull request: CLOUDSTACK-9287 - Fix unique mac
address ...
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205804779
@dsclose - just FYI. As far as I'm aw
Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205804779
@dsclose - just FYI. As far as I'm aware, this PR has not been committed
yet. @ustcweizhou has requested a new PR/rebase.
I just pulled these into our bu
Github user dsclose commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-205716220
@wilderrodrigues @ustcweizhou Sorry to arrive late to the party but this
appears to break/ignore some RvR functionality. 4 things in particular stand
out:
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-203884447
@wilderrodrigues will you create a new PR for this ? This PR is not merged.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user wilderrodrigues closed the pull request at:
https://github.com/apache/cloudstack/pull/1413
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55236035
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw(fina
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55127726
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw(fina
Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1413#discussion_r55127619
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -559,9 +559,16 @@ public boolean applyACLItemsToPrivateGw(fina
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-185635109
LGTM, based on the tests below. This runs in prod at SBP.
Test results:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=adva
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-185052627
Hi,
I squashed a few commits that make sense to be squashed and amended all
commit messages in order to add the CloudStack issue number. In addition
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1413#issuecomment-184850454
Hi,
I fixed the issues mentioned in the commits descriptions and added more
tests in order to cover them.
I'm running the tests and will ad
30 matches
Mail list logo
