GitHub user remibergsma opened a pull request: https://github.com/apache/cloudstack/pull/1483
CLOUDSTACK-9287 - Fix unique mac address per rVPC router This is work by @wilderrodrigues, see PR #1413 It contains important fixes and I think it needs to be included so I send the PR again. You can merge this pull request into a Git repository by running: $ git pull https://github.com/remibergsma/cloudstack pr1413-wilder-47 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cloudstack/pull/1483.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1483 ---- commit f921ec686bcf339968040c57bf0ae9fceffd8fed Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T11:59:20Z CLOUDSTACK-9287 - Generate new mac address if router is redundant and nic profile exists commit d93b008deb2ced326b314fefbe11511d798be5e8 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T14:48:30Z CLOUDSTACK-9287 - Put private gateway interface down on backup router commit 250be376e879b6c43792fdb5af0f5c49747689da Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-13T16:29:14Z CLOUDSTACK-9287 - Add integration test to cover the private gw interface/mac address issues commit 057b54aa3e8a462b3ced9b53d7a55dd5a64a0e4e Author: Remi Bergsma <git...@remi.nl> Date: 2016-02-14T13:39:53Z CLOUDSTACK-9287 - Make sure private gw interface is not used for default gw commit 6a767732f959186e95c71d31a2ed49bb67a85473 Author: Remi Bergsma <git...@remi.nl> Date: 2016-02-14T17:09:03Z CLOUDSTACK-9287 - Bring up the private gw interface on state change to master commit 850fb1a557b8eec04de79124fea5b6f923530d66 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:16:23Z CLOUDSTACK-9287 - Check if the nic profile has already been removed from a certain router - In case of redundant VPCs, the ACL items are revoked in the first iteration. Since the econd iteration is needed in order to remove the private network, we have to check if the nic profile is gone before trying to revoke the ACL items again, which would throw a NPE. - Some variable extraction in order to ease debugging. commit c41edc1fe62cf92ab85c59c6da4dced9e626d961 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:31:39Z CLOUDSTACK-9287 - Refactor the interface state configuration - This also refactors the CsAddress in order to offer better readability in a couple of methods. commit 0e91468964b3b256497fa9dac50c63f9235ca102 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T06:33:48Z CLOUDSTACK-9287 - Add integration test to cover the private gateway related changes commit 78bbd498e7c7cb58570025b85d02c8ff921065d5 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T15:07:34Z CLOUDSTACK-9287 - Fix RVR public interface commit ffd8fdb45debe1ddcdf7c6706725cd26d4742cf2 Author: Wilder Rodrigues <wrodrig...@schubergphilis.com> Date: 2016-02-17T15:43:16Z CLOUDSTACK-9287 - Improve test by checking if pvt gw is removed and fix typos ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---