Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-217089000
@rhtyd Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this f
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-216224340
@kansal please rebase against latest master
tag:needlove
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212876630
@kansal create methods would also help to test the behavior of this code,
using unit test and integration test (to verify if the methods that have unit
test
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-212842771
@kansal
LGTM. See if you can add an integration test.
Actual response from traffic sentinel resource in the logs will also help.
---
If your projec
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-211873904
@GabrielBrascher These adjustments can be done, but I don't see any point
of introducing the function calls. Anyhow this code is not used anywhere else
in the whole
Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-189941771
@kansal Could you please consider the following adjustments?
- create a method for the "Part 1" (lines 213-219). With the command as
parameter and return
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-187574586
@alexandrelimassantana , I am not sure of how to simulate the actual
traffic sentinel resource. I can create a request with 20148 or more, but the
actual error is en
Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-186875522
Hi @kansal, can you make a test with this change? Try issuing an request
with more than 2048 characters to see if everything still works fine then.
-
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1418
CLOUDSTACK-9261: Query to traffic sentinel requesting for usage statsâ¦
⦠is too long resulting in traffic sentinel sending HTTP 414 error
response - Fixed
Root Cause Analysis:
I
