Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1235
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164258629
Integration tests make no real sense, but tried a few to be sure:
```
Check the password file in the Router VM ... === TestName:
test_isolate_networ
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164255956
Based on explanation and code review: LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164255579
As you asked on im @remibergsma : LGTM more explicitely
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164255438
The new script ends up on the router:
```
root@r-15-VM:~# cat /etc/logrotate.d/cloud
# Licensed to the Apache Software Foundation (ASF) under on
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164254871
Before PR this was seen after log rotate:
```
root@r-996-VM:/etc# lsof | grep cloud.log.1
_plutorun 767 root 3w REG 202,10 26054919 71 /var/log/cloud.
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164253492
The change LGTM. We should get this in and for ACS 4.8 we do a refactor in
order to have a proper solution in place.
Cheers,
Wilder
---
If yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164253411
@remibergsma agree and let's not close the jira ticket on merging as this
obviously needs tlc.
---
If your project is set up for it, you can reply to this ema
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164253007
@DaanHoogland There are many different solutions in place, some are
bash/python scripts that do `>/var/log/cloud.log` etc, some use `nohup` to keep
running and
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164251561
@remibergsma sounds like the scripts that are the problem do an open for
write instead of log-call, do they? I saw your list of processes and most of
them seem
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164247329
Pinging @wilderrodrigues @fborn @DaanHoogland @borisroman to review.
---
If your project is set up for it, you can reply to this email and have your
reply appea
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1235
CLOUDSTACK-9155 make sure logrotate is effective for cloud.log
Many processes on the VRs log to cloud.log. When log rotate kicks in, the
file is rotated but the scripts still write to the o
12 matches
Mail list logo
