Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-216206438
@harikrishna-patnala can you rebase against latest master, update on tests
etc and share state of your PR, thanks
---
If your project is set up for it, you can reply
Github user harikrishna-patnala commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-163112385
Thank you for the feedback, I'll add the unit tests for the new methods and
integration tests for the changes that I have made.
---
If your project is
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162994057
@remibergsma
It doesn't break things covered by the tests that were execute, which is
fine. However, @harikrishna-patnala hasn't provided any suppo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162851856
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1180#issuecomment-162821748
Hi @harikrishna-patnala
Anyway we can test this? Is there any integration test that we can use to
cover your changes? Concerning the new methods yo
