Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1033
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1033#issuecomment-155102893
To double check, I also verified the bug fix itself.
List hosts in current master:
```
(local) ðµ > list hosts
id = 989be22d-7a04
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1033#issuecomment-155099155
@Carles-Figuerola Understood. Don't mind my comment.
In that case, LGTM. Code seems good.
---
If your project is set up for it, you can reply to this email an
Github user Carles-Figuerola commented on the pull request:
https://github.com/apache/cloudstack/pull/1033#issuecomment-155095658
@wido The problem with that is that lsb_release doesn't come preinstalled
in base centos installs:
[cfiguerola@cent6 ~]$ lsb_release -r
-bash: lsb_r
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1033#issuecomment-155053671
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/1033#issuecomment-155005631
Isn't it safer to execute lsb_release -r and parse that output?
```
[root@n01 ~]# lsb_release -r
Release:7.1.1503
[root@n01 ~]#
```
---
If
GitHub user Carles-Figuerola opened a pull request:
https://github.com/apache/cloudstack/pull/1033
CLOUDSTACK-9029: Proper support to identify CentOS 7 version number
https://issues.apache.org/jira/browse/CLOUDSTACK-9029
You can merge this pull request into a Git repository by runni
