Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/930
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/959
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-150025875
@wilderrodrigues @borisroman My tests also succeeded:
```
Test router internal advanced zone ... === TestName:
test_02_router_internal_adv | Status :
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149956428
Ping @remibergsma @karuturi @DaanHoogland @miguelaferreira @bhaisaab
I ran the router tests as well.
Test Environment:
* Management
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149907512
That was quick! Thanks, @borisroman ! :)
@karuturi @remibergsma 1 LGTM to go. :)
Cheers,
Wilder
---
If your project is set up for it, y
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149901843
@wilderrodrigues Done.
Test results:
```
=== TestName: test_03_ssvm_internals | Status : SUCCESS ===
ok
=== TestName: test_04_cpvm_internal
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149893648
Ping @borisroman @remibergsma @karuturi @miguelaferreira
New code available for review. Please let me know if that's fine.
Test Results:
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149885597
@wilderrodrigues Pushing will be alright. No force needed ;)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149885123
Thanks for the confirmation, @karuturi . Much appreciated! :)
Thanks for testing, @borisroman ! I will force push the new tests in about
30min. If yo
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149882720
@wilderrodrigues @remibergsma @karuturi I tested the PR AS-IS, without the
changes proposed Wilder.
Test results:
```
=== TestName: test_03_ssvm_i
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149880745
Agree.
-Original Message-
From: "Wilder Rodrigues"
Sent: â21-â10-â15 13:22
To: "apache/cloudstack"
Cc: "Rajani Karuturi"
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149847957
@karuturi @remibergsma
I checked manually if the cached cmdline has the same link local IP as
defined in the interface after stop/start/reboot a SSV
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149808138
@karuturi @remibergsma
In the previous PR it was mentioned that looping 30 times would probably be
enough to get the configuration done and also get
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149792585
Hi @karuturi ,
I did not change the code as I thought the work needed was more tests
related. I had a better look at PR #930 and will address your co
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149782673
The code concerns(incase of stop-start on a slow network and the changes of
outer while waiting infinitely) with it were not addressed.
I am ok with merging this
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149588601
Ping @karuturi @bvbharat @borisroman @wido @remibergsma @miguelaferreira
@DaanHoogland
Test Environment:
* Management Server + MySQL on Cen
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/959
CLOUDSTACK-8933 SSVm and CPVM do not survive a reboot from API
This closes PR #930 as well.
I Rebased @bvbharat's PR with latest Master and tested the SSVM/CPVM and
the routers:
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149458795
Hi @bvbharat , @karuturi and @remibergsma
I will push a new PR based on this one, with a rebase on latest master and
test reports.
Cheers,
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149456401
@karuturi @wilderrodrigues
Hi guys,
Thanks for taking this up and finalising. It would have taken at lest 4
days to start working on this again. appre
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149442522
@wilderrodrigues Talked to @karuturi and she said @bvbharatk doesn't have
time to work on this PR this week. Let's sit together and finalise.
---
If your projec
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149260290
Hi @remibergsma @karuturi @bvbharat
I ran the first tests and following the management server closely during
the tests. Although it all worked, the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149223151
Hi @karuturi @bvbharat @remibergsma
I'm testing this PR at the moment. I merged it together with #940. I want
to test if the changes on cloud-early-
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148340437
@bvbharatk OK, check. Let me know when you need. Happy to help testing. I
already tested rebooting the SSVM/CPVM and that works fine now.
---
If your project is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148299850
@bvbharatk I agree. That would help is handle the stop start case as well.
In addition if we could also make the outer while loop finite, that would
be good. ie)
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148297173
@remibergsma
The fix dose not cover the case of cmdline change when we stop start the
router. I said how i intend to fix this and waiting to see if other
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r42088163
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -128,7 +128,14 @@ get_boot_params() {
echo $pubkey > /
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r42088137
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -117,7 +117,7 @@ get_boot_params() {
if [ ! -e /dev/vport0p1
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148296716
Hi,
one way to fix this as i mentioned earlier is to send some data which will
tell us not to wait, using patchviasoket even when we reboot. This will sol
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148293227
@karuturi I think we can remove the loop only if we does not support Ubuntu
12.04 and CentOS 6.X any more.
This PR LGTM if we assume the virtio port will work
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148077678
I think this issue is happening due to the outer while loops which got
introduced in commit 50d756e87d26f0ac86e7897505ad2747735c4d5c
The outer loop waits until c
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148042852
@bvbharatk Thanks for the PR, I'll test it today or tomorrow.
Did you run the BVT tests that reboot the cpm and ssvm? If not, please do.
If you did, please po
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r41989612
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -128,7 +128,14 @@ get_boot_params() {
echo $pubkey >
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/930#discussion_r41989516
--- Diff: systemvm/patches/debian/config/etc/init.d/cloud-early-config ---
@@ -117,7 +117,7 @@ get_boot_params() {
if [ ! -e /dev/vport0
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-148011083
Testing OK.
Can you recover the change on line 120 ? it is not needed, right?
Checking the source code, I think 4.5 should have the same issue.
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-147991655
Based on the code this seems good to me. I haven't been able to verify it
though.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/930
CLOUDSTACK-8933 SSVm and CPVM do not survive a reboot from API
The issue is because we loop infinitely when we do not receive any cmdline
data during reboots. The current fix is to attempt one
36 matches
Mail list logo
