Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-162284129
@ustcweizhou Closing this PR as #1168 fixes the same issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/1166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-162249766
@anshul1886 Can you please close this PR or will you change to almost same
to #1168 ?
---
If your project is set up for it, you can reply to this email and hav
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-162048942
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1166#discussion_r46673018
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -459,12 +463,8 @@ public Strat
Github user ustcweizhou commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1166#discussion_r46672520
--- Diff:
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/StorageSystemSnapshotStrategy.java
---
@@ -459,12 +463,8 @@ public Stra
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-161936797
@anshul1886 and @ustcweizhou can you guys go in a ring about this and 1168
please. Both address the same issue in a slightly different way.
---
If your projec
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/1164
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-161898618
I just saw this PR, sorry, I created #1168 for 4.6
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161893553
@anshul1886 Thanks, you can close this PR as the other one will go to both
4.6 and master.
---
If your project is set up for it, you can reply to this email a
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161891307
Created PR https://github.com/apache/cloudstack/pull/1166 for 4.6.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1166
CLOUDSTACK-8845: Fixed list snapshots command throwing exception
https://issues.apache.org/jira/browse/CLOUDSTACK-8845
CLOUDSTACK-8845: Fixed list snapshots command throwing exceptio
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1164#issuecomment-161889769
@anshul1886 Thanks for the fix! Could you please make this PR against 4.6?
Once merged in 4.6, it will be fwd-merged to master. Thanks!
---
If your project is
GitHub user anshul1886 opened a pull request:
https://github.com/apache/cloudstack/pull/1164
CLOUDSTACK-8845: Fixed list snapshots command throwing exception
https://issues.apache.org/jira/browse/CLOUDSTACK-8845
Fixed list snapshots command throwing exception if any one of s
14 matches
Mail list logo
