Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-138771684
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
ena
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-138591416
ok, LGTM at least we now have success and failure tests and all checks pass.
We can add the more trivial tests for checkForKeyByPublicKey in a later PR
---
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-138492797
@DaanHoogland @kishankavala Have made some changes to test cases. Please
review.
---
If your project is set up for it, you can reply to this email and have your
rep
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-137254065
so now we are back to, "I would like to see two unit tests for
checkForKeyByPublicKey. The succes and the failure cases. I am not sure if this
check shows a ver
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-136934002
@DaanHoogland Removed the duplicate tests. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
I agree
On Mon, Aug 31, 2015 at 6:45 AM, kansal wrote:
> Github user kansal commented on the pull request:
>
> https://github.com/apache/cloudstack/pull/685#issuecomment-136250704
>
> @DaanHoogland Yes the first test in a way does the same thing only.
> The thing is that the second test
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-136250704
@DaanHoogland Yes the first test in a way does the same thing only. The
thing is that the second test is more intuitive in a way that it firsts
registers a key-pair (
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-135775262
@kansal it looks to me the new test tests exactly the same functionality as
the previous one. Can you elaborate on the difference? And more specifically
can we
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r38192659
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -354,6 +354,10 @@ CREATE VIEW `cloud`.`user_vm_view` AS
left join
`cloud`.`u
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-135747132
@DaanHoogland @kishankavala Added test case for checking the duplicate
key-pair registrations. Please review.
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-134919051
Can you add some tests, we'll need to test it before merging. @DaanHoogland
have you looked at it, since you had recently made some related changes or
might have ex
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-134088772
I would like to see two unit tests for checkForKeyByPublicKey. The succes
and the failure cases. I am not sure if this check shows a very good pattern
but that
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-134027948
@kishankavala @DaanHoogland Can you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-132482850
@DaanHoogland @kishankavala Have made changes regarding allowing the
duplicate keys for different accounts. DB checks are additional checks and API
level checks are d
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-131699503
@kishankavala @DaanHoogland @sedukull The API level check was already in
place but was not working because the check was done on the public key passed
from user befor
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-130539282
@kishankavala The current implementation of the createSSHKeyPair checks
for the keypair-name in the table ssh_keypairs and if that name exists it will
return "A keyp
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36940851
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_speed
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36858306
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_speed
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36857039
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_spe
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36856027
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36855563
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_spe
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36855515
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_spe
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36855422
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_spe
Github user sedukull commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36855234
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details` `custom_spe
Github user kishankavala commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-130282420
@kansal Can you add a similar check for duplicates keys in the
createSSHKeyPair API validation?
---
If your project is set up for it, you can reply to this ema
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/685
CLOUDSTACK-8727: API call listVirtualMachines returns same keypair
Currently the user can register same key with different names. Upon listing
the VM's the name which got registered first is bein
27 matches
Mail list logo
