Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-134088772
I would like to see two unit tests for checkForKeyByPublicKey. The succes
and the failure cases. I am not sure if this check shows a very good pattern
but that is out of scope for this PR. Other then unit tests missing, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
