Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/763
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/692
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/763#issuecomment-136309843
Thanks @remibergsma. Since this isnt my code, LGTM from me as well(The
actual PR also has 2 LGTMs). merging now
---
If your project is set up for it, you can reply
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/763#issuecomment-136306743
Works fine now, LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not hav
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/763
CLOUDSTACK-8725 RVR functionality is broken in case of isolated networks
conntrackd fails to start.
Rebased with master. This closes #692
You can merge this pull request into a Git rep
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/692#issuecomment-134952038
@bvbharatk The rebase is needed due to the 'PEP8' style fix that has been
done on CsRedundant.py Let me know if you need help :-)
---
If your project is set up
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/692#issuecomment-134932710
verified that conntrackd starts on redundant vpc routers.
LGTM in that respect.
Design wise i feel we need to refactor this, naming of copy_if_ne
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/692#issuecomment-134876392
@DaanHoogland OK, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does n
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/692#issuecomment-134863538
@remibergsma no, answer is clear and though my question expresses a
reservation on design level it should not stop this PR; => LGTM
---
If your project is set
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/692#issuecomment-134707371
@bvbharatk Had a quick look and it seems to solve the problem. Can you
please rebase against latest master so we can have a clean merge? Thanks!
@DaanHoo
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/692#discussion_r37269538
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,7 @@ def _redundant_on(self):
d = s.replac
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/692#discussion_r37056270
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,7 @@ def _redundant_on(self):
d = s.rep
Github user bvbharatk commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/692#discussion_r37048693
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,7 @@ def _redundant_on(self):
d = s.replac
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/692#discussion_r36970870
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
@@ -96,7 +96,7 @@ def _redundant_on(self):
d = s.rep
GitHub user bvbharatk opened a pull request:
https://github.com/apache/cloudstack/pull/692
CLOUDSTACK-8725 RVR functionality is broken in case of isolated netwoâ¦
CLOUDSTACK-8725 RVR functionality is broken in case of isolated networks,
conntrackd fails to start.
You can mer
15 matches
Mail list logo
