Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/692#discussion_r37056270
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/cs/CsRedundant.py ---
    @@ -96,7 +96,7 @@ def _redundant_on(self):
                     d = s.replace(".templ", "")
                 CsHelper.copy_if_needed("%s/%s" % (self.CS_TEMPLATES_DIR, s), 
"%s/%s" % (self.CS_ROUTER_DIR, d))
             CsHelper.copy_if_needed("%s/%s" % (self.CS_TEMPLATES_DIR, 
"keepalived.conf.templ"), self.KEEPALIVED_CONF)
    -        CsHelper.copy_if_needed("%s/%s" % (self.CS_TEMPLATES_DIR, 
"conntrackd.conf.templ"), self.CONNTRACKD_CONF)
    +        CsHelper.copy("%s/%s" % (self.CS_TEMPLATES_DIR, 
"conntrackd.conf.templ"), self.CONNTRACKD_CONF)
    --- End diff --
    
    then wouldn't the keepalived.conf always be needed as well? the use of 
copy_if_needed seemed very intentional.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to