Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/609
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-124330906
2 LGTMs and travis is green. I am merging this to master in sometime
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-124053986
to run from eclipse, you need to install Groovy eclipse plugin
https://code.google.com/p/spock/wiki/GettingStarted#Eclipse
---
If your project is set up for it, yo
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-124052158
ran tests from command line. code looks good. I use eclipse and did not
manage to run tests in the ide yet (no problem with the PR). HInts welcome :)
:+1: wait
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35308521
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to th
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35308512
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to th
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35308492
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to t
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35294032
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to t
Github user koushik-das commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-123998336
Once the comments are addressed, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293673
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed to t
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293652
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/OpenLdapUserManagerImpl.java
---
@@ -0,0 +1,233 @@
+// Licensed to the
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293580
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed t
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35293493
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapUserManagerFactory.java
---
@@ -0,0 +1,55 @@
+/*
+ * Licensed t
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292915
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFacto
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292860
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to th
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292815
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to th
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292608
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFa
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292541
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35292477
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291761
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to th
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291585
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/ADLdapUserManagerImpl.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291594
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -36,6 +36,8 @@
private static fin
Github user koushik-das commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35291227
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -36,6 +36,8 @@
private static
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-123954109
@DaanHoogland @abhinandanprateek @runseb @wilderrodrigues @bhaisaab Can you
please review this PR?
---
If your project is set up for it, you can reply to this emai
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-123668544
@DaanHoogland now you can run the tests from the command line or ide
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/609#issuecomment-123668417
```
root@Rajani's MS ~/source/cloudstack/plugins/user-authenticators/ldap
(CLOUDSTACK-8596)$ mvn clean test
[INFO] Scanning for projects...
[INFO]
[I
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35191354
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFacto
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35188707
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextF
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35184816
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFacto
Github user karuturi commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35184810
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -43,14 +45,14 @@
private ConfigurationD
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35181833
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextF
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35181750
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapConfiguration.java
---
@@ -43,14 +45,14 @@
private Configurat
GitHub user karuturi opened a pull request:
https://github.com/apache/cloudstack/pull/609
CLOUDSTACK-8596 ability to query nested groups for Microsoft AD
added a new configuration to select the appropriate ldap implementation
incase of microsoft AD enabled nested querying of grou
33 matches
Mail list logo
