Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/609#discussion_r35181833
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/ldap/LdapManagerImpl.java
---
@@ -57,17 +57,22 @@
private LdapContextFactory _ldapContextFactory;
@Inject
- private LdapUserManager _ldapUserManager;
+ private LdapConfiguration _ldapConfiguration;
+
+ @Inject LdapUserManagerFactory _ldapUserManagerFactory;
+
public LdapManagerImpl() {
super();
}
- public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManager ldapUserManager) {
+ public LdapManagerImpl(final LdapConfigurationDao
ldapConfigurationDao, final LdapContextFactory ldapContextFactory, final
LdapUserManagerFactory ldapUserManagerFactory,
+ final LdapConfiguration ldapConfiguration) {
--- End diff --
why inject and pass into constructor? is the ldap-provider-selector going
to change on runtime?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
