Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/106
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78440246
Tested against KVM works for me, closing. Merged on 4.5 and master.
Opened two ticket to track futher work on it to implement a SSL based
server and IPv6 sup
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78217077
@vincentbernat thanks for the snippets!
@resmo in case the passwdsrvrtoken went missing (file does not exist), the
script may break, the || true is just so t
Github user pdion891 commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78049653
@bhaisaab, can you confirm that if the password is not grap after a certain
period it expired (ex: 15mins), and also if the password is grap once, it is
not availabl
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78037787
In a general discussion, should the stored passwords be made expirable;
i.e. after a certain interval if the passwords are not served they expire, or
if within certa
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78034264
Thanks @vincentbernat @brutasse for your reviews, fixing them now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
Github user brutasse commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/106#discussion_r26112397
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip.py
---
@@ -0,0 +1,204 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user brutasse commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/106#discussion_r26112312
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip.py
---
@@ -0,0 +1,204 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user brutasse commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/106#discussion_r26112215
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/passwd_server_ip.py
---
@@ -0,0 +1,204 @@
+#!/usr/bin/env python
+# Licensed to the Apache
Github user vincentbernat commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78031911
Some remarks:
- Use `with lock:` instead of `lock.acquire()` then `try/finally`
(compatible with Python 2.6)
- Use `with file(...) as f:` (idem)
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/106
CLOUDSTACK-8272: Python based file-lock free password server implementat...
Major changes:
- VRs are single CPU, so Threading based implementation favoured than
Forking based
- Imp
11 matches
Mail list logo
