Github user vincentbernat commented on the pull request:
https://github.com/apache/cloudstack/pull/106#issuecomment-78031911
Some remarks:
- Use `with lock:` instead of `lock.acquire()` then `try/finally`
(compatible with Python 2.6)
- Use `with file(...) as f:` (idem)
- `global passMap` and `global lock` are useless since you don't do direct
assignments
- `getPassword()` could be `passMap.get(..., None)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
