Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-153688875
LGTM (just code, no testing performed)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-152306229
ran
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_vpc_redundant.py \
comp
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150911520
rerunning the ssvm and vpc tests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your projec
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150900227
@remibergsma code is updated
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150836618
@ustcweizhou Can you please rebase with current master so I can test this?
Thanks!
---
If your project is set up for it, you can reply to this email and have yo
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-150531546
Talked to @DaanHoogland and he wants this in 4.6. It seems like a feature
and not a bug fix, but pinging @karuturi to align.
---
If your project is set up for i
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-149947059
LGTM basic smoke test run failed on the load balancer tests only:
--
Ran 40 tests
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147969907
@wido the default value is 0, which means the statistics is disabled by
default.
I will remove the 300 seconds limitation if most of us agree.
the vm disk
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147962383
@ustcweizhou I understand the reasoning behind the 300 second minimal
interval, but isn't that up to the admin? If he/she wants to set it to 10
seconds on their cloud,
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/926#issuecomment-147961785
@wido I will add some debug/info log messages later.
Do you think if it is good to remove the hardcoded 300 seconds?
---
If your project is set up for it, yo
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961830
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -700,6 +734,121 @@ public void
doInTransactionWithoutResult(TransactionStatus status) {
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961770
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -310,8 +326,17 @@ private void init(Map configs) {
_executor.scheduleAtFixed
Github user wido commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/926#discussion_r41961743
--- Diff: server/src/com/cloud/server/StatsCollector.java ---
@@ -310,8 +326,17 @@ private void init(Map configs) {
_executor.scheduleAtFixed
GitHub user ustcweizhou opened a pull request:
https://github.com/apache/cloudstack/pull/926
CLOUDSTACK-7984: Collect network statistics for VMs on shared network (KVM
implementation)
For now we can get network traffic statistics from virtual router for
isolated network.
For ni
14 matches
Mail list logo
