Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1129#issuecomment-159993684
LGTM, on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user pdube commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1129#discussion_r46006607
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/template/DownloadManagerImpl.java
---
@@ -558,7 +558,9 @@ public String down
GitHub user DaanHoogland opened a pull request:
https://github.com/apache/cloudstack/pull/1129
CID-1339965 handle retrun value on failure
coverity reported this as new last week. It has been in the code for ever,
i.e. since initial git commit. Minor issue, easy fix.
You can merge t
