I strongly agree with this. There should be at least 2 LGTMs and a proof it's
being tested(logs, pictures etc..)
Bobby.
On 2.10.19, 14:37, "Daan Hoogland" wrote:
LS,
in the past we had set a set of rules in the community under which PR could
be merged. I want to reiterate them h
>> to (and doesn't do anything that it's not supposed to). It looks to me
>> that sometimes passing regression tests is seen as the change has been
>> tested. IMO regression test passing is a prerequisite of a PR being ready
>> for anyone other than the author(s) to st
;
see Rohit's last point.
[1] https://github.com/apache/cloudstack/pull/3580
-Original Message-
> From: Daan Hoogland
> Sent: 02 October 2019 12:37
> To: dev
> Subject: [DISCUSS][PROPOSAL]merge policy ratification
>
> LS,
> in the past we had set a set of rules i
, 2019 13:47
To: dev@cloudstack.apache.org
Cc: priv...@cloudstack.apache.org
Subject: RE: [DISCUSS][PROPOSAL]merge policy ratification
BUMP.
Hey Guys,
We have a lot of new people in the community these days; this seems like an
important exercise to ensure that we're all on the same page, whethe
lly, we have to catch mistakes where we can to make
> CloudStack as good as we can to keep people using it.
> >
> >
> > paul.an...@shapeblue.com
> > www.shapeblue.com
> > Amadeus House, Floral Street, London WC2E 9DPUK
> > @shapeblue
> >
> >
> &
l Street, London WC2E 9DPUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Sven Vogel
> Sent: 10 October 2019 10:48
> To: dev@cloudstack.apache.org
> Cc: priv...@cloudstack.apache.org
> Subject: Re: [DISCUSS][PROPOSAL]merge policy ratification
>
&
sing it.
paul.an...@shapeblue.com
www.shapeblue.com
Amadeus House, Floral Street, London WC2E 9DPUK
@shapeblue
-Original Message-
From: Sven Vogel
Sent: 10 October 2019 10:48
To: dev@cloudstack.apache.org
Cc: priv...@cloudstack.apache.org
Subject: Re: [DISCUSS][PROPOSAL]merge
>>
>>
>>
>> paul.an...@shapeblue.com
>> www.shapeblue.com
>> Amadeus House, Floral Street, London WC2E 9DPUK
>> @shapeblue
>>
>>
>>
>>
>> -Original Message-
>> From: Daan Hoogland
>> Sent: 02 October 2019 12:37
&g
ue.com
> www.shapeblue.com
> Amadeus House, Floral Street, London WC2E 9DPUK
> @shapeblue
>
>
>
>
> -Original Message-
> From: Daan Hoogland
> Sent: 02 October 2019 12:37
> To: dev
> Subject: [DISCUSS][PROPOSAL]merge policy ratification
>
> LS,
&g
ctober 2019 12:37
To: dev
Subject: [DISCUSS][PROPOSAL]merge policy ratification
LS,
in the past we had set a set of rules in the community under which PR could be
merged. I want to reiterate them here as it seems we are kind of slacking.
Please chime in if there are any issues or omissions:
For a
LS,
in the past we had set a set of rules in the community under which PR could
be merged. I want to reiterate them here as it seems we are kind of
slacking. Please chime in if there are any issues or omissions:
For a PR to be merged it has to adhere to the following conditions:
- In any case
-- A
11 matches
Mail list logo
