I strongly agree with this. There should be at least 2 LGTMs and a proof it's
being tested(logs, pictures etc..)
Bobby.
On 2.10.19, 14:37, "Daan Hoogland" <daan.hoogl...@gmail.com> wrote:
LS,
in the past we had set a set of rules in the community under which PR could
be merged. I want to reiterate them here as it seems we are kind of
slacking. Please chime in if there are any issues or omissions:
For a PR to be merged it has to adhere to the following conditions:
- In any case
-- A PR has to have had two approving reviews
-- A PR has to have no outstanding requests for changes. A request for
changes is regarded no longer outstanding if the requester stops responding
on the PR discussions.
-- A PR has to have a review with verification description. Depending on
the type of PR this can be a test description, an automated test included,
screenshots in case of UI changes. If it is a tetual change it must be
verified to not apply to logs or events.
- any commiter can merge a PR if it adheres to those conditions
-- unless a freeze has been called by a the branch it is to be merged on by
a community appointed release manager for that branch
hope this is short and complete enough at the same time. It has been agreed
upon in the past but I am too lazy to find the mail thread in the archives.
If anyone disagrees we'll have to go there. They seem reasonable and
self-evident to me. I am also not sure if these should be stated in bylaws
or on github, so comments in that respect are welcome as well. Let's first
again agree on them.
regards,
--
Daan
boris.stoya...@shapeblue.com
www.shapeblue.com
Amadeus House, Floral Street, London WC2E 9DPUK
@shapeblue
