Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/1177#issuecomment-162448978
Seems like we have the same problem in the XenServer code, as I stated
earlier in another pull request somewhere out there, where this code originates
from
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/1163#issuecomment-161921763
Aloha,
Nice find Remi, thanks for fixing this! LGTM.
Cheers,
Funs
---
If your project is set up for it, you can reply to this email and
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-152379017
Sorry guys been a bit in flight, yes @DaanHoogland has point but tbh we
should fix that everywhere in one go for all the hypervisors not to be a
dick, but just
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/975#issuecomment-150917774
@remi: yep did the OVM3 dance, together with KVM and separately from OVM3.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user snuf closed the pull request at:
https://github.com/apache/cloudstack/pull/962
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150657334
@NuxRo @karuturi Superseded by #975 and in . Closing this one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/975
Ovm3HypervisorGuru wrong answer and snapshot to volume implementation.
Fixes the wrong answer that is given for host delegation, the snapshot to
volume is implemented and a small logger is added
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/964#issuecomment-150653911
@remibergsma thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150652979
@remibergsma not for the HypervisorGuru, as they are really specific, It
does however conflict with the original idea behind the Gurus if I'm not
mistaken, as a
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150647256
@Nuxro @remibergsma @karuturi by adding a simple log line to the
XenServerGuru.java you get the following when doing a snap to vol and a snap to
temp:
'2015-
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150642505
@NuxRo @remi it works like a charm and also prevents little accidents from
happening. The interesting thing is that the XenserverGuru.java contains the
exact same code
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150590628
@NuxRo here's a list, there is no KVM Guru... ?
funs@cs-mgmt:~/cloudstack/plugins/hypervisors$ find . -type f -name *.xml |
xargs grep -A 1 Guru | grep pro
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150536000
@NuxRo tested all the scenarios and I'm getting different results as before
and different results than you, this is an excerpt of the log testing the
various op
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150525837
@borisroman problem is that some of our jenkins build slaves ("our" are the
project ones) fail, so "restarting" it and hoping you'll end up on
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150257035
@NuxRo interesting... I'm checking out my commit again and rebuilding to
test again, I'm running both at the same time though... so that might explain
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-150176025
Values are inline with the guest_os table and inserts the inserts all work
so LGTM!
---
If your project is set up for it, you can reply to this email and have your
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/964
FIX: Ovm3 physical network traffic labels to work.
The labeling was broken. Only labels assigned at zone creation
were used, changing labels was not working. Tested with changing
a label
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/962#issuecomment-150142734
Eh that's odd, it's supposed to wait for 2 seconds, waited for 1.002 and
then fails because it waited too short ? what am I missing here ? :)
---
If your
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-150064890
@karuturi @NuxRo @ustcweizhou could you please check
[#962](https://github.com/apache/cloudstack/pull/962) for the details as #954
could then be closed and #962 could
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/962
CLOUDSTACK-8964: Fix KVM snap to vol and snap to templ, no delegate for
Ovm3.
Snapshot to volume, snapshot to template was tested with KVM.
Ovm3 does not have this functionality yet. The
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-149995084
karuturi yep you're right! looking at the code something went wrong with
lifting it over.
---
If your project is set up for it, you can reply to this email and
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/743#issuecomment-135327593
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/749#issuecomment-135324787
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/737#issuecomment-134558902
Wow, great code and tests!. Love what you did with the Restclient, will be
using that for sure soon :).
LGTM!
---
If your project is set up for it, you can
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/700#issuecomment-132653773
@rafaelweingartner I think it's good that you wrote the unit tests, and I
actually wished people were a bit more supportive. I strongly agree with
@remibergs
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/719#issuecomment-132636109
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/693#issuecomment-131097876
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/678#issuecomment-129909452
lgtm, tested and uploads without the file there now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/576
Improved message for peeples to actually see what the problem is.
The original message obfuscates what the real problem is, and requires
people to dig through the source to figure out that a
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/152#issuecomment-91203299
@bhaisaab some people are afraid that the local log will not be updated
(see pull request
https://github.com/apache/cloudstack/pull/140#issuecomment-89006232 and
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/133#issuecomment-86900876
That's what e7d7643 "Only one thing can come from the agent" commit is for
:)
---
If your project is set up for it, you can reply to this email and
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/133
Ovm3firefix: fixes for unit tests on Windows and for running management on
Windows.
Some of the unit tests fail on Windows as File.separator was used, using it
might seem like a good idea as
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78455032
@bhaisaab @likitha cool thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78436606
@likitha Hmm the format is indeed different, though the content is the
same, mine is the one that comes with eclipse and has a full line of * at the
top and bottom and
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/113#issuecomment-78336094
@bhaisaab thanks man!, it's bound to have some bugs and nasty bits here and
there. Already have NSX/NVP integration on the map for the next iteration
though :)
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/99#issuecomment-78311833
@bhaisaab move this into https://github.com/apache/cloudstack/pull/113
which is a new request, and a bit more condensed.
---
If your project is set up for it, you
Github user snuf closed the pull request at:
https://github.com/apache/cloudstack/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user snuf opened a pull request:
https://github.com/apache/cloudstack/pull/113
Ovmsupport 3.2.1/3.3.x rebased and condensed in one single commit.
@bhaisaab
Rebasing the other stuff was a pain (4400 commits behind is no pleasure).
Decided to do a "re-impl
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/9#issuecomment-77004275
Kay happy to report it was a problem in my rollout script which I changed
recently *cough* so everything is fine, itâs just that the change left out
the vlan range, so
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/9#issuecomment-76862484
Hey Rohit,
Well all was fine until I did my last two merges from master after doing
the 3.3.x integration of OVM, allocate vnet breaks and rolls back on the DB
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/9#issuecomment-66134697
Hi Rohit,
Well there are a couple of things here:
1st: I work on a fork and pull in upstream master and merge that into
ovmsupport (https://github.com
Github user snuf commented on the pull request:
https://github.com/apache/cloudstack/pull/9#issuecomment-65893442
Hey Rohit,
Itâs been rebased with master two days ago, so should be a âbreezeâ,
is there a specific point you want me to merge with ?
Cheers
42 matches
Mail list logo
