Github user runseb commented on the issue:
https://github.com/apache/cloudstack-www/pull/27
@rhtyd +1 LGTM
note that to publish in the site live, you need to merge master in asf-site
branch
---
If your project is set up for it, you can reply to this email and have your
Github user runseb commented on the issue:
https://github.com/apache/cloudstack/pull/1435
LGTM
I still think we need to put the db in another container, and start the
whole thing with compose.
Also we need to make the image smaller, maybe using Debian as base would be
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1461#issuecomment-205170921
+1 LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-202369219
+1 to all the Travis changes based on code review and verification of
travis tests. I would have put those changes in a separate PR however.
---
If your project is
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1442#issuecomment-197508210
@chrismattmann how about you send email to private@ before sending some
dummy PR.
thank you
---
If your project is set up for it, you can reply to this email
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1442#issuecomment-197508627
Which ironically we can't close, so I hope @chrismattmann you will close
it, thank you
---
If your project is set up for it, you can reply to this email and
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/28#issuecomment-184700241
quick glance + 1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/24#issuecomment-184700198
quick glance, +1 LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1411#issuecomment-184633589
@DaanHoogland @sanjeevneelarapu you guys are writing the code so I have
nothing to say...but @remibergsma asked for updating the PR message and nothing
was done
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1011#issuecomment-182255888
Please revert asap, there is an IP in there that should not be there.
-1
---
If your project is set up for it, you can reply to this email and have your
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/commit/56859c99041c66d417bf0af9a93b1d6e1e79005b#commitcomment-15999267
In tools/marvin/marvin/config/test_data.py:
In tools/marvin/marvin/config/test_data.py on line 798:
why on earth are
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1288#issuecomment-176115753
@bhaisaab @remibergsma @DaanHoogland ok then, just checking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-176108973
@bhaisaab actually I am not even seeing the travis runs here anymore.
Reason I am asking is genuine (again), because in the last few months
Travis has shown
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1288#issuecomment-176107957
Hi @bhaisaab I am genuinely asking because of the new release principles:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Release+principles+for+Apache
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1274#issuecomment-175834162
@bhaisaab @pdube @DaanHoogland @koushik-das lots of LGTM here , so great.
but we don't know why you LGTM'd and as far as I know no tests were run...
-
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1288#issuecomment-175833323
Folks, I did not have time to fully test the new merging process from
@DaanHoogland and @remibergsma but let's assume this is good to merge should
this real
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/16#issuecomment-171586237
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/15#issuecomment-170473016
@terbolous can you merge and close this ?
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/15#issuecomment-168970370
+1 feel free to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168932762
LGTM +1 merging
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/14#issuecomment-168619811
@KrisSterckx I just replied with a few comments. Once addressed I can merge
Thanks for the docs
---
If your project is set up for it, you can reply to this
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs/pull/14#discussion_r48714173
--- Diff: rtd/source/networking/nuage-plugin.rst ---
@@ -0,0 +1,249 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs/pull/14#discussion_r48714149
--- Diff: rtd/source/networking/nuage-plugin.rst ---
@@ -0,0 +1,249 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs/pull/14#discussion_r48714090
--- Diff: rtd/source/networking/nuage-plugin.rst ---
@@ -0,0 +1,249 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+ or
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-install/pull/26#issuecomment-166272998
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs/pull/13#issuecomment-166272954
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/34#issuecomment-166272973
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/23#issuecomment-166268913
tested, LGTM +1
merging now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/27#issuecomment-164375548
Looks good, but I think it's missing some features:
- quota
- Nuage ?
pinging @remibergsma
---
If your project is set up for it, yo
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/815#issuecomment-164369338
-1
Just on the fact that "it runs on my machine" is the single most horrible
reason to justify working software.
---
If your project is set
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-160568739
@rafaelweingartner there has been lots of discussion on the list about
testing. The TravisCI setup is supposed to do part of it, and we can also
trigger the tests
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/20#issuecomment-159668471
@bhaisaab can you bring this to the list ? I think it would be best
discussed there.
---
If your project is set up for it, you can reply to this email and have
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/26#issuecomment-159667765
so on second reading @pdion891 you added removal of awsapi for RPMs but not
for Ubuntu...
---
If your project is set up for it, you can reply to this email
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/20#issuecomment-159539414
Let's hear it from @ke4qqq as VP of infra.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/20#issuecomment-159539257
I think it is quite fair. The source is the official release, and the
packages are not official.
I don't know that we will ever be able to offer off
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/26#issuecomment-159537788
aside from the typo, LGTM cc/ @remibergsma
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack-docs-rn/pull/26#discussion_r45841371
--- Diff: source/about.rst ---
@@ -89,6 +89,21 @@ Link
https://hub.docker.com/u/cloudstack
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157396108
@pdion891 let me check with @abhinandanprateek I might be wrong
---
If your project is set up for it, you can reply to this email and have your
reply
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-157389188
@pdion this should be on the master branch not in the 4.6 branch since
quota have not yet been merged...correct ?
---
If your project is set up for it
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-install/pull/25#issuecomment-157308289
+1 looking at the changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/18#issuecomment-157307389
a bit difficult to review since the files are long.
+1 to merge and update if we see any errors on the live site.
---
If your project is set up for it, you
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-154335646
ok so bottom line, it seems reviews are +1 and we will merge this in 4.7.
ASAP after 4.6.0 is out, taking.
the only thing will be to keep an eye on it and
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/999#issuecomment-154050476
+1 LGTM , does not touch core, totally independent code, only affects the
behavior of built docker images.
---
If your project is set up for it, you can reply to
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1018#issuecomment-154050065
simple enough, but why is Jenkins failing, the link even goes 404.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1034#issuecomment-154048544
+1 LGTM, just looked at the code, did not check the actual UI rendering.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/997#issuecomment-153775777
nope, I'd like to figure out why tests are not running. Just have not found
the time to do so.
---
If your project is set up for it, you can reply to this emai
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/1032#issuecomment-153665922
+1 LGTM just looking at the translated strings. did not build it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153631839
@DaanHoogland yep, so we can release this right on the heel of 4.6 release,
with just one commit to get 4.7.
---
If your project is set up for it, you can reply to
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/801#issuecomment-153629584
@jburwell I hear what you are saying, but I think it would be totally
unfair to ask this plugin provider to provide independent testing capability to
the community
GitHub user runseb opened a pull request:
https://github.com/apache/cloudstack/pull/997
Add all tests in /test/integration/smoke to Travis run and nove nicirâ¦
Adds all tests in smoke folder to Travis.
Moves nicira test to /test/integration/plugins
You can merge this pull
Github user runseb closed the pull request at:
https://github.com/apache/cloudstack/pull/920
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/920#issuecomment-151585450
@borisroman yes will do tonight
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-151584850
@nitt10prashant @pvr9711 please close this thread I will take care of
moving the file
---
If your project is set up for it, you can reply to this email and have
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/960#issuecomment-150178317
I think you guys agree on the problem but disagree on the solution.
To me 100% success on BVT, if it includes ~20% (or whatever percentage) of
skipped tests is
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/947#issuecomment-149170965
wasn't there an issue about the license of this connector some time back?
What's the current license ? is it ASF compliant ?
---
If your project is set
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/948#issuecomment-149168945
+1 LGTM based on code review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/920#issuecomment-147706546
Sanjeev, good point, Travis only runs advanced zone tests. Maybe we should
figure out a way to also run the tests with a basic config.
---
If your project is set up
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/16#issuecomment-147640430
you can merge. but make sure to merge in the other branch as well,
otherwise it won't go live.
---
If your project is set up for it, you can reply to this
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/16#issuecomment-147636042
+0
I don't think we need two LGTM etc for this.
But it's automatically built, so you don't need to touch the .html.
Jut edit th
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/920#issuecomment-147081834
looks like all tests passed but in fact some did not run...someone needs to
check what happened exactly
---
If your project is set up for it, you can reply to this
GitHub user runseb opened a pull request:
https://github.com/apache/cloudstack/pull/920
Add all tests in /test/integration/smoke to Travis run
This modified .travis.yml file to include missing tests in
/test/integration/smoke.
It expands the coverage of the Travis runs.
You
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-146119100
I agree on principles, but I have not tested any of this. would be good if
@SudharmaJain could confirm that this PR fixes his problem.
---
If your project is set up
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/897#issuecomment-145662988
thanks @nitin-maharana maybe we should have a small performance study to
show that it actually speeds things up
---
If your project is set up for it, you can reply
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/903#issuecomment-145662476
@nitin-maharana Any automated tests for this ? if not, can you spend the
time to write some. thanks
---
If your project is set up for it, you can reply to this
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-145662123
@rags22489664 any comments based on the reviews ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/905#issuecomment-145661688
@yvsubhash we should try to remove manual testing. Can you write a marvin
test for it. thanks. cc @wilderrodrigues
---
If your project is set up for it, you can
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/912#issuecomment-145661229
@milamberspace @remibergsma there is a duplicate at
https://github.com/apache/cloudstack/pull/906
---
If your project is set up for it, you can reply to this email
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41171193
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41171391
--- Diff: tools/docker/init.sh_centos6 ---
@@ -17,27 +17,35 @@
# under the License.
#
# update database connection
+# /usr/bin
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41120457
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/910#issuecomment-145461959
aside of the vhd-util download, +1 LGTM based on code review.
Does not impact cloudstack core
---
If your project is set up for it, you can reply to this email
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/910#discussion_r41119897
--- Diff: tools/docker/Dockerfile.centos6 ---
@@ -23,15 +23,19 @@ LABEL Vendor="Apache.org" License="ApacheV2"
Version="4.6.
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/904#issuecomment-144703355
@wilderrodrigues why do you want the PR to get closed ? Can't this be
amended to provide the proper fix ?
---
If your project is set up for it, you can rep
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/891#issuecomment-144361701
@nitin-maharana thanks for this.
LGTM +1 based on code review and look at snapshot.
Somehow might want to compile and test fresh.
---
If your project is set
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/891#issuecomment-144333775
@nitin-maharana LGTM +1 based on code review.
Maybe adding two snapshots to compare would help review (just a thought)
---
If your project is set up for it, you
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/874#issuecomment-144332355
We won't be able to test this on simulator.
@harikrishna-patnala can you answer @borisroman and then we can merge.
LGTM +1 on code review alone
---
If
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/873#discussion_r40771703
--- Diff: server/src/com/cloud/storage/StorageManagerImpl.java ---
@@ -1736,7 +1737,10 @@ public boolean
storagePoolHasEnoughSpace(List volumes
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/869#issuecomment-144331549
@pritisarap12 can this be run via simulator ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/868#issuecomment-144322859
@anshul1886 Can you add a bit of a description here.
Is that fixing a bug, is that a new feature ? Can you add Travis tests to
check this ?
many thanks
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/871#issuecomment-144322464
@pavanb018 it always helps other folks reviewing to know what you did. For
example.
Did you just check the Travis green light ? Did you just check the code
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/861#issuecomment-144320963
@harikrishna-patnala and @koushik-das I agree with @remibergsma please
advise on how you want to proceed, considering #883 reimplements the 602
resource.
---
If
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/857#issuecomment-144317611
@remibergsma that one is tough to test as @karuturi mentions. so I am with
@wido here +1 on code review. Small enough.
We need to think further on how to handle
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/859#issuecomment-144316351
Hi @kishankavala can we run some simulator tests to check this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/847#issuecomment-144315690
Hi @kishankavala if you can answer @remibergsma and @borisroman questions,
we can move forward with your PR.
---
If your project is set up for it, you can reply to
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/889#issuecomment-144315290
LGTM, small change.
@wido what tests can be run to check for this.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/898#issuecomment-144314489
In issues like this, we should track which automated test fails.
If no test can check for that, then we need to write one and submit it in
the PR.
BTW
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/893#issuecomment-144048504
LGTM based on code review (1 line removed, 2 lines added).
This does not change cloudstack code, the Dockerfile is only used by the
docker hub to build the
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/887#issuecomment-143140589
@jayapalu @SudharmaJain can you check this asap, as it merges all your past
PRs in one and rebases with master. thanks
---
If your project is set up for it, you can
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-ec2stack/commit/1cbbfa6b6db415780cb1f2a30b778c9309bf1c18#commitcomment-13198360
I noticed that after the fact...we should probably move it to python..
---
If your project is set up for it, you can
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/15#issuecomment-136609778
@terbolous yes, there was a DDOS against ASF servers and the PMC was
informed.
---
If your project is set up for it, you can reply to this email and have your
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/30#issuecomment-135085249
LGTM +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-www/pull/12#issuecomment-135084679
LGTMBTW, the github notifications were not going to dev@, that's why we
did not see it. It's fixed now.
---
If your project is set up for it, you
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/372#issuecomment-134929897
We should keep it open though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/372#issuecomment-134929830
@bhaisaab this came out from a roadmap item suggested by @pyr, but it seems
he has not had time to review and comment. So this is a bit stuck I am afraid.
---
If
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack-ec2stack/pull/1#issuecomment-133505244
testing comment notification, DISCARD
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/625#issuecomment-132254920
This will be turned ON by default ?
I think you should bring this up on the list, at least to give a heads up
and an official public record.
---
If your project
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/699#issuecomment-132253698
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/697#issuecomment-132253810
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user runseb commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/699#discussion_r37314162
--- Diff: client/WEB-INF/classes/resources/messages_es.properties ---
@@ -808,7 +808,7 @@ label.skip.guide=He utilizado CloudStack anteriormente,
saltar
Github user runseb commented on the pull request:
https://github.com/apache/cloudstack/pull/704#issuecomment-132253205
so there is nothing in this custom.css file ?
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
1 - 100 of 201 matches
Mail list logo
