[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-11 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 Ok, then. Thanks @ustcweizhou and @remibergsma for the clarification, changing the code to add vpcid on the nic's network response. Closing this PR in favor of a new and

[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...

2017-03-11 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1999 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou let us discuss this on ML. I am now doing exactly this querying ListNetworks for each network for each VM which is stupid expensive operation to only find out if a VM is in a VPC

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou I can add another VPC tier in the _same_ VPC to the VM, but it is still the same VPC. I am still convinced this PR is valid unless you prove otherwise. I am ok with adding

[GitHub] cloudstack issue #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC ID to ...

2017-03-10 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1999 @ustcweizhou (1) I don't fully understand that question, there are network ids on the nics https://github.com/resmo/cloudstack/blob/705336af9d03b680c3254d37376ae22b146e97e8/server/sr

[GitHub] cloudstack pull request #2000: CLOUDSTACK-8873: add zonename in load balance...

2017-03-10 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/2000 CLOUDSTACK-8873: add zonename in load balancer response add zonename in response for consistency. You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cloudstack pull request #1999: CLOUDSTACK-9600: listVirtualMachines: add VPC...

2017-03-10 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1999 CLOUDSTACK-9600: listVirtualMachines: add VPC ID to response Currently, the listVirtualMachines takes the vpcid as a param but does not return it in a response. It also solves expensive

[GitHub] cloudstack issue #1923: CLOUDSTACK-9765: centos: packaging: fix missing path...

2017-02-02 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1923 @borisstoyanov is there a way to get the packages build by @blueorangutan? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1923: CLOUDSTACK-9765: centos: packaging: fix missing path...

2017-02-02 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1923 @rhtyd done. changed base to 4.9 ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1923: CLOUDSTACK-9765: centos: packaging: fix missi...

2017-01-31 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1923 CLOUDSTACK-9765: centos: packaging: fix missing path in spec file Related to 6051fa503a2da7b96256f21e6b7c42aa1f3cb01e You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-12-09 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 ok, np closing for now --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cloudstack pull request #1769: tools: fix Dockerfile

2016-12-09 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1769 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack issue #1815: Fix docker image build for cloudstack-management

2016-12-05 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1815 IMHO this is not meant for production, but quick fire up a docker having the current state of development. The image will be huge but for non-devs (like me) a easy way to get a running devel

[GitHub] cloudstack issue #1435: Dockerfile4.9

2016-12-01 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1435 I used it for development and testing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-30 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 @pdion891 I would say merge #1435 first --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1769: tools: fix Dockerfile

2016-11-25 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1769 I didn't test #1435 yet, but code looks good. The only difference I see is: ~~~ pip install cryptography --force-reinstall ~~~ And I used the mysql connector from MySQL.co

[GitHub] cloudstack pull request #1769: tools: fix Dockerfile

2016-11-22 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1769 tools: fix Dockerfile Build a docker image did not work anymore for various reasons. This is how I fixed it You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack issue #1637: Command route not available on CentOS 7

2016-09-18 Thread resmo
Github user resmo commented on the issue: https://github.com/apache/cloudstack/pull/1637 speaking about things not available per default on CentOS 7 --> `ifconfig`. Found 1 or 2 of these as well. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-05-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1257#issuecomment-221216726 would like to see this fixed, @sureshanaparti can I help you out? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-220141803 @rhtyd I am not aware of any no. Just wanted to point out that oracle "sucks" and openjdk should be the jdk that should be tested and supported in the firs

[GitHub] cloudstack pull request: [WIP][4.10+/long-term] Moving towards Jav...

2016-05-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1546#issuecomment-219975396 We use, when ever possible, openjdk as we get support from the distribution. Support for openjdk be it 7 or 8, manually patching oraclejdk is time consuming

[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...

2016-05-04 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1266 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: SystemVM cleanups

2016-05-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1414#issuecomment-216683077 @rhtyd rebased and squashed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: CLOUDSTACK-9336 surround the execution of...

2016-05-02 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1463#issuecomment-216354228 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: speedup iptables setup

2016-04-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1449#issuecomment-204500797 LGTM! please merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2016-02-22 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-187360919 @sureshanaparti yes, that would be great --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: SystemVM cleanups

2016-02-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1414#issuecomment-185579250 Actually the logrotating is running every hour (by size), which can not be done with logrotate time interval. We have had problems in the past filling up /var (and

[GitHub] cloudstack pull request: SystemVM cleanups

2016-02-16 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1414 SystemVM cleanups from the logrotate docs > size - With this, the log file is rotated when the specified size is reached. Size may be specified in bytes (default), kilobytes (sizek),

[GitHub] cloudstack pull request: UI: improve filter dropdown width

2016-01-20 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1354 UI: improve filter dropdown width Giving a little more space to fix new line, see [after and before](https://photos.google.com/share

[GitHub] cloudstack pull request: Enhance VR performance

2016-01-18 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1346#discussion_r49976226 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py --- @@ -901,79 +901,123 @@ def processStaticNatRule(self, rule): def

[GitHub] cloudstack pull request: CLOUDSTACK-9203 Implement security group ...

2016-01-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1297#issuecomment-168295696 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: README: happy holidays!

2015-12-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1281#issuecomment-166980994 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [4.4] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-12-21 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1266 [4.4] CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties cherry-picked e7291fd600ce922a76b1fe9cd2c120a40d4cbc18 for 4.4 so bug can be closed after merging into 4.4. You can merge this pull

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165712661 since #1257 replaces this PR I would do so, yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9174: A deleted account result...

2015-12-17 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1254#discussion_r47931786 --- Diff: plugins/database/quota/src/org/apache/cloudstack/api/command/QuotaSummaryCmd.java --- @@ -59,7 +59,7 @@ public QuotaSummaryCmd

[GitHub] cloudstack pull request: CLOUDSTACK-9185: [VMware DRS] VM sync fai...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1256#issuecomment-165420030 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165413590 @sureshanaparti that would be great. appreciate your work on vmware parts! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165410616 @sureshanaparti Ok, I see. then I would indeed use old but suggest `oldest` : `findExistentHypervisorHostInCluster`. Would you mind rebasing to get a clean PR

[GitHub] cloudstack pull request: CLOUDSTACK-9175: [VMware DRS] Adding new ...

2015-12-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1248#issuecomment-165088002 `older` is a bit misleading, what about `existent` e.g. findExistentHypervisorHostInCluster? --- If your project is set up for it, you can reply to this email and

[GitHub] cloudstack pull request: [HOLD] CLOUDSTACK-9042: remove unused edi...

2015-12-10 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1093 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8892:If VR enters out-of band ...

2015-12-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1158#issuecomment-161684501 big -1 We tested out of band migrations on VR on VMware and they work without reboots. A VM/VR does not "loose" the IP just because it get

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-12-02 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-161286193 Code LGTM, not yet tested though. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-12-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160990441 @pdube good timing, testing it right now. expect feedback today. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: Forgotten license added

2015-11-28 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1137#issuecomment-160339609 GPL?! ...naa just kidding. LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

2015-11-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160200278 awesome job! can not wait to get it tested. If all is fine, it would be great if it gets into 4.5.3 (/cc @bhaisaab) and 4.6.1 (/cc @remibergsma). I know a

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-20 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1045#issuecomment-158350734 @remibergsma @bhaisaab, no, not yet, created a patch for master before release of 4.6 #1042 but I was told it is not necessary, script is not used, was replaced by a

[GitHub] cloudstack-www pull request: add swiss txt to cloudstack users

2015-11-20 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack-www/pull/19 add swiss txt to cloudstack users You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack-www patch-1 Alternatively you can

[GitHub] cloudstack pull request: CLOUDSTACK-9042: remove unused edithosts....

2015-11-19 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1093 CLOUDSTACK-9042: remove unused edithosts.sh As discovered in CLOUDSTACK-9042, this script contains some issues but since it was replaced since 4.6, we remove it on master. Also see

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-19 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1045#issuecomment-158030442 Our test case on ACS 4.5.1: # Before fix ## vanilla router deployed: ~~~ # related script ae693b5ef2d9b1fed1307f6b38213823 /opt/cloud/bin

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo closed the pull request at: https://github.com/apache/cloudstack/pull/1042 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155082318 ok, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-09 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-155078020 @remibergsma since this buggy script is still there in master branch we should IMHO either merge this PR or remove the script from master branch. Remove it? --- If

[GitHub] cloudstack pull request: CLOUDSTACK-9043 Remove \n (new line) in G...

2015-11-08 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1043#issuecomment-154861335 code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-9042: VR: DHCP: fix miss...

2015-11-07 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1045 [4.5] CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties in /etc/dhcpentries.txt we had: 02:00:1e:07:01:53,set:10_102_92_5,10.102.92.5,songlog-1,infinite 02:00:0b:a2:00:3d,set

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154436021 @remibergsma okay, never mind for false alarm then. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154426348 @remibergsma @ustcweizhou updated and rebased the patch with some more fixes... --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1042#issuecomment-154414891 @ustcweizhou seeing some more potential problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: CLOUDSTACK-9042: VR: DHCP: fix missing DH...

2015-11-06 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/1042 CLOUDSTACK-9042: VR: DHCP: fix missing DHCP host enties in /etc/dhcpentries.txt we had: 02:00:1e:07:01:53,set:10_102_92_5,10.102.92.5,songlog-1,infinite 02:00:0b:a2:00:3d,set

[GitHub] cloudstack pull request:

2015-11-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/commit/34fee547cd10025f91e47e5efa6a97a96dd96313#commitcomment-14176906 German is now fully translated --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-11-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-153425811 agreed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: findbugs: ! equals instead of !=

2015-11-01 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1019#issuecomment-152939410 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8993: DHCP fails with "no addr...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/981#issuecomment-152302053 is 4.5 also affected by this issue? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152163454 Yes I see, but the label "IP address" does not indicate that it is the first NIC's IP address :). It might make sense to change the label to be more

[GitHub] cloudstack pull request: [4.6/master] ui/instances: show IP addres...

2015-10-29 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/1003#issuecomment-152160447 hmm, in a advanced network setup, these IP address would be the private IPs but if it has a static NAT, the VM would also have a public IP. For a user, it

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-8848: ensure power state...

2015-10-11 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/922 [4.5] CLOUDSTACK-8848: ensure power state is up to date for missing PowerState handling 1:1 cherry-picks, see #909 You can merge this pull request into a Git repository by running: $ git

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-30 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-144346880 well I need it in 4.5.3. I would suggest we take this fix for now for 4.6 as well and make a proper refactor for 4.7/5.0. --- If your project is set up for it, you

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143591694 @remibergsma done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143549250 @karuturi @anshul1886 So, I 'll checked the handling again and what I see is, it will not work with this one line change only: ~~~ Date vmStateUpdat

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143544132 @karuturi I understand what @anshul1886 trying to point out: the powerState should already be updated to the new state `powerReportMissing`. And because it

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

2015-09-25 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/890#issuecomment-143290823 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-25 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143227931 I successfully tested the patch on 4.5.2: ~~~ 2015-09-25 15:38:11,953 WARN [c.c.v.VirtualMachinePowerStateSyncImpl] (DirectAgentCronJob-7:ctx-65344d8a

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-142950081 It is actually not easy to test because you must hit a race condition. What I do is on vCenter make a few migrations of a VR to another hosts and look on the

[GitHub] cloudstack pull request: Use java.io.tmpdir instead of hardcoded /...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/884#issuecomment-142945491 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-24 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/885 CLOUDSTACK-8848: ensure power state is up to date when handling missi… …ng VMs in powerReport There 2 things which has been changed. * We look on power_state_update_time

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-142941464 /cc @DaanHoogland @koushik-das @anshul1886 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142940617 So I made a new PR #885 as a replacement for new discussion how this issue can be solved. IMHO this PR can be closed --- If your project is set up for it

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142912573 Cloud you follow my explanations? If this would help, I must set the ping interval to a year or somewhat identical. Are you REALLY followed my explanations? What did

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142906721 This is perfectly clear to me. The problem is we are relaying on the `update_time` (not to mix up with `power_state_update_time

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142901959 Increasing the grace period for a few minutes won't help. If you look at these update_time values I queried from 10 running routers, you see these are days,

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-24 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-142882541 @anshul1886 @koushik-das @DaanHoogland and I had a debug session last friday, and since he is off for the next couple of days I can give you more details about

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-18 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-141407138 @koushik-das @DaanHoogland unless we have a "better" solution I would like to go with @anshul1886 suggested fix. It seems the best way not breaking any

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140879864 @remibergsma does not look related to me, the keyword seems to be PowerReportMissing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: This is the fix for the JIRA issue CLOUDS...

2015-09-13 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/810#issuecomment-139913727 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: CLOUDSTACK-8821: UI Change while configur...

2015-09-10 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/791#issuecomment-139223195 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request: debian: Updated dependencies for Packages

2015-09-08 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/783#issuecomment-138466873 It depends, openjdk-8 would not work with current init script in my opinion. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-08 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-138465486 I prefer a persistent config (you know where to search for it) and not a dynamic one with hard coded values. If these would be dynamic, then it is clear to use the

[GitHub] cloudstack pull request: debian: Updated dependencies for Packages

2015-09-08 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/783#issuecomment-138463931 IMHO we need some more changes here, and it might be more clear and easier to handle if we would make a package per ubuntu release and debian release, beginning from

[GitHub] cloudstack pull request: sysctl: don't modify /etc/sysctl.conf

2015-09-04 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/776#issuecomment-137751754 Salut Vincent I agree, but AFAIK there is a `/etc/sysctl.d` directory intended for persistent sysctl configs. What about adding a `cloud.conf` to `/etc

[GitHub] cloudstack pull request: config: doc: add default value 10 in desc...

2015-09-04 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/777 config: doc: add default value 10 in description for vm.network.nic.m… …ax.secondary.ipaddresses value hardcoded by commit 4925b9f6a126454215531998c461bf376ac6ab67 You can merge this

[GitHub] cloudstack pull request: Fixed typo

2015-08-17 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/708#issuecomment-132072808 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cloudstack pull request: CLOUDSTACK-8740: add custom.css to make c...

2015-08-17 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/704 CLOUDSTACK-8740: add custom.css to make custom UI styles easier You can merge this pull request into a Git repository by running: $ git pull https://github.com/resmo/cloudstack feature

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-127280785 @wilderrodrigues ok. thx! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-08-03 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-127274573 @wilderrodrigues did you take it over? can I close this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: CLOUDSTACK-8650: Fix securitygroups ingre...

2015-07-22 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/601#discussion_r35187102 --- Diff: scripts/vm/network/security_group.py --- @@ -860,8 +860,10 @@ def add_network_rules(vm_name, vm_id, vm_ip, signature, seqno, vmMac, rules, vif

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121931572 @wilderrodrigues yes, please. Feel free. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121914103 Hi @wilderrodrigues that would be awesome! It is not supposed to break backward compatibility. In my opinion the functionality is implemented and should work

[GitHub] cloudstack pull request: [WIP] CLOUDSTACK-6276: project support in...

2015-07-15 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/508#issuecomment-121846292 hey @bhaisaab, still WIP. I ask for some help to finish it on the ML, because I will not have time to work on it the next months. --- If your project is set up for

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-24 Thread resmo
Github user resmo commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/513#discussion_r33126603 --- Diff: server/src/com/cloud/api/query/QueryManagerImpl.java --- @@ -968,7 +968,11 @@ } if (state != null

[GitHub] cloudstack pull request: CLOUDSTACK-8578: implement old behaviour ...

2015-06-23 Thread resmo
GitHub user resmo opened a pull request: https://github.com/apache/cloudstack/pull/513 CLOUDSTACK-8578: implement old behaviour for listing only non-destroy… …ed VMs using state=present Also see https://github.com/apache/cloudstack/pull/510#issuecomment-114502611

[GitHub] cloudstack pull request: CLOUDSTACK-8578: fix listVirtualMachines ...

2015-06-23 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/510#issuecomment-114502611 @bhaisaab Ok. I'll make a doc PR. We could probably think about extending the list API to a state e.g. `present` which returns all VMs in states `starting, ru

  1   2   >