Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/2010
Added Marvin test code PEP8 and PyFlakes compliance:
CloudStack$
CloudStack$ pyflakes test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pep8 test
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/2005
PEP8 & PyFlakes compliance of our marvin test code:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/2005
CLOUDSTACK-9450: Network Offering for VPC based on DB flag
Co-Authored-By: Prashanth Manthena prashanth.manth...@nuagenetworks.net
Bug: https://issues.apache.org/jira/browse
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/2004
PEP8 & PyFlakes compliance of our marvin test code:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/2004
CLOUDSTACK-9832: Restrict addition of public IP NIC to the VPC VR when the
VPC offering does not contain VpcVirtualRouter as a SourceNat provider
Detail:
When the VPC offering does
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1981
@borisstoyanov yes, I also did cross check the test failures. Thanks for
the investigation.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack-docs/pull/19
@rhtyd @karuturi Can we please merge this ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1981
@borisstoyanov I am glad you liked the PR, we (@nuagenetworks) made it a
practice to add and run integration tests that test the changes we propose/make
in a PR. Moreover, we internally
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1981
PEP8 & PyFlakes compliance of our marvin test code:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1981
Design document for this feature:
https://cwiki.apache.org/confluence/display/CLOUDSTACK/Nuage+domain+template+selection+per+VPC
---
If your project is set up for it, you can reply to
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1981
CLOUDSTACK-9806: Nuage domain template selection per VPC
Co-Authored-By: Prashanth Manthena
Co-Authored-By: Frank Maximus
You can merge this pull request into a Git repository by
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack-docs/pull/19
@rhtyd @karuturi @krissterckx Additionally, added a section on how to run
The Nuage VSP Plugin specific Marvin tests.
You can merge this PR as it is complete now
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack-docs/pull/19
@rhtyd @karuturi Please do review this cloudstack-docs PR, which includes
changes to the Nuage VSP Plugin documentation for ACS 4.10 release.
---
If your project is set up for it
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack-docs/pull/19
These changes in the documentation are in accordance with our merged
feature support (including bug fix) PRs. Here are some of our merged feature
support PRs:
https
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Thank you all for helping us in merging this PR, much appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd I have re-kicked Travis, but it still fails due to the following
exception (test environment and/or code issue) while running the test
"test_create_volume_under_d
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd Just to make sure, are we waiting for a LGTM to merge this PR ?
May be, @jburwell can comment and/or give a LGTM as he has reviewed the PR
:)
---
If your project is set
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell We have resolved all your review comments, and updated
this PR. Moreover, all our internal regressions are looking good with the
latest code in this PR.
Let me
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd We have now resolved all your review comments including adding of
the requested unit test coverage, and we have rebased this PR with the latest
master (i.e. contains PR #1801 fix
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1579#discussion_r9043
--- Diff: server/src/com/cloud/network/NetworkModelImpl.java ---
@@ -1558,6 +1558,32 @@ public boolean checkIpForService(IpAddress userIp
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell Thank you for the update, I was planning to investigate the same
test failure (test_router_dhcp_opts) as unlike other test failures it looked
like an actual reproducible issue
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
LGTM
From our internal code review and regression run results (including our
added Nuage VSP SDN plugin specific Marvin tests, refer the previous comment
for their
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Nuage VSP SDN plugin specific Marvin test code PEP8 & PyFlakes Compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudS
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell
UPDATE: We are currently re-qualifying this PR (internally, re-based with
latest master and commits squashed) as we hit the issue "systemvm: Fix
regre
Github user prashanthvarma closed the pull request at:
https://github.com/apache/cloudstack/pull/1592
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1592
Closing this PR as its shadow PR #1785 got merged into 4.9/master
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1785
@rhtyd This is a shadow of PR #1592 , rebased against 4.9 as requested.
Note: The original PR #1592 has enough LGTMs to merge this PR.
Once you merge this PR, I will
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1592
@rhtyd I had difficulties changing the base branch to 4.9 and re-basing
against 4.9 as the source branch on my fork is master (prashanthvarma:master).
Anyhow, I have opened a new
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1785
CLOUDSTACK-9416 : Enabling Static NAT on an associated Public IP to one of
the NICs (networks) of a multi-NIC VM fails due to a wrong (default) Guest VM
IP being selected in the GUI
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd @jburwell We will rebase this PR with the latest master asap, and
update you.
As mentioned in the previous comments, we wanted to merge this PR after
merging PR #1580 as
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much
appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd @jburwell Thank you for reviewing and helping us merge this PR, much
appreciated !!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd I have resolved all your comments and updated the PR. Moreover, all
the tests that are run on this PR are now fully successful (blueorangutan tests
+ added Marvin tests in this PR
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89540443
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd Here are the latest test results of the added Marvin tests that test
the changes in this PR.
1) Marvin test run:
nosetests --with-marvin --marvin-config=nuage.cfg
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd I am afraid, the newly added integration test takes well beyond 20
mins (Ran 4 tests in 6729.698s in the previous run, refer earlier comments for
more details) to run all its test
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89472040
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -0,0 +1,804 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89471555
--- Diff: tools/marvin/marvin/lib/base.py ---
@@ -3377,6 +3377,40 @@ def list(cls, apiclient, **kwargs):
cmd.listall = True
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd I have resolved and responded to your comments, and updated the PR
accordingly. Moreover, I have just kicked on our internal regression tests
(including the added Marvin tests in
Github user prashanthvarma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1580#discussion_r89308445
--- Diff:
plugins/network-elements/nuage-vsp/src/com/cloud/api/response/NuageVlanIpRangeResponse.java
---
@@ -0,0 +1,38
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
LGTM - based on our Internal regression testing and code review on the
latest code in this PR.
@rhtyd @jburwell
---
If your project is set up for it, you can reply to this
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
LGTM - based on our Internal regression testing and code review on the
latest code in this PR.
@rhtyd @jburwell
---
If your project is set up for it, you can reply to this
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@rhtyd @jburwell I have briefly investigated the above failed tests
"test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL" and
"test_oobm_enabledisable_across_clusterzone
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/756
@rhtyd Here are the screen-shots without and with this UI bug fix:
.
Jenkins and Travis are green now, you can now kick off regression
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd The previous Jenkins failure was due to missing solidfire
plugin dependency.
I have re-based this PR with latest master, and we now only have two
commits (1
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd We want to get this PR merged in after merging in PR #1580
as there are some feature interactions and dependencies. Thus, we will rebase
this PR on top of the PR #1580
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@jburwell @rhtyd We were able to successfully run the failing test
"test_01_create_template" on our kvm-centos7 environment with this PR build
after dealing with the issue
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@jburwell @rhtyd We have briefly investigated the above test failures, and
here are our findings:
1) No single test is failing across all the environments, and this PR
doesn&#
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@rhtyd @jburwell Looks like, above test failures are not related to the
code changes on this PR.
Let me know, if you want us to do anything from our side to assist you in
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@rhtyd As I mentioned in the earlier comments, this feature PR has
dependency with our other open feature PR #1578. Thus, we re-based this PR (2
commits) on top of that PR (2 commits) as
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@rhtyd @jburwell As I mentioned in the earlier comments, this feature PR
has dependency with our other open feature PR #1578. Thus, we re-based this PR
(2 commits) on top of that PR (2
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
commits.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd I have rebased this PR with latest master, and squashed
the Marvin test commits.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here.
Moreover, we can re-run the added Marvin tests and share the results after the
re-base.
Generally, we have two
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here.
Moreover, we can re-run the added Marvin tests and share the results after the
re-base.
This PR has dependency
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@jburwell @rhtyd Ok, we will rebase the PR, and let you know here.
Moreover, we can re-run the added Marvin tests and share the results after the
re-base.
This PR has dependency
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
@jburwell @rhtyd Ok, we will rebase the PR and squash our changes/commits,
and let you know here. Moreover, we can re-run the added Marvin tests and share
the results after the re-base
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1579
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plu
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plu
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyflakes test/integration/plu
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1578
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyflakes test/integration/plu
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@remibergsma As a common team practice, we just happened to agree upon with
this line length :). Agree, we should make our Marvin code truly PEP8 compliant
as you suggested, and update
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150
test/integration/plugins/nuagevsp/*.py
CloudStack$
CloudStack$ pyfl
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
@bvbharatk IMHO, above Marvin test failure is not related to the code on
this PR. Let me know, if you want us to do any actions from our side.
---
If your project is set up for it
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1592
CLOUDSTACK-9416 : (ACS master GUI) Enabling Static NAT on an associated
Public IP to one of the NICs (networks) of a multi-NIC VM fails due to a wrong
(default) Guest VM IP being selected
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
@swill Yes, this is a bug in current master, and IMHO is a candidate to be
merged into the frozen master to be released in 4.9.
Note: As of know, there have been two code reviews
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
Marvin Test Run:
CloudStack$ nosetests --with-marvin --marvin-config=nuage.cfg
/test/integration/plugins/nuagevsp
Marvin Test Results:
Test user data and password reset
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1585
PR contents:
1) Fix for this bug
2) Marvin test coverage for Nuage VSP device CRUD operations including
verifications for this bug fix.
PEP8 & PyFlakes compliance of
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1577
Added Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150
test/integration/component/test_vpc_network_internal_lbrule
Github user prashanthvarma commented on the issue:
https://github.com/apache/cloudstack/pull/1580
Our Marvin test code PEP8 & PyFlakes compliance:
CloudStack$
CloudStack$ pep8 --max-line-length=150 test/integration/plugins/nuagevsp/.py
CloudStack$
CloudStack$ pyfl
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-215041061
@milamberspace @swill @remibergsma @DaanHoogland, I am seeing a similar
issue on master: https://issues.apache.org/jira/browse/CLOUDSTACK-9370
I
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-214209793
@DaanHoogland, We haven't heard from @pedro-martins in a while. Let's hope,
he responds soon (or) someone form the community reviews our code.
-
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-26802
@DaanHoogland That's a good suggestion. We will discuss on the optimal
location in the plugin's project directory, and incorporate them in t
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211092880
@DaanHoogland you are right, that is the main motive :). Let me know, if
you want me to publish it elsewhere as well for easier user access.
Thank
Github user prashanthvarma commented on the pull request:
https://github.com/apache/cloudstack/pull/1452#issuecomment-211044426
@DaanHoogland Sure, here is an example Nuage VSP SDN plugin specific Marvin
tests config file contents:
{
"
GitHub user prashanthvarma opened a pull request:
https://github.com/apache/cloudstack/pull/1452
CLOUDSTACK-9322: Support for Internal LB fuctionality with Nuage VSP SDN
Plugin including Marvin tests
Task: https://issues.apache.org/jira/browse/CLOUDSTACK-9322
PR contents
83 matches
Mail list logo
