Github user prashanthvarma commented on the issue:

    https://github.com/apache/cloudstack/pull/1579
  
    @jburwell Thank you for the update, I was planning to investigate the same 
test failure (test_router_dhcp_opts) as unlike other test failures it looked 
like an actual reproducible issue from brief failure analysis. 
    
    Anyhow, you saved me some time :)
    
    Just a small remark, most of the failures in the regression tests are 
either test cleanup issues (e.g. failed to delete because resource is in use) 
(or) timeout issues (e.g. failed to SSH into VM). According to me, one can 
avoid such failures by refactoring/restructuring the Marvin test code in such 
smoke tests.
    
    We will rebase this PR with latest master once PR #1800 and PR #1801 have 
been merged, and update here to re-run the regression tests.
    
    @rhtyd Once we update this PR with the requested unit test coverage in the 
above review comments, are we good w.r.t your code review  ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to