Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/914
I have tested this and **LGTM** for test.
Following are the test results :
**Before applying fix :**
[root@xenserver-jay ~]# xe vbd-list vm-name-label=i-2-120-VM
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1810
I have tested this and **LGTM** for test.
Following are the results :
**Before applying fix :**
/vmfs/volumes/5d7b9eae-08336124/r-99-VM # grep virtualDev r-97-VM.vmx
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/905
I have tested this and **LGTM** for test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1850
I have tested this and LGTM for test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1725
I have tested this and **LGTM** for test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1726
I have tested this and **LGTM** for test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1987
This is Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1978
This is Ready to Merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1987
@rafaelweingartner : As per your suggestion, I have changed the search
query and also removed the unused method updateDomain from
managementserviceimpl class.
Please check
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1987#discussion_r104283067
--- Diff: server/src/org/apache/cloudstack/region/RegionManagerImpl.java ---
@@ -229,7 +232,7 @@ public boolean deleteUser(DeleteUserCmd cmd
GitHub user niteshsarda opened a pull request:
https://github.com/apache/cloudstack/pull/1987
CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in
different domains
ISSUE
Unable to edit a Sub domain, which has the same name in different
Github user niteshsarda closed the pull request at:
https://github.com/apache/cloudstack/pull/1986
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user niteshsarda opened a pull request:
https://github.com/apache/cloudstack/pull/1986
CLOUDSTACK-9814 : Unable to edit a Sub domain, which has the same name in
different domains
ISSUE
Unable to edit a Sub domain, which has the same name in different
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1978
@borisstoyanov : The test cases which are failing are not related to my
code changes.
Can you please verify ?
---
If your project is set up for it, you can reply to this email and
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1978#discussion_r103415320
--- Diff: server/test/resources/createNetworkOffering.xml ---
@@ -34,22 +34,23
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1972
@SudharmaJain Can you please check new PR for this issue. Also, I have
implemented the changes which you have suggested.
PR link :
#1978
---
If your project is set up for it
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1972
@ustcweizhou : Can you please check new PR for this issue and provide LGTM
on that PR.
PR link :
https://github.com/apache/cloudstack/pull/1978
---
If your project is set up
GitHub user niteshsarda opened a pull request:
https://github.com/apache/cloudstack/pull/1978
CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip
x.x.x.x is mapped to load balancing rule
ISSUE
Releasing secondary guest IP fails with error VM nic Ip
Github user niteshsarda closed the pull request at:
https://github.com/apache/cloudstack/pull/1972
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1972#discussion_r103190716
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDao.java ---
@@ -29,4 +30,6 @@
List
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1972#discussion_r103138362
--- Diff: engine/schema/src/com/cloud/network/dao/LoadBalancerDaoImpl.java
---
@@ -75,4 +84,40 @@ protected LoadBalancerDaoImpl
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1937
@ustcweizhou : I have created a new PR for this issue
https://github.com/apache/cloudstack/pull/1972 .
Please check. Also, I have incorporated all the comments which you have
GitHub user niteshsarda opened a pull request:
https://github.com/apache/cloudstack/pull/1972
CLOUDSTACK-9779 : Releasing secondary guest IP fails with error VM nic Ip
x.x.x.x is mapped to load balancing rule
ISSUE
Releasing secondary guest IP fails with error VM nic Ip
Github user niteshsarda closed the pull request at:
https://github.com/apache/cloudstack/pull/1937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101966427
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId
Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101502146
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1942
@SudharmaJain : As per suggestion, I have added a screenshot of the UI
before and after adding fix in description comment. Please check
---
If your project is set up for it, you can reply
Github user niteshsarda commented on the issue:
https://github.com/apache/cloudstack/pull/1909
