Github user niteshsarda commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1937#discussion_r101966427
--- Diff: server/src/com/cloud/network/NetworkServiceImpl.java ---
@@ -852,7 +852,8 @@ public boolean releaseSecondaryIpFromNic(long
ipAddressId) {
throw new InvalidParameterValueException("Can' remove the
ip " + secondaryIp + "is associate with static NAT rule public IP address id "
+ publicIpVO.getId());
}
- if (_lbService.isLbRuleMappedToVmGuestIp(secondaryIp)) {
+ List<Long> lbRuleIdList =
_firewallDao.listIdByNetworkAndPurposeAndNotRevoked(network.getId(),
Purpose.LoadBalancing);
--- End diff --
@ustcweizhou : As per your comment, do you expect Null and Empty check for
list variable "lbRuleIdList " to be moved in LoadBalancerVMMapDao.java class ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
