Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1251#issuecomment-221834704
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-217089000
@rhtyd Rebased.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-216217062
@DaanHoogland sure. Will rebase and keep the default value to false.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1255#issuecomment-212834905
@nitin-maharana Yes. Will update and rebase the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1241#issuecomment-212807918
@jayapalu rebased. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212777128
@jayapalu attached the screenshots:
https://cloud.githubusercontent.com/assets/4276209/14700575/17b9fb80-07be-11e6-84cb-b61d68816496.png";>
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-212773238
@jayapalu Rebased. Please have a look now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-212767205
@jayapalu Will do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-211873904
@GabrielBrascher These adjustments can be done, but I don't see any point
of introducing the function calls. Anyhow this code is not used anywhere else
in the
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-202844861
@DaanHoogland I am not sure of the amount of work that needs to be done for
fixing all the existing test cases. Will revisit this and update. I still
personally
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-187574951
Can someone else review this as well? Already have unit test cases in the
PR.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1418#issuecomment-187574586
@alexandrelimassantana , I am not sure of how to simulate the actual
traffic sentinel resource. I can create a request with 20148 or more, but the
actual error is
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1418
CLOUDSTACK-9261: Query to traffic sentinel requesting for usage statsâ¦
⦠is too long resulting in traffic sentinel sending HTTP 414 error
response - Fixed
Root Cause Analysis
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-175963626
@bhaisaab I am still not very confident if we can remove sending stop
command to when VM is in the the poweroff state (on host) and stopped state (in
DB). But as
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1307#issuecomment-168977391
@DaanHoogland With the current code, even if the VM is in poweroff(or power
report missing) state and stopped state in DB, and receives a stop command, it
gets this
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1307
CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed
Root Cause: In the case of VM_POWER_STATE handler, if PowerOff or
PowerReportMissing state is encountered
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1152#discussion_r48704472
--- Diff: server/src/com/cloud/user/AccountManager.java ---
@@ -198,4 +200,11 @@ void buildACLViewSearchCriteria(SearchCriteria s
public static
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-168581991
cc @DaanHoogland @jburwell Okay. Agreed with that. So I am setting the
default value to false but for running tests and maybe some other existing
integration we
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-168295517
@DaanHoogland Agreed with that point. But its not only about the testing.
I'm sure many people will be using it in their own integration. I think we
shoul
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-165426036
Have updated this PR. Instead of directly removing the secret key from
response, I have deprecated that as many regressions were using the secret key
from those
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1255#issuecomment-165342311
cc @milamberspace @karuturi Have reopened this PR against the current
master. This is in continuation with #941.
 api,
listKeysCmd
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1188#issuecomment-162839268
cc @bhaisaab @DaanHoogland I closed the previous PR. Created this one and
rebased with the master. Not sure why the tests were failing in the previous
one. Maybe
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1188
CLOUDSTACK-9086: ACS allows to create isolated networks with invalideâ¦
⦠gateway IP address - Fixed and Test cases added
Problem: There was no check for the network and broadcast IP
Github user kansal closed the pull request at:
https://github.com/apache/cloudstack/pull/1125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162490625
@DaanHoogland I see a test case in the NetUtilsTest.java class'
testIsSameIpRange() function.
assertFalse(NetUtils.isSameIpRange(cidrFirst, "1
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46809694
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1523,7 +1524,15 @@ public static boolean isIpWithtInCidrRange(final
String
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1125#issuecomment-162471051
cc @bhaisaab @DaanHoogland . Added test cases and made some minor changes
to the function. Please have a look.
---
If your project is set up for it, you can reply
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1125#discussion_r46673005
--- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java ---
@@ -1526,6 +1527,14 @@ public static boolean isIpWithtInCidrRange(final
String
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/1152#issuecomment-161944643
@jburwell Sure!! Will look into these. Adding the test cases and some UI
changes for this to work. Will update the PR.
---
If your project is set up for it, you
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1152
CLOUDSTACK-9099: SecretKey is returned from the APIs - Fixed
The current implementation of User and account management API (in general)
return the secret key as a user or account response
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/1125
CLOUDSTACK-9086: ACS allows to create isolated networks with invalid â¦
â¦gateway IP address - Fixed
Problem: There was no check for the network and broadcast IP addresses in
the
vents", "system",
> > "global-settings", "configuration", "projects", "regions",
> > "affinityGroups", "test"];*
> >
> > After building the project, the button was added to the menu, but when I
> > edit cloudStack.js and restart jetty UI doesn't change, any changes are
> > applied only after the full project rebuild with command mvn
> > -Pdeveloper,systemvm -DskipTests clean install.
> > Jetty version 6.1.26
> >
> > How to apply changes without rebuilding project?
> > And is it possible to apply it without restart Jetty?
> >
>
--
Kshitij Kansal
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-152421311
@DaanHoogland Sorry It was something to do with my IDE's settings.
Corrected and rebased.
---
If your project is set up for it, you can reply to this emai
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152411793
Hi @wilderrodrigues, To check the bug is solved, try deploying the VM in
shared network with no service.
https://cloud.githubusercontent.com/assets/4276209
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-152152422
@remibergsma @bhaisaab The above changes were made as the part of DHCP/DNS
offload feature. The related ticket is
https://issues.apache.org/jira/browse/CLOUDSTACK
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/995
CLOUDSTACk-9002: VM deployment is successful even when dhcp entry comâ¦
â¦mand fails - Fixed
Reason: The return value of the call to accept() function in the
applyRules() function of
Cool!! Thanks Rajani :)
Regards,
Kshitij
On Wed, Oct 28, 2015 at 11:51 AM, Rajani Karuturi <
rajani.karut...@citrix.com> wrote:
> Done.
>
> ~Rajani
>
>
>
> On 28-Oct-2015, at 11:41 am, Kshitij Kansal wrote:
>
> > Hi,
> >
> > Can someone please
Hi,
Can someone please give me permissions to assign bugs to myself in JIRA?
Username: kansal
Regards,
--
Kshitij Kansal
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-151500654
@ remibergsma Thank you very much. I was busy somewhere. Will update this
PR with "update script" and rebase it. Sorry for the delayed response.
-
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/941
CLOUDSTACK-8961: Changes related to the UI of VPN Users management.
The current VPN uses are added in the VPN tab inside the public IP after
the VPN is enabled. For each network(for which VPN is
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/938
CLOUDSTACK-8959: Option to attach the config drive.
Config Drive was added as a part of DNS/DHCP offload feature. The main aim
was to provide a way to send user data to VM instances in case of
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/916#issuecomment-147295409
@bhaisaab Sure will check about the back-porting of the issue. Apart from
that, the previous values stored incorrectly need to be corrected in the
database. I think
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/916
CLOUDSTACK-8940: Wrong value is inserted into nics table netmask fielâ¦
â¦d when creating a VM - Fixed
Problem: When creating a VM in shared network with no service, the value of
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/907
CLOUDSTACK-8931: Fail to deploy VM instance when use.system.public.ipâ¦
â¦s=false - FIXED
Root Cause Analysis:
In the present case, if the IP addresses are dedicated to the
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-143727275
@remibergsma Rebased against the master. Repro steps are as follows:
1) Create two VMs in new isolated networks, testnet1 and testnet2.
2) Enable VPN in
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-143644210
@remibergsma Rebased against the master. Please have a look. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/826#issuecomment-141897458
@jayapalu can you review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/858
CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRecâ¦
â¦ords does not return domain - Fixed and tests added
Problem: Only domainid is returned by usageReports API
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140984295
@remibergsma I tested it on my local setup and worked fine. Maybe you can
also check to make sure I haven't missed anything.
---
If your project is set up f
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/818#issuecomment-140339650
@remibergsma Yes its CLOUDSTACK-8844. It's already syncing the comments in
the JIRA issue.
---
If your project is set up for it, you can reply to this emai
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/826
Fixed: Error given when creating VPN user in one network if VR for anâ¦
â¦other network is stopped.
Problem: Adding a VPN user to an IP on an isolated network fails with an
exception
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/818
Fixed: Network Update from RVR offering to Standalone offering fails
Problem: Moving a RVR network offering to standalone makes the status of
VR's as UNKNOWN and Redundant Router marked wit
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-138492797
@DaanHoogland @kishankavala Have made some changes to test cases. Please
review.
---
If your project is set up for it, you can reply to this email and have your
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-136934002
@DaanHoogland Removed the duplicate tests. Please have a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-136250704
@DaanHoogland Yes the first test in a way does the same thing only. The
thing is that the second test is more intuitive in a way that it firsts
registers a key-pair
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-135747132
@DaanHoogland @kishankavala Added test case for checking the duplicate
key-pair registrations. Please review.
---
If your project is set up for it, you can reply to
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-134027948
@kishankavala @DaanHoogland Can you please review it?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-132482850
@DaanHoogland @kishankavala Have made changes regarding allowing the
duplicate keys for different accounts. DB checks are additional checks and API
level checks are
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-131699503
@kishankavala @DaanHoogland @sedukull The API level check was already in
place but was not working because the check was done on the public key passed
from user
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-130539282
@kishankavala The current implementation of the createSSHKeyPair checks
for the keypair-name in the table ssh_keypairs and if that name exists it will
return &q
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36940851
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/685#discussion_r36858306
--- Diff: setup/db/db/schema-452to460.sql ---
@@ -353,6 +353,8 @@ CREATE VIEW `cloud`.`user_vm_view` AS
`cloud`.`user_vm_details
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/685
CLOUDSTACK-8727: API call listVirtualMachines returns same keypair
Currently the user can register same key with different names. Upon listing
the VM's the name which got registered fir
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/643#issuecomment-126570824
@DaanHoogland @miguelaferreira I understand you concerns. I have created
the ticket for this in JIRA with ID: CLOUDSTACK-8692. Will keep this in mind
while for
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/643#issuecomment-126301540
@DaanHoogland It was the issue that was reported by our internal coverity.
The issue reported is:
"noescape: Resource 'in' is not clo
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/643
Coverity Issue: Resource Leak fixed
Resource leak fixed. Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kansal/cloudstack
Github user kansal closed the pull request at:
https://github.com/apache/cloudstack/pull/639
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/639
:q!Coverity 17897
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kansal/cloudstack Coverity-17897
Alternatively you can review and apply
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/629
Coverity Issue: Null pointer dereferencing fixed
This is in continuation with the PR #618.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/628
Coverity Issue: Null Pointer Dereferencing fixed and Test cases added
Discussed this issue in a separate PR. Creating a new PR for this.
You can merge this pull request into a Git repository by
Github user kansal closed the pull request at:
https://github.com/apache/cloudstack/pull/618
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125552998
Closing this pull request. Will open one for each issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35524999
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -358,7 +363,8 @@ private boolean setup
Github user kansal commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/618#discussion_r35524889
--- Diff:
plugins/user-authenticators/saml2/src/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java
---
@@ -119,12 +123,12 @@
@Override
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-125106632
@DaanHoogland Added the test file. Checking only the false cases.
@wilderrodrigues Got away with the IF statements and replaced with the api
@karuturi suggested
Github user kansal commented on the pull request:
https://github.com/apache/cloudstack/pull/618#issuecomment-124034693
@kishankavala: The message has been changed.
@karuturi: Added the path. Please check
I have also made another change with respect to solving this problem
GitHub user kansal opened a pull request:
https://github.com/apache/cloudstack/pull/618
Dereference NULL return value
No check on the null value of metadatafile. If null, the following
operations failed. Added null check for the metadatafile.
You can merge this pull request into
83 matches
Mail list logo
