[GitHub] cloudstack issue #2006: CLOUDSTACK-9833: Move configuration parameters from ...

2017-04-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2006 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 In the travis ci the tests are failing it could be because of timeout. But when I run some of the test locally it is passing. The same test test_invalid_gw_nm is failing in travis ci

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-04-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon Jenkins and CI is passed, Can you please give LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-12 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 @koushik-das I have updated for your review comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-04-11 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 Jenkins got timed out. I am force pushing again to trigger jenkins. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854129 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,38 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854097 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-11 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110854055 --- Diff: setup/db/db/schema-4920to41000.sql --- @@ -230,5 +230,11 @@ JOIN `cloud`.`vm_snapshots` s ON (s.service_offering_id = o.id AND s.vm_id = v.i

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-10 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110818988 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected

[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-07 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 It seems there is issue in CI due to that test are failing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...

2017-04-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2018 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110112007 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r11089 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -848,13 +849,37 @@ public int compare(final PublicIpAddress o1, final

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-05 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110082664 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java --- @@ -1764,9 +1765,12 @@ protected

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-04-05 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1908#discussion_r110082657 --- Diff: plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java --- @@ -625,15 +627,20 @@ protected

[GitHub] cloudstack issue #2018: CLOUDSTACK-9848: Added exit status checking for the ...

2017-04-05 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/2018 @wido In the patch it can be observed that it is ("-A FIREWALL_%s DROP" % ) running without '-j' and it is not caught. There is duplicate rule due this the

[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...

2017-04-05 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1997 @DaanHoogland In the case of VM_POWER_STATE handler, if PowerOff or PowerReportMissing state is encountered, handlePowerOffReportWithNoPendingJobsOnVM() is called. If the VM is already in

[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...

2017-04-05 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1917 There are two LGTMs and there are not test failures in the test results. So marking tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack issue #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE h...

2017-04-04 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1997 @ramkatru I am not sure about Daan comments. The tests results are positive. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1996: CLOUDSTACK-9099: SecretKey is returned from the APIs

2017-04-03 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1996 @rhtyd Once this PR got the LGTMs, I can rebase it on 4.9. Can you please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request #2018: CLOUDSTACK-9848: Added exit status checking f...

2017-03-23 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/2018 CLOUDSTACK-9848: Added exit status checking for the iptables commands Added the checking exist status of iptables command. On exception return error so that it will be populated to

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-03-16 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 @ustcweizhou I will add disable and CLOUDSTACK-9413 in new feature. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1993: CLOUDSTACK-8931: Fail to deploy VM instance when use...

2017-03-09 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1993 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1993: CLOUDSTACK-8931: Fail to deploy VM instance when use...

2017-03-09 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1993 @borisstoyanov Updated with jira ticket --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1997: CLOUDSTACK-9208: Assertion Error in VM_POWER_...

2017-03-09 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1997 CLOUDSTACK-9208: Assertion Error in VM_POWER_STATE handler- Fixed This PR closes PR #1307 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request #1996: CLOUDSTACK-9099: SecretKey is returned from t...

2017-03-09 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1996 CLOUDSTACK-9099: SecretKey is returned from the APIs This PR closes the PR #1152 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] cloudstack pull request #1993: Fail to deploy VM instance when use.system.pu...

2017-03-07 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1993 Fail to deploy VM instance when use.system.public.ips=false This PR closes PR #907 Reproducing steps: 1. Create an account 2. Dedicate public ip range to this account

[GitHub] cloudstack issue #1965: CLOUDSTACK-9727 Password reset discrepancy in RVR wh...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1965 Code changes LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1970: CLOUDSTACK-9725 Failed to update VPC Network during ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1970 Code LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 Two LGTMs and no test failures from cloudmonger test results. @ustcweizhou waited for your comments for this, I am putting the mergeready tag. If you have anything to bring up let me know

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon Can you please review it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1991 Updated the patch. Tested it no issues found. Please review this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1991#discussion_r104414236 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -1267,9 +1267,9 @@ def cache_ipset_keyword(): type = getIpsetType() tmpname

[GitHub] cloudstack issue #1991: CLOUDSTACK-9821: Fixed issue in deploying vm in basi...

2017-03-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1991 I am testing it again. Please wait till I update --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1991#discussion_r104405081 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -1267,9 +1267,9 @@ def cache_ipset_keyword(): type = getIpsetType() tmpname

[GitHub] cloudstack pull request #1991: CLOUDSTACK-9821: Fixed issue in deploying vm ...

2017-03-06 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1991 CLOUDSTACK-9821: Fixed issue in deploying vm in basic zone Fixed issue in deploying vm in basic zone. There is issue in ipset command with xenserver 6.5. In util.pread2 ipset and -N is

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-02 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon I have today this PR after rebasing latest master. I did not observe the add:true for the removed ip. Here is output from the ips.json and ip addr show output

[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...

2017-03-02 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1917#discussion_r103897727 --- Diff: engine/components-api/src/com/cloud/network/IpAddressManager.java --- @@ -43,6 +43,9 @@ "If true, when account has dedi

[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...

2017-03-02 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1866 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

2017-03-01 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1866#discussion_r103863373 --- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade4920to41000.java --- @@ -53,6 +55,7 @@ public boolean supportsRollingUpgrade

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-03-01 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon The ip issue can be worked as separate ticket/PR. It is an isolated issue, it is not having any dependency with this PR. So we will get this PR in and create a separate ticket

[GitHub] cloudstack issue #1908: CLOUDSTACK-9317: Fixed disable static nat on leaving...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1908 @ProjectMoon I have seen the issue of ips.json having the "add:true" while I am testing this PR. I tested this PR by manually removing the ip or setting add to false. Also I t

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1886 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1883 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1866: Advanced isolated network egress destination cidr su...

2017-02-28 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1866 I tested manually test_02_isolate_network_FW_PF_default_routes_egress_false Failed. It worked for me. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cloudstack issue #1824: CLOUDSTACK-9657: Fixed security group ipset issues w...

2017-02-27 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1824 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...

2017-02-26 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1886#discussion_r103136343 --- Diff: core/src/com/cloud/network/resource/TrafficSentinelResource.java --- @@ -228,6 +239,7 @@ private DirectNetworkUsageAnswer

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-24 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 Jenkins and travis are failing because of its internal failures. tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1922: CLOUDSTACK-9757: Fixed issue in traffic from additio...

2017-02-24 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1922 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-24 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 tag:mergeready --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-24 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 @ustcweizhou changes for kvm were in new file. It is missed while commiting, added now. Thanks for catching. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-23 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102888327 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long

[GitHub] cloudstack issue #1883: CLOUDSTACK-9723: Enable unique mac address across th...

2017-02-22 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1883 There are no marvin tests available for this. The unique mac address supposed for the two different deployments. --- If your project is set up for it, you can reply to this email and have

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102651320 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102651284 --- Diff: engine/schema/src/com/cloud/network/dao/NetworkDaoImpl.java --- @@ -377,11 +377,16 @@ protected void addAccountToNetwork(final long

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1883#discussion_r102649918 --- Diff: utils/src/main/java/com/cloud/utils/net/NetUtils.java --- @@ -83,9 +83,19 @@ public final static int

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-22 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd This is basic zone related changes. In the above results failures are not related to the changes. Can you please review the changes once. --- If your project is set up for it

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
GitHub user jayapalu reopened a pull request: https://github.com/apache/cloudstack/pull/1922 CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet Acquire ip from additional public subnet and configure nat on that ip. After this pick any from that network and

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/1922 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-02-22 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1922#discussion_r102432766 --- Diff: server/src/com/cloud/network/router/CommandSetupHelper.java --- @@ -703,6 +722,10 @@ public void createVpcAssociatePublicIPCommands(final

[GitHub] cloudstack issue #1873: CLOUDSTACK-9709: Updated the vm ip fetch task to use...

2017-02-21 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1873 There are not failed test cases on CI run. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...

2017-02-21 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1824#discussion_r102192868 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -232,28 +233,50 @@ def deleteFile(session, args): return txt +#using

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-20 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 @rhtyd nethash is supported in xenserver 6.2 but the problem is when configure /32 cidr giving the error ' Out of range cidr `10.147.52.30/32' specified'. Please see the bug f

[GitHub] cloudstack issue #1885: CLOUDSTACK-9724: Fixed missing additional public ip ...

2017-02-20 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1885 Failed test cases are not related to this PR code changes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cloudstack pull request #1874: CLOUDSTACK-9711: Fixed error reporting while ...

2017-02-20 Thread jayapalu
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/1874 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #1917: CLOUDSTACK-9756: Configure to ignore the ipassoc fai...

2017-02-19 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1917 Travis CI test_outofbandmanagement is failing which is not related to this PR changes. It seems there is problem with the test case. @rhtyd Do you have any idea on this ? Running

[GitHub] cloudstack issue #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 err...

2017-02-16 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1886 @rafaelweingartner Traffic sentinel supports the post request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack issue #1379: CLOUDSTACK-8324: config drive data set/get scripts f...

2017-02-15 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1379 These scripts CI tests are not needed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack issue #1379: CLOUDSTACK-8324: config drive data set/get scripts f...

2017-02-15 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1379 These scripts are for config drive feature. Deploy vm in shared network without services then vm with config drive will be deployed. Place these scripts in vm template to set VM password

[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...

2017-02-15 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1379#discussion_r101223451 --- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in --- @@ -0,0 +1,107 @@ +#!/bin/bash +# +# Init file for SSH Public Keys

[GitHub] cloudstack pull request #1379: CLOUDSTACK-8324: config drive data set/get sc...

2017-02-15 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1379#discussion_r101223426 --- Diff: setup/bindir/cloud-set-guest-sshkey-configdrive.in --- @@ -0,0 +1,107 @@ +#!/bin/bash +# +# Init file for SSH Public Keys

[GitHub] cloudstack issue #872: Strongswan vpn feature

2017-02-14 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/872 PR#1741 is closed. So closed this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #872: Strongswan vpn feature

2017-02-14 Thread jayapalu
Github user jayapalu closed the pull request at: https://github.com/apache/cloudstack/pull/872 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cloudstack issue #843: Security group ingress/egress issues with xenserver 6...

2017-02-14 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/843 Rebased against master. This PR changes are for basic zone. CI runs test cases for advanced zone. So tested manually. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-02-14 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1885#discussion_r100985099 --- Diff: server/src/com/cloud/network/IpAddressManagerImpl.java --- @@ -460,6 +460,12 @@ boolean checkIfIpAssocRequired(Network network, boolean

[GitHub] cloudstack issue #1939: CLOUDSTACK-8886: Limitations is listUsageRecords out...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1939 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack issue #858: CLOUDSTACK-8886: Limitations is listUsageRecords outp...

2017-02-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/858 created new #PR 1939 for this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cloudstack pull request #1939: CLOUDSTACK-8886: Limitations is listUsageReco...

2017-02-13 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1939 CLOUDSTACK-8886: Limitations is listUsageRecords output, listUsageRec… As @kansal is inactive created new branch and raised the PR. This is continuation of PR#858 https://github.com

[GitHub] cloudstack pull request #843: Security group ingress/egress issues with xens...

2017-02-13 Thread jayapalu
Github user jayapalu commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/843#discussion_r100766384 --- Diff: scripts/vm/hypervisor/xenserver/vmops --- @@ -356,18 +356,25 @@ def allow_egress_traffic(session): return '

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2017-02-10 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1741 @swill I have tested this PR with systemvm template with strongswan installed long back. The s2s vpn worked fine. LGTM from my side. --- If your project is set up for it, you can reply

[GitHub] cloudstack pull request #1922: CLOUDSTACK-9757: Fixed issue in traffic from ...

2017-01-31 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1922 CLOUDSTACK-9757: Fixed issue in traffic from additional public subnet Acquire ip from additional public subnet and configure nat on that ip. After this pick any from that network and

[GitHub] cloudstack pull request #1917: CLOUDSTACK-9756: Configure to ignore the ipas...

2017-01-24 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1917 CLOUDSTACK-9756: Configure to ignore the ipassoc failure On failure of ip assoc in back end (In VR), added config option to ignore or not to ignore failure. Using this failures won'

[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...

2017-01-17 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 @ProjectMoon Added the new PR https://github.com/apache/cloudstack/pull/1908 for addressing missing issues in this PR --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request #1908: CLOUDSTACK-9317: Fixed disable static nat on ...

2017-01-17 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1908 CLOUDSTACK-9317: Fixed disable static nat on leaving ips on interface FIxed issue in disabling multiple static nat simultaneously. This patch has taken changes from the PR 1450 and

[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...

2017-01-13 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 @ProjectMoon I am working on it. I will be updating the fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack issue #1450: CLOUDSTACK-9317: Enable/disable static NAT associate...

2017-01-12 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1450 I tested this patch with below steps. It is not removing the ip addresses on the VR interface. Some times observed that even there is one ip with static nat but the interface got removed

[GitHub] cloudstack pull request #1886: CLOUDSTACK-9728: Fixed traffic sentinel HTTP ...

2017-01-02 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1886 CLOUDSTACK-9728: Fixed traffic sentinel HTTP 414 error response Url generated by CCP to request traffic sentinel for usage stats is too long causing HTTP 414 Request-URI Too Long error

[GitHub] cloudstack pull request #1885: CLOUDSTACK-9724: Fixed missing additional pub...

2017-01-02 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1885 CLOUDSTACK-9724: Fixed missing additional public ip on tier network w… In VPC tier network acquire an ip and configure the PF service on it. VR now will have the two ip addresses on the

[GitHub] cloudstack pull request #1883: CLOUDSTACK-9723: Enable unique mac address ac...

2017-01-01 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1883 CLOUDSTACK-9723: Enable unique mac address across the zones Enable unique mac address across different deployments and networks. If there two networks in two different deployment zones

[GitHub] cloudstack issue #838: CLOUDSTACK-8857 listProjects doesn't return tags vmst...

2016-12-29 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/838 Code changes are fine. Test results are there LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request #1876: CLOUDSTACK-9715: Update somaxconn value to de...

2016-12-29 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1876 CLOUDSTACK-9715: Update somaxconn value to default value Updated the somaxconn value to detault value 65535 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cloudstack pull request #1874: CLOUDSTACK-9711: Fixed error reporting while ...

2016-12-28 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1874 CLOUDSTACK-9711: Fixed error reporting while adding vpn user If configuring vpn user in one of the network fails the failure is ignored, failure should be shown in API response. You can

[GitHub] cloudstack pull request #1873: CLOUDSTACK-9709: Updated the vm ip fetch task...

2016-12-27 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1873 CLOUDSTACK-9709: Updated the vm ip fetch task to use the correct the … Updated the vm ip fetch task to use the seperate thread executor Also fixed in this If a vm with iso

[GitHub] cloudstack pull request #1866: Advanced isolated network egress destination ...

2016-12-25 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1866 Advanced isolated network egress destination cidr support added Added the destination cidr support for the advanced zone isolated network egress rule. With this now user can control both

[GitHub] cloudstack issue #1782: CLOUDSTACK-9617: Fixed enabling remote access after ...

2016-12-11 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1782 Rebased on 4.9 and added changes for @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cloudstack issue #1783: CLOUDSTACK-9615: Fixd applying ingress rules without...

2016-12-11 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1783 @rhtyd It is already rebased on 4.9 and also added changes for @ustcweizhou comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack issue #1782: CLOUDSTACK-9617: Fixed enabling remote access after ...

2016-12-09 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1782 @ustcweizhou I am updating code for the LB rules as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request #1824: CLOUDSTACK-9657: Fixed security group ipset i...

2016-12-09 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/1824 CLOUDSTACK-9657: Fixed security group ipset issues with long vm name ipset set name max length allowed is 31 char. If the vm name has longer name then the trimming of set has done in this

[GitHub] cloudstack issue #1783: CLOUDSTACK-9615: Fixd applying ingress rules without...

2016-12-08 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1783 rebased it on 4.9 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cloudstack issue #1741: Updated StrongSwan VPN Implementation

2016-12-06 Thread jayapalu
Github user jayapalu commented on the issue: https://github.com/apache/cloudstack/pull/1741 @rhtyd While testing this feature public ip order change on reboot issue blocked this. My suggestion is that public ip out of order is different issue. If vpn functionalities working

  1   2   >