2017 at 11:48 PM, Lucas Berri Cristofolini <
lucascristofol...@gmail.com> wrote:
> Hey folks,
>
> It's that time of the week again, thanks to all of you who've answered our
> survey and shown interest in our project so far. We appreciate it!
>
> We've j
onsolidation feature, which
you can watch over here: https://www.youtube.com/watch?v=f7vwnlVIOmA
Your input is still key to determine the focus of development, and we are
still accepting responses on our survey: https://goo.gl/forms/vvu0665Ff
Kujn6gP2
Cheers!
On Wed, Mar 29, 2017 at 12:25 AM, Luca
ges to showcase what is
currently available through our platform:
https://www.youtube.com/watch?v=dj5DO4Dcf98
More data is always welcome, and you can take our short survey right here:
https://goo.gl/forms/vvu0665FfKujn6gP2 ;)
Cheers,
Lucas
On Mon, Mar 20, 2017 at 7:35 PM, Lucas Berri Cristofolini &
Dear CloudStack community,
I'd like to thank those of you who've answered the survey so far.
However, we need more data; the questionnaire should take no more than 3
minutes to fill out and is available here: https://goo.gl/forms/vvu0665Ff
Kujn6gP2. All of the answers are confidential (no company
blocker.
>
> I would not expect this feature to be released in a stable branch for a
> couple months (unless I missed something).
>
> That's my two cents. I could be wrong, but I'd I were you I would not
> expect this feature in the short term.
>
> On Mar 9, 2
Developer
>
> <https://goo.gl/NYZ8KK>
>
> On Thu, Mar 9, 2017 at 5:46 PM, Lucas Berri Cristofolini <
> lucascristofol...@gmail.com> wrote:
>
> > Hello Fariaz,
> >
> > As of yet, OVAs with multiple disks are not supported, however progress
> has
> >
Hello Fariaz,
As of yet, OVAs with multiple disks are not supported, however progress has
been made in the past few days towards supporting them.
I'll try and keep you posted when more progress is made.
On Thu, Mar 9, 2017 at 7:16 PM, Fariaz Diloo wrote:
> Hi all,
>
> I was wondering if ova
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r61694862
--- Diff:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
---
@@ -117,4 +154,79 @@ public void
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1523#issuecomment-215996953
@nlivens May I suggest extracting lines 2501-2514 to their own separate
method? That would also allow you to create separate test cases for each
possibility
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1496#issuecomment-211149034
@abhinandanprateek How about extracting lines 70-82 in `KVMInvestigator` to
their own method? I think it would be nice to get a test case going for that
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1491#issuecomment-211140525
@ProjectMoon May I suggest extracting lines 778-784 in `AccountManagerImpl`
to a separate method? That would allow you to write your comment in a proper
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1458#issuecomment-204588967
Shouldn't the path shown in line 55 of your config file be OS-independent?
I'd also suggest fixing the typo in the file name. At least I belie
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1454#issuecomment-20457
@abhinandanprateek Looks like jenkins found some problems with your index.
I'd suggest rebasing against the current master making all the needed merges
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-202164340
@alexandrelimassantana Ah, I see that now. Thanks for the clarification! :)
---
If your project is set up for it, you can reply to this email and have your
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1450#issuecomment-202152926
@ProjectMoon According to that comment on line 781 in `CommandSetupHelper`
the conditional that follows is there to enable sourceNAT, yet you removed the
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1451#discussion_r57535012
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -180,7 +179,7 @@ private Answer applyConfig
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1410#issuecomment-199072462
@ustcweizhou I still can't help but notice that lines 1066-1086 and
1362-1382 in the `VolumeOrchestrator` class seem to contain exactly the same
piece of
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1449#issuecomment-199059690
@kollyma I like what you did here. Besides apparently speeding up the
iptables setup, the code looks more streamlined this way.
But it seems your build
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1446#issuecomment-198804084
@eriweb @GabrielBrascher Thanks for the suggestion! I've gone ahead and
opened a ticket and updated the title of this PR.
---
If your project is set u
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1446
Removed unused code from CloudZoneStartupProcessor
Upon analyzing the CloudZoneStartupProcessor class, we noticed most of its
content consisted of either commented out or unused code. To
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1396#issuecomment-192911909
@nitin-maharana I don't see anything wrong with the code. You might want to
push this again so that Jenkins can have another go at it, and if it fails
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-192893991
This looks like a sensible fix to me. Code LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/858#issuecomment-186823236
This looks like a sensible fix. Code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1203#issuecomment-186820477
@ghxandsky Would you please go ahead and rebase this PR against the current
master? Thanks!
---
If your project is set up for it, you can reply to this email
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1366#issuecomment-183970215
@bhaisaab Did you get to see the output of the jenkins build? Was it just
another false positive? I don't see anything in the code that could cause it to
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/938#issuecomment-183965957
Ping @kansal. Could you take a look at @pedro-martins's and
@GabrielBrascher's suggestions? They seem worth it to me... Also, if you do,
please go
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-181047258
@nvazquez That is very strange. As far as I can tell there isn't a file
with that name neither on the current master nor on your branch. There is
howe
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1199#issuecomment-181041357
@pritisarap12 Could you please rebase this against the current master?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-181037780
Thanks, @ProjectMoon! Now you just need to add the license header (I
believe that's what caused jenkins to fail).
---
If your project is set up for it
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/907#issuecomment-177578048
@kansal It seems your PR failed because of a Travis issue. If you're still
interested in working on this, I'd suggest you rebase against the curre
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1378#issuecomment-177565744
@ProjectMoon Even if you've managed to test this in an actual environment,
I think a small unit test just to assert that the correct values for the class
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1254#issuecomment-174217394
@agneya2001 Could you please extract the code at lines 126-135 to a
separate method? It would make that bit of code much easier to read. :)
---
If your
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1350#issuecomment-174211441
I see you've put a bunch of different test cases into a single
`testLockableAccount` method. I'd strongly suggest you put each of those
different
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-173364669
Thanks again, @nvazquez. The unit test you wrote is a nice improvement and
I'm fine with it. :)
Code LGTM.
---
If your project is set up for it, yo
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1336#issuecomment-172333464
Fix looks simple enough. Code LGTM. Although I would usually suggest adding
a javadoc the new `MigrateWithStorageCommand` method you've created, this
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-172240147
@DaanHoogland @syed I've opened a pull request containing some simple
javadocs to @syed's swift-restart-fix branch.
---
If your project is set up f
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1287#issuecomment-172234191
@rafaelweingartner @DaanHoogland,
Personally, I don't see a problem using final declarations for those
attributes. They all do seem to contain inform
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1331#issuecomment-172214758
@DaanHoogland That's a really interesting feature which I wasn't aware of.
I'm afraid I'll be out of commission for most of today but I&#
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1331#discussion_r49888184
--- Diff:
services/secondary-storage/server/src/org/apache/cloudstack/storage/resource/NfsSecondaryStorageResource.java
---
@@ -942,6 +931,83
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1310#issuecomment-171798749
Thanks for taking the time to add the descriptions and refactoring,
@nvazquez. It has helped readability quite a bit. :)
Now, in case you&#x
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1324#issuecomment-170381531
I've had tests involving sleep calls fail on me seemingly arbitrarily, to
the point where simply re-running them would give me a passing result. I
Github user cristofolini commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1310#discussion_r49279282
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -1895,6 +1896,9 @@ protected StartAnswer
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/1262#issuecomment-166138005
@rafaelweingartner Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1262
Removed unnecessary code from getGuestOsType in CitrixResourceBase
Considering that all mapping of Guest OS Names to their respective
hypervisor compatible types is made thorugh accessing
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/942#issuecomment-158935886
I've pushed another commit to bring this PR up to date with the latest
snapshot but it seems the Travis build had some issues sorting out some
depende
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/1102
Removed unnecessary @Local annotations and their respective imports
Following @rafaelweingartner 's findings in PR #714 that many spring beans
contained an @Local annotation,
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/942
Removed unused code from the EngineHostDao Implementation
After analysing the code within the EngineHostDaoImpl class, we noticed
that methods:
countBy;
findByGuid
Github user cristofolini commented on the pull request:
https://github.com/apache/cloudstack/pull/853#issuecomment-141811824
@rafaelweingartner Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/853
Removed unnecessary @Local annotations and their respective imports
Following @rafaelweingartner 's findings in PR #714 that many spring beans
contained an @Local annotation, we'
GitHub user cristofolini opened a pull request:
https://github.com/apache/cloudstack/pull/700
Removed duplicate code in CitrixResourceBase and its subclasses
Removed unnecessary duplicated code by having the body of the getPatchFiles
method only in the CitrixResourceBase superclass
50 matches
Mail list logo
