Github user cristofolini commented on the pull request: https://github.com/apache/cloudstack/pull/1523#issuecomment-215996953 @nlivens May I suggest extracting lines 2501-2514 to their own separate method? That would also allow you to create separate test cases for each possibility in that if statement.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---