Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-216487485
@swill I think you mentioned the wrong Boris :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1400
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1391#issuecomment-179292599
New PR with additional fixes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1391
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1391
Restore iptables at once using iptables-restore instead of calling iptables
numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178503500
@DaanHoogland Two errors, one in S2S and one in prv gw. Will reopen in a few
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1389
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1383#issuecomment-178064659
LGTM :+1: Based on codereview
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1384#issuecomment-178064538
LGTM :+1: Based on screenshots and code-review
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1386#issuecomment-178064345
LGTM :+1:
Already running in PROD at SBP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1389#issuecomment-178000474
Integration test results:
```
Test router internal advanced zone ... === TestName:
test_02_router_internal_adv | Status : SUCCESS ===
ok
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1389
Restore iptables at once using iptables-restore instead of calling ip
tables numerous times
You can merge this pull request into a Git repository by running:
$ git pull https
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1364#issuecomment-174861340
LGTM :+1:
Already running in production at SBP!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1358#issuecomment-174492298
LGTM :+1:
Based on integration tests and code-review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1362#issuecomment-174225635
Finally! :-)
LGTM :+1: Based on code-review and screenshots!
---
If your project is set up for it, you can reply to this email and have your
reply
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1356#issuecomment-173872641
@DaanHoogland It improves performance due to fact firewall rules are only
created (in memory) once we expect a change. If for example a dhcp lease needs
to be
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1356
More VR performance!
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/borisroman/cloudstack 4.7-vr-performance-wip
Alternatively you
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50335474
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -190,4 +196,28 @@ Use
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50325672
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -48,6 +49,9
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r50325617
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -1,4 +1,5
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1334#issuecomment-173364778
LGTM :+1:
Based on code review and screenshot from remi
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1238
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1232
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1238#issuecomment-173186580
Closing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1232#issuecomment-173186549
Closing!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/720#issuecomment-173186487
Been open for 3 months, closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/720
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-173185763
No reviews, so closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1236
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1236#issuecomment-173185634
Closing because of preference to logback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-173185402
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1224
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1225
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-173185348
Conflicts, won't resolve them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/886#issuecomment-173185222
When the network stack get's refactored this won't be necessary anymore.
---
If your project is set up for it, you can reply to this email and have
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/886
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/832#issuecomment-173184982
Most of them have already been resolved.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/832
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1340#issuecomment-173184740
LGTM :+1:
Reviewed code, and according to the screenshots it works.
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1346#discussion_r50241366
--- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
@@ -901,79 +901,123 @@ def processStaticNatRule(self, rule
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1294#issuecomment-172505055
LGTM :+1:
Did code review and ran the PR in beta
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1346
Enhance VR performance
Will post integration test results soon!
Ping @wilderrodrigues @remibergsma
You can merge this pull request into a Git repository by running
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1293#issuecomment-172248684
LGTM :+1:
Been running in beta for a couple of weeks now, no problems!
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman closed the pull request at:
https://github.com/apache/cloudstack/pull/1318
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1329#issuecomment-172247093
LGTM :+1:
delaycompress isn't usefull. The VR has limited space, so delaying the
compression of the logfiles won't help!
---
If your proj
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1341#issuecomment-171681534
@wido @kevindierkx Why not use TEXT? Then we'll never have to worry again
:-)
---
If your project is set up for it, you can reply to this email and have
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1328
NicProfileHelperImpl NullpointerException when ipVO is null
When a VPC has a private gateway, and one would like to restart the VPC
with **cleanup** it would fail.
This PR adds a
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1327#issuecomment-170505131
It's sorted! LGTM
 {
cloudStack.plugins
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1267#issuecomment-166411739
LGTM :+1:
```
[INFO]
[INFO] BUILD SUCCESS
[INFO
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164475560
@SudharmaJain Could you please open a new PR so it can be merged with
reviews.
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-164464276
@dmytro-shevchenko Thank you, I'll give them a test run!
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1242#discussion_r47495397
--- Diff:
plugins/hypervisors/kvm/test/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtUtilitiesHelperTest.java
---
@@ -37,8 +38,8 @@ public void
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1243#issuecomment-164425397
@DaanHoogland Could you please explain why you merged this?
We have a policy stating **2 (TWO)** persons will have to review a PR. One
code review and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1239#issuecomment-164291121
The changelog file will need to be handled more carefully.
LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1238
CLOUDSTACK-9160: Remove unused folder(s)/file(s); engine/api/src/org/â¦
â¦apache/engine/subsystem/api/storage/disktype
Empty files. Moved DiskFormat.java to
engine/api/src/org
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-164289083
@remibergsma @DaanHoogland Back to the point, who could we ping for a
HyperV review?
---
If your project is set up for it, you can reply to this email and have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-164285932
@DaanHoogland The integration tests show nothing broke on the KVM part, the
code of course does need to be reviewed. But that doesn't mean the tests are
us
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1237#issuecomment-164285184
Integration tests ran fine!
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1237
Remove unused folder(s)/file(s); HypervDummyResourceBase.java
Dead code, never called and consist only of auto-generated methods.
As a developer I want
- a clean project to
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1209#issuecomment-164279515
LGTM :+1:
Based on code-review and @remibergsma tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164272079
@bhaisaab Yes!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164271512
@bhaisaab I've already build the RPM's! We use them when running
integration tests, so nothing broke in that area.
I'll build the D
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164271411
Hi @bhaisaab,
True, that you see 2 commits! Due to the fact that this PR depends heavily
on #1224. The commit id of the first commit is the same as the
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1236
CLOUDSTACK-9158: Removed SLF4J, it's abundant due to log4j
In the entire project we use log4j, so why also use slf4j? I've removed
slf4j and all references to it from th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164261409
@DaanHoogland It's already in .gitignore, I think these we're never
removed...
---
If your project is set up for it, you can reply to this email and
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164255977
@DaanHoogland That's an LGTM :+1: right? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1235#issuecomment-164255956
Based on explanation and code review: LGTM :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164205140
Hi @DaanHoogland
In late 2012 it was replaced with cloudmonkey. It's just some code that was
left behind. It's not touched since halfway th
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1232#issuecomment-164201023
Integration tests ran ok! @wido @remibergsma @wilderrodrigues
@miguelaferreira @DaanHoogland
**Environment**
- 2 KVM host on CentOS 7.1
- 1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1231#issuecomment-164200657
LGTM :+1:
**Environment**
- 2 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164199618
@ustcweizhou Thanks! Will see them when they arrive!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1233#issuecomment-164196319
LGTM :+1:
Nice way of not creating duplicate code!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1186#issuecomment-164191465
LGTM :+1: All pom.xml files haven been correctly changed!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1212#issuecomment-164189121
Hi @DaanHoogland, well then that's your opinion. Mine is, as a developer I
do not want dead code to be added to the project.
Therefore I stand by m
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1209#discussion_r47435854
--- Diff: engine/schema/src/com/cloud/vm/dao/NicDaoImpl.java ---
@@ -222,11 +222,20 @@ public String getIpAddress(long networkId, long
instanceId
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1219#issuecomment-164179455
LGTM :+1:
Deployed with Ceph.
 is removed, :-1:
---
If your project is set up for it, you can reply to this
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1212#discussion_r47435698
--- Diff: server/test/com/cloud/user/AccountManagerImplTest.java ---
@@ -185,6 +186,8 @@
@Mock
GlobalLoadBalancerRuleDao
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1207#issuecomment-164178065
@priyankparihar Could you point me where in VolumeStateListener it is
emitted?
---
If your project is set up for it, you can reply to this email and have your
Github user borisroman commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/859#discussion_r47435639
--- Diff: engine/schema/src/com/cloud/usage/UsageVO.java ---
@@ -125,6 +125,25 @@ public UsageVO(Long zoneId, Long accountId, Long
domainId, String
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1217#issuecomment-164177113
@milamberspace @remibergsma @DaanHoogland LGTM :+1:
Only did code review.
---
If your project is set up for it, you can reply to this email and have
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164175379
@remibergsma Please try again! I changed a few files today. You probably
didn't notice because I squashed them in the commit from yesterday. (Which you
l
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1232
CLOUDSTACK-9152: Remove unused folder(s)/file(s); utils/bindir
As a developer I want a project without dead or unused code.
Builds ok
```
[INFO
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169626
@bhaisaab I think an incremental approach is better. I will also create
issue for all other projects and move the each at a time. The
plugin-hypervisor-kvm just
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164169497
@miguelaferreira I also think incremental is better. Keeps changed
contained and documented. Else it would be a PR that changes "OVER "
files..
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1225#issuecomment-164163506
It works! Though please tests yourself for more confidence!
@wilderrodrigues @miguelaferreira @remibergsma
**Environment**
- 1 KVM host on CentOS
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1224#issuecomment-164163315
It works! Though please tests yourself for more confidence!
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1226#issuecomment-164162389
**Environment**
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
**Integration test
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1228#issuecomment-164162326
*Environment*
- 1 KVM host on CentOS 7.1
- 1 Management Server on CentOS 7.1
- Agent + Common RPMs built from source
*Integration test
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/1230#issuecomment-164161973
Hi @dmytro-shevchenko
Thanks for implementing the removal code. Could you squash the commits and
add a descriptive commit message?
---
If your project
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1229
CLOUDSTACK-9150: Remove docs/.tx/config
The config file docs/.tx/config has been replaced with
tools/transifex/.tx/config. It's not maintained or used so it must be removed.
You can
GitHub user borisroman opened a pull request:
https://github.com/apache/cloudstack/pull/1228
Removed cloud-cli folder and contents, as it is not maintained or used
anymore.
Remove legacy code.
You can merge this pull request into a Git repository by running:
$ git pull https
1 - 100 of 355 matches
Mail list logo
