Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213521104
@swill please include this PR in your list, thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213520037
Thanks @swill @kiwiflyer
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60772858
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,138 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60772677
--- Diff: utils/src/main/java/com/cloud/utils/PropertiesUtil.java ---
@@ -34,6 +34,10 @@
public class PropertiesUtil {
private static
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60772392
--- Diff: server/src/com/cloud/api/dispatch/ParamProcessWorker.java ---
@@ -92,6 +94,55 @@ public void handle(final DispatchTask task
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60771928
--- Diff: scripts/util/migrate-dynamicroles.py ---
@@ -0,0 +1,134 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+# Licensed to the Apache
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60771659
--- Diff: scripts/util/migrate-dynamicroles.py ---
@@ -0,0 +1,134 @@
+#!/usr/bin/python
+# -*- coding: utf-8 -*-
+# Licensed to the Apache
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60771393
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapImportUsersCmd.java
---
@@ -131,7 +135,9 @@ private void
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60771374
--- Diff:
plugins/user-authenticators/ldap/src/org/apache/cloudstack/api/command/LdapCreateAccountCmd.java
---
@@ -119,6 +131,9 @@ private Long
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1510#issuecomment-213398409
With this change we would be able to use JDK8 for building cloudstack once
we fix the build issues of F5 plugin (that's the only component that fails to
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1511
4.9 bountycastle daan
This PR adds bountycastle related version and code fixes from @DaanHoogland
on top of https://github.com/apache/cloudstack/pull/1510
I could not fix java
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1397
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-213397292
@swill closing this PR, opened two new PRs that split changes from this PR
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1510
4.9 mvn version safeupgradeonly
Upgrades maven dependencies versions that can be safely upgraded without
breaking console-proxy/crypto usage.
Bisected changes from: https
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213395335
@DaanHoogland thanks, @borisstoyanov will share QA results next week as well
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60727764
--- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java ---
@@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-213375165
Pinging for review @jburwell @swill @wido @pyr @koushik-das @agneya2001
@DaanHoogland @rafaelweingartner @GabrielBrascher @kishankavala
---
If your project is
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60716885
--- Diff: client/tomcatconf/commands.properties.in ---
@@ -799,3 +799,14 @@ quotaCredits=1
quotaEmailTemplateList=1
quotaEmailTemplateUpdate=1
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1502#discussion_r60716681
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/outofbandmanagement/ChangeOutOfBandManagementPasswordCmd.java
---
@@ -0,0 +1,116
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1054#issuecomment-213331800
@wido we'll need to fix codebase wide mysqldb usage in python scripts and
build both rpms/deb to show installation, setting up of db and setting up mgmt
s
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-213329597
@GabrielBrascher @swill @jburwell @rafaelweingartner please share your LGTM
or comment what needs fixing, thanks.
---
If your project is set up for it, you can
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-213328879
@jburwell @swill @DaanHoogland @pdube @koushik-das @pdube please share your
LGTM if you're satisfied with the changes, or please comment what else needs
f
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-213327217
@jburwell @GabrielBrascher @rafaelweingartner @swill if you're done with
review, LGTM please or share what else should be fixed. Thanks.
---
If your proje
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60585031
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1302#discussion_r60565861
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -2030,12 +2030,29 @@ int getReservedCpuMHZ
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1302#issuecomment-212873785
@priyankparihar we'll need a unit test that shows that this change is
backward compatible. I like that we're considering both default instance name
with
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-212852849
@jburwell I've fixed outstanding issues, including a framework level API
arg validation (and removed such validations across cmd implementations)
@koushi
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1507
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1507
fake don't merge
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack
fake-marvin-faliing-master
Alternatively yo
Github user bhaisaab closed the pull request at:
https://github.com/apache/cloudstack/pull/1506
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1501#issuecomment-212797997
LGTM, cc @swill
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1506
fake don't merge
Travis is failing marvin tests repeatedly, this is a fake test to verify if
that's happening due to one of my PRs of due to recent PR merged on master.
You can
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60440106
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60439905
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60439732
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,170 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60439393
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/880#issuecomment-212474909
Thanks @SudharmaJain LGTM (just code review), can you do a push -f (travis
job failed for some reason)
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/956#issuecomment-212474106
@SudharmaJain The provided version have already released so these change
need to go into 481to490 related sql /cc @swill
any vmware/guest-os-mapping guru
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/883#issuecomment-212471834
@SudharmaJain Will @swill is the RM for master/4.9, I'm not following these
changes perhaps any Xen guru can comment, @agneya2001 ?
@remibergsma do you hav
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60390739
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60388741
--- Diff: api/src/org/apache/cloudstack/acl/Rule.java ---
@@ -0,0 +1,65 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60386634
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60384791
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1502#issuecomment-212340052
UI Screenshots;
:
Marvin Init Successful
=== TestName
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60369930
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60369577
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60369373
--- Diff:
plugins/acl/dynamic-role-based/src/org/apache/cloudstack/acl/DynamicRoleBasedAPIAccessChecker.java
---
@@ -0,0 +1,166 @@
+// Licensed to
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60368615
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack/pull/1502
[WIP] Don't start review yet -- CLOUDSTACK-9299: Out-of-band Management for
CloudStack
Support access to a hostâs out-of-band management interface (e.g. IPMI,
iLO,
DRAC, etc
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r60357906
--- Diff: engine/schema/src/org/apache/cloudstack/acl/RolePermissionVO.java
---
@@ -0,0 +1,109 @@
+// Licensed to the Apache Software Foundation
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-212284556
@jburwell fixed use of test timeout within \@Test annotation
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-212065979
@borisstoyanov would like to share our QA results, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-212065155
@swill just completed local build here: (also pushed -f, let's see if
Travis reports any failure)
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-212063724
@swill no problem, I'll deal with this during weekends and see how much we
can safely get into master.
---
If your project is set up for it, you can rep
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-212063057
@swill I looked at it, looks like an environment issue? I was able to build
it without issue (also did not find 'root_admin' key in the code. I've
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-212062046
@syed looks like marvin plugin is missing; if you've both python 2.6/2.7
(looks like nose is using python 2.6) make sure to install it for the one you
use
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212060526
@swill I've explained my intent above, and it was not intended to be hard
on @rafaelweingartner either
While he's indeed putting good effort on PRs,
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60284224
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-212034630
@swill we may ignore them, those are non-issues unless @rafaelweingartner
has strong opinions
@rafaelweingartner things you can do to improve your reviews
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1420#discussion_r60272259
--- Diff: packaging/centos7/cloud-management.service ---
@@ -24,6 +24,7 @@ Description=CloudStack Management Server
After=syslog.target
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-211923768
@swill okay I'll check this out and see if I can reproduce the failure.
I'll keep you posted.
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211786322
@swill thanks Will, I'll try to split this PR into two to isolate what
changes are causing this in your env and see if we can get it fixed/improved
separ
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211785845
@swill we're good with this PR and it is not dependent on any other PR. For
building noredist rpms/deb, one can use this repo with the dep-jars --
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60188424
--- Diff: pom.xml ---
@@ -92,7 +92,7 @@
2.5
1.2
1.0-20081010.060147
-5.5
+6.0
--- End diff
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211785290
@swill thanks, the change builds into systemvm.iso and no new template is
necessary.
---
If your project is set up for it, you can reply to this email and have
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211524917
@swill we can ask around on ML, afaik in addition to strongswan I known of
the ospf stuff by @abhinandanprateek which needs zebra and related packages for
ospf
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1423#issuecomment-211481666
@swill we'll need to publish a new systemvm template (i.e. we can no longer
use the 4.6 systemvm template)
---
If your project is set up for it, you can rep
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60096454
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211479011
@rafaelweingartner both your comments are opinionated and not technical;
we've to agree to disagree here ask you to be practical and pragmatic here.
I&#x
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60095074
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/37#issuecomment-211475206
Thanks @pdion891 sure after the freeze date, we can add to the release
notes list of new APIs, list of new features along with any major changes etc
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-211320093
Doc PR - https://github.com/apache/cloudstack-docs-admin/pull/37
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user bhaisaab opened a pull request:
https://github.com/apache/cloudstack-docs-admin/pull/37
CLOUDSTACK-8562: add information on dynamic roles
Adds documentation on dynamic roles feature
/cc @swill @pdion891
You can merge this pull request into a Git repository by
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack-docs-admin/pull/35#issuecomment-211291830
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211264892
@swill can we get this merged, while ShapeBlue has tested this internally
if you test with your non-vmware CI that should confirm it does not break
anything else
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1397#issuecomment-211263699
@swill advise how to proceed on this one? are you still getting the build
issues
@DaanHoogland ping
---
If your project is set up for it, you can reply to
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1420#issuecomment-211263537
@swill yes though we should run CI, the fix is simple and ensure that umask
setting is used when creating new files. the umask 022 is default on most
distros
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-211262271
@swill I've fixed the outstanding issues, can you run your CI on this and
help merge? thanks
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-211261793
@swill I've fixed the outstanding issues, can you run your CI on this and
help merge? thanks
---
If your project is set up for it, you can reply to this
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1493#issuecomment-210576373
Thanks all for the review, I've update the commits; please re-review and
advise other outstanding issue. Thanks again.
---
If your project is set up for it
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59917981
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915385
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915248
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59915144
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59914101
--- Diff: utils/src/main/java/com/cloud/utils/nio/Link.java ---
@@ -453,115 +449,192 @@ public static SSLContext initSSLContext(boolean
isClient
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913436
--- Diff:
utils/src/test/java/com/cloud/utils/backoff/impl/ConstantTimeBackoffTest.java
---
@@ -94,7 +94,7 @@ public void wakeupNotExisting
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1493#discussion_r59913672
--- Diff: utils/src/test/java/com/cloud/utils/testcase/NioTest.java ---
@@ -19,146 +19,198 @@
package com.cloud.utils.testcase
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1489#issuecomment-210423416
Thanks all, I've fixed most issues. Please see any outstanding issue and
let me know if you find any other issue.
---
If your project is set up for it, yo
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59858602
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59858459
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59858432
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59858001
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59857962
--- Diff: engine/schema/src/com/cloud/upgrade/dao/Upgrade481to490.java ---
@@ -53,6 +62,139 @@ public boolean supportsRollingUpgrade
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59857842
--- Diff: api/test/org/apache/cloudstack/acl/RuleTest.java ---
@@ -0,0 +1,39 @@
+package org.apache.cloudstack.acl;
+
+import
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59857696
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59856830
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59856707
--- Diff: api/test/org/apache/cloudstack/acl/RoleTypeTest.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59856583
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/config/UpdateCfgCmd.java ---
@@ -117,6 +123,12 @@ public long getEntityOwnerId
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1489#discussion_r59856523
--- Diff:
api/src/org/apache/cloudstack/api/command/admin/acl/ListRolePermissionsCmd.java
---
@@ -0,0 +1,104 @@
+// Licensed to the Apache
1 - 100 of 1399 matches
Mail list logo
