Re: StratosphereSsp

2014-01-30 Thread Hiroaki KAWAI
Hi, The response name is obtained from the annotation, because I really did not want to put typo in String itself. Note s_name is usually private, and getCommandName() responds. list* command is not there because simply we did not need it. It might be better to have list* command, but it will tak

Re: 4.3 commit cherry pick

2014-01-30 Thread Hiroaki KAWAI
Hi, I found that our plugin was broken, so please cherry pick db3dc2ee17c699f1abf42ea2fbe09ec2748caa4a in 4.3-forward. (2014/01/30 18:06), Jayapal Reddy Uradi wrote: > Hi Animesh, > > Can you please cherry pick commit to 7255e50f2051aff1cb5e1991e2dde4ef48f57454 > 4.3 branch > from 4.3-forward

Re: [DISCUSS] vlan uri format change

2013-07-01 Thread Hiroaki KAWAI
Daan, I'm curious about what is the improvement of changing the vlan String format in URI? I'm -1 on pushing more complexity in URI, because that's abuse of URI class and sounds it's time to get rid of URI. (2013/07/01 16:47), Daan Hoogland wrote: H, I've been trying to get a patch accepted a

Re: Master – RAT test failed

2013-06-25 Thread Hiroaki KAWAI
Thanks for pointing out. I fixed one python script header in 4b3c0128b40dd3bf8b5d664d999dfefcf3bfc284 I run following command, and got "BUILD SUCCESS" mvn --projects=org.apache.cloudstack:cloudstack org.apache.rat:apache-rat-plugin:0.8:check (2013/06/26 2:28), Rayees Namathponnan wrote: RAT

Re: Review Request 11540: CLOUDSTACK-2756: Stratosphere SSP plugin

2013-06-25 Thread Hiroaki KAWAI
(2013/06/25 23:19), Prasanna Santhanam wrote: -snip- The management server startup fails with a Spring injection [1] failure for SSPCredentialDao. Additionally, are the client libraries for the ssp controller oss / non-oss? [1]CLOUDSTACK-3194 Of cource, the codes are oss (ASL2.0 as in each

Re: ACS 4.1.1 release - bugfixes to backport

2013-06-24 Thread Hiroaki KAWAI
I've pushed a patch for CLOUDSTACK-1194 in 4.1 and master. (2013/06/06 3:22), Musayev, Ilya wrote: Hi All, Sorry I was a bit disconnected from the community - as my $dayjob kept me very busy. I would like to start of this thread to keep track of bugfixes we need to back port from 4.1 to 4.1.

Re: ACS 4.1.1 release - bugfixes to backport

2013-06-24 Thread Hiroaki KAWAI
-3015 (https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;a=commit;h=11cfc0 34e0b45cf032c1e9dcfe32021fb73789d5). Why do we need to change existing Upgrade40to41 file? Thanks -min On 6/20/13 6:31 PM, "Hiroaki KAWAI" wrote: I found there is an issue about versioning. When we cut 4.

Re: Review Request 11540: CLOUDSTACK-2756: Stratosphere SSP plugin

2013-06-24 Thread Hiroaki Kawai
for CCC. > > Thank you very much for comments. I fixed most of the issues you pointed out, and pushed into master. - Hiroaki --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.o

Re: [DISCUSS] getting rid of KVM patchdisk

2013-06-23 Thread Hiroaki KAWAI
e is a new system vm for master/4.2, but if you were unaware of it, do you think more needs to be done to call it out and make it known to the devs working on it? On Jun 23, 2013 8:33 PM, "Hiroaki KAWAI" wrote: Current patch/systemvm/debian is based on debian squeeze, which kernel is

Re: [DISCUSS] getting rid of KVM patchdisk

2013-06-23 Thread Hiroaki KAWAI
Current patch/systemvm/debian is based on debian squeeze, which kernel is 2.6.32-5-686-bigmem. In that system vm, cloud-early-config silently fails : /etc/init.d/cloud-early-config: line 109: /dev/vport0p1: No such file or directory So I've upgraded to wheezy (which includes virtio-console.ko) #

Re: ACS 4.1.1 release - bugfixes to backport

2013-06-20 Thread Hiroaki KAWAI
I found there is an issue about versioning. When we cut 4.1.1 release, we have to patch like this: --- diff --git a/server/src/com/cloud/upgrade/dao/Upgrade40to41.java b/server/src/com/cloud/upgrade/dao/Upgrade40to41.java index 9e386b9..89f54bc 100644 --- a/server/src/com/clo

Re: committer wanted for review

2013-06-15 Thread Hiroaki KAWAI
ow the auto-fix should ever be needed if the source is fixed. Hope you can live with this. - and if auto-fix happens, it should log it with WARN level. Applied regards, On Fri, Jun 14, 2013 at 10:35 AM, Daan Hoogland < daan.hoogl...@gmail.com wrote: Thanks Hiroaki, On Fri, Jun 14

Re: committer wanted for review

2013-06-13 Thread Hiroaki KAWAI
I'd suggest: - fix the generation of double slash itself - auto-fix may happen where it is really required - and if auto-fix happens, it should log it with WARN level. (2013/06/13 21:15), Daan Hoogland wrote: H, Can someone look at Review Request #11861 fo

Re: Hello (Upgrade to 4.1)

2013-06-06 Thread Hiroaki KAWAI
Hi, (2013/06/07 11:40), Maurice Lawler wrote: Greetings, I am utilizing KVM / CentOS 6.3. / CS 4.0.2 Upon issuing yum update, I am getting a slue of updates for the OS it's self. Previously I was informed that CentOS 6.4 was NOT supported, so I have backed off on updated my OS due to this fact.

Re: ACS 4.1.1 release - bugfixes to backport

2013-06-06 Thread Hiroaki KAWAI
CLOUDSTACK-2758, I already pushed a patch into 4.1 branch. :-) (2013/06/06 3:22), Musayev, Ilya wrote: Hi All, Sorry I was a bit disconnected from the community - as my $dayjob kept me very busy. I would like to start of this thread to keep track of bugfixes we need to back port from 4.1 to

Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)

2013-06-06 Thread Hiroaki KAWAI
(2013/06/06 14:24), Prasanna Santhanam wrote: On Thu, Jun 06, 2013 at 08:01:10AM +0900, Hiroaki KAWAI wrote: It took time to investigate what's happening on Ubuntu. Thanks for taking the time to investigate! On Ubuntu, we don't have apparent problem with current setup. We don

Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)

2013-06-05 Thread Hiroaki KAWAI
ur catalina.out, but there's no need to fix it in haste. (2013/06/05 15:38), Hiroaki KAWAI wrote: Hum... interesting. In Ubuntu tomcat6, the catalina.out is handled in init script. 1. Download tomcat6_6.0.35-6.debian.tar.gz from http://packages.ubuntu.com/raring/tomcat6 2. untar it and

Re: PhysicalNetworkServiceProviderDaoImpl.java / findByServiceProvider

2013-06-05 Thread Hiroaki KAWAI
And I'm +1 for fix (remove confusing naming) (2013/06/05 14:13), Chiradeep Vittal wrote: The typo is there because the same typo exists when creating the search builder in the constructor. In the constructor, the string "serviceProvderType" is associated with the VO field 'providerName'. If you

Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)

2013-06-04 Thread Hiroaki KAWAI
LINA_BASE"/logs/catalina.out chown $TOMCAT6_USER "$CATALINA_PID" "$CATALINA_BASE"/logs/catalina.out : I'd like to put a patch in reviewboard soon. (2013/06/04 14:49), Prasanna Santhanam wrote: On Tue, Jun 04, 2013 at 11:26:01AM +0900, Hiroaki

Review Request: CLOUDSTACK-2758: touch file for tomcat6 package change CVS 2013-1976

2013-06-03 Thread Hiroaki Kawai
--- I've tested on fresh centos 6.4 installation * install centos 6.4 * yum upgrade -y * yum install mysql-server * cloudstack-setup-database * cloudstack-setup-management The management server started up and I could open the webUI. Thanks, Hiroaki Kawai

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-06-03 Thread Hiroaki KAWAI
edit and adapt where needed :D -----Original Message- From: Hiroaki KAWAI [mailto:ka...@stratosphere.co.jp] Sent: Thursday, May 30, 2013 9:37 AM To: Sheng Yang Cc: Hugo Trippaers; cloudstack Subject: Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware (2013/05/30 15:56), Sheng Ya

Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)

2013-06-03 Thread Hiroaki KAWAI
HI, I looked into tomcat6.spec file, the catalina.out stuff seems to be handled in rpm installation process. %install : /bin/touch ${RPM_BUILD_ROOT}%{logdir}/catalina.out : %files : %attr(0644,tomcat,tomcat) %{logdir}/catalina.out : So I'd like

Re: [VOTE] Pushback 4.2.0 Feature Freeze

2013-06-03 Thread Hiroaki KAWAI
+1 because "4.2 will be delayed because 4.1 have been delayed" makes sense to me. Basically, time based release focuses on time only, not quality or feature. That's the nature of time based release, IMHO. I'm not voting +1 for new feature, and at the same time, I feel unfair to vote -1 for blocki

Re: [VOTE][RESULTS] Release Apache CloudStack 4.1.0 (fifth round)

2013-06-03 Thread Hiroaki KAWAI
I don't want to see NORMAL users getting failed with running cloudstack and sending email for asking the workaround. # Even if you're thinking we're not wrong. If you're going to release a5214bee99f6c5582d755c9499f7d99fd7b5b701 as 4.1.0, I'd like to suggest releasing 4.1.1 asap. # I know the vot

Re: Review Request: Store NetworkServiceProvider connectivity service configuration in database.

2013-05-30 Thread Hiroaki KAWAI
pdate the patch to the latest state of master? On March 29th, 2013, 6:34 a.m., *Animesh Chaturvedi* wrote: Hiroaki can you update the patch to latetst master. Any updates Hiroaki? - Animesh On November 30th, 2012, 12:17 p.m., Hiroaki Kawai wrote: Review request for cloudstac

Review Request: CLOUDSTACK-2756: Stratosphere SSP plugin

2013-05-30 Thread Hiroaki Kawai
Testing --- Some unit test code included, and those run successfully. The plugin command run successfully on management server. Thanks, Hiroaki Kawai

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-30 Thread Hiroaki KAWAI
(2013/05/30 15:56), Sheng Yang wrote: -snip- BTW, I cannot figure out a way to automatically configure OVS on Ubuntu when booting up. it seems /etc/network/interfaces file doesn't know about OVS. The syntax is described in /usr/share/doc/openvswitch-__swi

Re: [PROPOSAL][ACS4.2] Stratosphere SDN platform plugin

2013-05-30 Thread Hiroaki KAWAI
ases On June 1, the 4.3 release cycle will open up. On 5/29/13 10:04 PM, "Hiroaki KAWAI" wrote: Hi all, # I think it is still ok to raise a proposal now... I would like to add a new feature to support "Stratosphere SDN platform" for guest networks in cloud

[PROPOSAL][ACS4.2] Stratosphere SDN platform plugin

2013-05-29 Thread Hiroaki KAWAI
ki : https://cwiki.apache.org/confluence/display/CLOUDSTACK/Stratosphere+SSP+Network+Plugin Please review. Thanks, --- Hiroaki KAWAI

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-29 Thread Hiroaki KAWAI
(2013/05/30 9:28), Sheng Yang wrote: 3. some tutorial on Ubuntu below: -snip- --__--- Probably we need a wiki for that. Hugo, I remember you got some documents on ovs setup for CentOS? I think we should merge them and setup a wiki page. +1 BTW, I c

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-29 Thread Hiroaki KAWAI
HI, To make clear I'd like note: 1. openvswich is available in distros, both in Ubuntu 13.04 and Fedora 18 2. brcompat is removed in openvswitch v1.10.0 Please have a look at http://openvswitch.org/releases/NEWS-1.10.0 So IMHO, we should not recommend brcompat. 3. some tutorial on Ubuntu below:

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-28 Thread Hiroaki KAWAI
(2013/05/29 15:26), Sheng Yang wrote: One more reason was to allow people use native bridging even one has accidentally installed openvswitch package. Bridge created on ovs is different from bridge created on native linux bridge. For later, ovs-vsctl shouldn't show any bridge/switch(e.g

Re: Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-28 Thread Hiroaki KAWAI
Hi, Thank you for comments; (2013/05/29 9:32), Sheng Yang wrote: I saw it a bit late... But I just found it need to depends on agent.properties: network.bridge.type=openvswitch How would that happen if user didn't add host before? It defaults to native linux bridge. Maybe we would just tr

[ACS41][PATCH REQ]

2013-05-27 Thread Hiroaki KAWAI
Chip, please cherry-pick to 4.1. # This was my bug, sorry. Branch: master commit e9a6d47316d8de90eb662e9938ea7fcbe0ee0596 Author: Hiroaki KAWAI Date: Tue May 28 11:55:21 2013 +0900 agent: fix network.bridge.type to be optional New network.bridge.type was introduced, but for

Re: [VOTE] Release Apache CloudStack 4.1.0 (fourth round)

2013-05-27 Thread Hiroaki KAWAI
(2013/05/27 22:34), Chip Childers wrote: Ok. Vote cancelled. I'll re-spin a fifth round RC. Thank you.

Re: Commits into 4.1 without patch request

2013-05-27 Thread Hiroaki KAWAI
Hi Wido, Thank you for telling me that. I remembered that Chip has sent how to control 4.1 release. http://markmail.org/message/qkkxycablpsmogsx https://cwiki.apache.org/confluence/display/CLOUDSTACK/CloudStack+4.1+Release Chip, the commits I pushed into 4.1 were: - 2 patch commit for debian p

Review Request: CLOUDSTACK-2327: make cloud-setup-agent ovs aware

2013-05-26 Thread Hiroaki Kawai
utils/networkConfig.py b6b729a python/lib/cloudutils/serviceConfig.py 1e32d0f Diff: https://reviews.apache.org/r/11428/diff/ Testing --- Tested with my local machines. - create .rpm, .deb - install it (CentOS 6.4 and Ubuntu 13.04) - add the computing node in management server Thanks, Hiroaki Kawai

Re: https://reviews.apache.org/r/9539/

2013-05-23 Thread Hiroaki KAWAI
Hi, I put it on RB because I wanted it to be reviewed by someone else. I'll merege by myself after nobody seems to review... (2013/05/24 14:12), Abhinandan Prateek wrote: Hi Wei, https://reviews.apache.org/r/9539/ was pending in my review dashboard. Now that you are a committer I think you

Re: [DISCUSS] Should we pause merges into master until 4.1 is out the door?

2013-05-22 Thread Hiroaki KAWAI
Hi. +1 for making effort to keep 4.1 maintained. As far as I know, there're many people waiting 4.1 release. IMHO, blocking merges in master is another topic. # I assume you're tired watching 4.1 As the master is getting dirty, inconsistent and looks like unmaintained, it may seem to be terribl

Review Request: CLOUDSTACK-1194: fix that isolation method does not show in Firefox

2013-05-22 Thread Hiroaki Kawai
Diff: https://reviews.apache.org/r/11327/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-05-16 Thread Hiroaki KAWAI
+1 I'm sorry that I could not make time to respond. I'll catch up after the merge. (2013/05/17 3:57), Chip Childers wrote: On Thu, May 16, 2013 at 06:55:30PM +, Chiradeep Vittal wrote: Sheng, I'd suggest that you go ahead and merge the patch. +1

Re: network guru refactor proposal

2013-05-11 Thread Hiroaki KAWAI
+1 for the basic idea. Non-guest networks are not easy to virtualize now. I assume you're talking about the isolation method in non-guest networks. (2013/05/07 20:53), Daan Hoogland wrote: LS, I want to refactor the network guru hierarchy to put som functionality in abstract base classes. Thi

Re: DeleteNiciraNvpDeviceCmd.java

2013-05-07 Thread Hiroaki KAWAI
Thank you for reporting. fixed in master and 4.1 :-) (2013/05/08 9:29), Soheil Eizadi wrote: I was reviewing the NiciraNvp code, it is a very good model of External Network Device in CloudStack. I noted that in DeleteNiciraNvpDeviceCmd.java, the function: @Override public Stri

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-04-18 Thread Hiroaki Kawai
> On April 18, 2013, 10:45 p.m., Chiradeep Vittal wrote: > > Looks good. Is this the final? > > Hiroaki Kawai wrote: > Yes. :-) > > Ready to ship? Any comments from anybody else? > > Chiradeep Vittal wrote: > Any tests? Tested functional wi

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-04-18 Thread Hiroaki Kawai
it: https://reviews.apache.org/r/9871/#review19414 --- On April 11, 2013, 7:22 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request: Typos fixed

2013-04-11 Thread Hiroaki Kawai
If you can prepare a patch for master branch, it is welcome of course ! :-) 2013/04/11 22:45、"Pascal Borreli" のメッセージ: > > >> On April 11, 2013, 1:26 p.m., Joe Brockmeier wrote: >>> Hi - the content looks good, but the actual patch looks wonky. Doesn't >>> apply. Can you reformat and make sure

Re: Review Request: Typos fixed

2013-04-11 Thread Hiroaki Kawai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/10411/#review18995 --- Ship it! Ship It! - Hiroaki Kawai On April 10, 2013, 11:06 p.m

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-04-11 Thread Hiroaki Kawai
/cloud/vm/VirtualMachineManagerImpl.java 9230f4a Diff: https://reviews.apache.org/r/9871/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-04-01 Thread Hiroaki KAWAI
l the existing network elements then there is no impact. On 4/1/13 12:28 AM, "Hiroaki Kawai" wrote: On March 29, 2013, 8 p.m., Chiradeep Vittal wrote: I do think an explicit migration interface on NetworkElement is the right way to do it. This way, network elements can decide expl

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-04-01 Thread Hiroaki Kawai
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review18531 ------- On March 29, 2013, 1:49 a.m., Hiroaki Kawai wrote: > > -

Re: [DOCS] Can't build Japanese docs

2013-03-30 Thread Hiroaki Kawai
2013/03/29 19:28、Sebastien Goasguen のメッセージ: >> >> -snip- >>> I ended fixing it in remove-vpx.xml , the tags need to be on a new >>> line… >> -snip- >> >> That's strange. I could successfully run publican. As it is an xml, >> new line should not matter... >> >> What I did: >> cd docs >> tx p

Re: [DOCS] Can't build Japanese docs

2013-03-29 Thread Hiroaki KAWAI
(2013/03/28 20:38), Sebastien Goasguen wrote: I fixed those on transifex. Please feel free to tell me if you still have trouble in building ja-JP docs. :-) thanks, I pulled all new translations. I am not sure what you did in transifex but it did not fix the issue :) -snip- There was an inva

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-03-29 Thread Hiroaki Kawai
--------- On March 29, 2013, 1:49 a.m., Hiroaki Kawai wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/9871/ > -

Refactoring questions

2013-03-28 Thread Hiroaki KAWAI
Hi, I see some descriptions about next cloudstack refactoring in cwiki (*1, *2). I have questions about: 1. What is the status of the development? 2. The refactoring seems to use distributed transaction managemnt, is this right? 3. Should the plugins also be refactored with the change of interface

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-03-28 Thread Hiroaki Kawai
/guru/PodBasedNetworkGuru.java b513325 server/src/com/cloud/network/guru/StorageNetworkGuru.java 879d0cd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a setup/db/create-schema.sql 5b6dc04 Diff: https://reviews.apache.org/r/9871/diff/ Testing --- Thanks, Hiroaki

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-03-28 Thread Hiroaki Kawai
13325 server/src/com/cloud/network/guru/StorageNetworkGuru.java 879d0cd server/src/com/cloud/vm/VirtualMachineManagerImpl.java 9230f4a setup/db/create-schema.sql 5b6dc04 Diff: https://reviews.apache.org/r/9871/diff/ Testing --- Thanks, Hiroaki Kawai

Re: Review Request: (CLOUDSTACK-1638) Network plugins won't be notified VM migration.

2013-03-27 Thread Hiroaki Kawai
an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9871/#review18137 --- On March 15, 2013, 6:51 a.m., Hiroaki Kawai wrote: > > --- > This is an

Re: [DOCS] Can't build Japanese docs

2013-03-27 Thread Hiroaki KAWAI
I fixed those on transifex. Please feel free to tell me if you still have trouble in building ja-JP docs. :-) Thanks (2013/03/24 19:28), Sebastien Goasguen wrote: I filed https://issues.apache.org/jira/browse/CLOUDSTACK-1796 I can't publican build japanese docs. I managed to fix chinese and po

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Hiroaki Kawai
tps://reviews.apache.org/r/9898/#comment38591> We must not catch bare Exception because it also catches RuntimeException. - Hiroaki Kawai On March 25, 2013, 4:02 a.m., Dave Cahill wrote: > > --- > This is an automatically gener

Re: Review Request: MidoNet Networking Plugin [2/2]

2013-03-26 Thread Hiroaki Kawai
> On March 14, 2013, 3:59 a.m., Hiroaki Kawai wrote: > > server/src/com/cloud/network/NetworkManagerImpl.java, line 1773 > > <https://reviews.apache.org/r/9898/diff/1/?file=270127#file270127line1773> > > > > NetworkElement should be always called after Networ