> On June 4, 2013, 2:29 p.m., Hugo Trippaers wrote: > > Heya, > > > > You know you can commit this directly? No need to go through the review > > process now you are a committer. > > > > However, since you opted to go through the review board, here is my review > > :D Just a couple of small remarks, nothing big so feel free to address the > > remarks and commit. > > > > I'm also missing the changes to the application context for oss and nonoss > > build, so this will not be loaded at the moment. You probably need to add > > those. > > > > > > Cheers, > > > > Hugo > > > > P.S. Can you send me some details on the Stratosphere solution? I would > > like to include this in my presentation on SDN in Cloudstack for CCC. > >
Thank you very much for comments. I fixed most of the issues you pointed out, and pushed into master. - Hiroaki ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11540/#review21418 ----------------------------------------------------------- On May 31, 2013, 12:44 a.m., Hiroaki Kawai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11540/ > ----------------------------------------------------------- > > (Updated May 31, 2013, 12:44 a.m.) > > > Review request for cloudstack, Chiradeep Vittal and Hugo Trippaers. > > > Bugs: CLOUDSTACK-2756 > > > Repository: cloudstack-git > > > Description > ------- > > Stratosphre SSP is an SDN controller that controls or brokers physical and or > virtual network devices. Stratosphere SSP will build a vxlan backed overlay > network. The plugin will contact SSP api to setup L2 networking environment > for cloudstack 4.2. > > This plugin will provide NetworkElement and NetworkGuru to enable the > element. The service provided by this plugin is "connectivity" service. > > > Diffs > ----- > > api/src/com/cloud/network/PhysicalNetwork.java c521dc4 > plugins/network-elements/stratosphere-ssp/pom.xml PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/commands/AddSspCmd.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/commands/DeleteSspCmd.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/api/response/SspResponse.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspCredentialVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspTenantVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidDao.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidDaoImpl.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/dao/SspUuidVO.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspClient.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspElement.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspManager.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/element/SspService.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/src/com/cloud/network/guru/SspGuestNetworkGuru.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspClientTest.java > PRE-CREATION > > plugins/network-elements/stratosphere-ssp/test/com/cloud/network/element/SspElementTest.java > PRE-CREATION > plugins/pom.xml 2efa248 > setup/db/db/schema-410to420.sql e081a25 > > Diff: https://reviews.apache.org/r/11540/diff/ > > > Testing > ------- > > Some unit test code included, and those run successfully. The plugin command > run successfully on management server. > > > Thanks, > > Hiroaki Kawai > >
