Re: Unable to access ASF repo

I assume you company has a network proxy? |git config --global http.proxy http://your.proxy.server:8080| On 08/12/2013 12:32 AM, Rayees Namathponnan wrote: Ticket https://issues.apache.org/jira/browse/INFRA-6657 created -Original Message- From: Animesh Chaturvedi [mailto:animesh.cha

Re: Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

matically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review22650 --- On June 29, 2013, 9:08 p.m., Dave Brosius wrote: > > --- > This is an auto

Re: Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

apache.org/r/12185/#review22654 --- On June 29, 2013, 2:34 a.m., Dave Brosius wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

Review Request 12192: set the field 'state' rather than the unread parameter 'state', if the parameter is null

2192/diff/ Testing ------- Thanks, Dave Brosius

Re: Review Request 11953: Remove code that does nothing but allocate a bunch of objects

://reviews.apache.org/r/11953/diff/ Testing --- Thanks, Dave Brosius

Review Request 12185: Remove dependency on backport-util.concurrent, and just use built in classes

/PerfManagerMO.java bb4fb56 vmware-base/src/com/cloud/hypervisor/vmware/mo/VirtualMachineMO.java cf5ffde Diff: https://reviews.apache.org/r/12185/diff/ Testing --- Thanks, Dave Brosius

Review Request: Remove code that does nothing but allocate a bunch of objects

been used for something in the past, but now does nothing but allocate memory temporarily. Diffs - engine/orchestration/src/org/apache/cloudstack/engine/cloud/entity/api/VMEntityManagerImpl.java 38ed7e6 Diff: https://reviews.apache.org/r/11953/diff/ Testing --- Thanks, Dave

Review Request: set rpcProvider field correctly in constructor

= rpcProvider; which is a NOP, due to missing 'this." - patch adds that. Diffs - engine/storage/src/org/apache/cloudstack/storage/HypervisorHostEndPointRpcServer.java bc21776 Diff: https://reviews.apache.org/r/11325/diff/ Testing --- Thanks, Dave Brosius

Review Request: remove dead allocations

/ListTemplatesCmd.java f0fc241 Diff: https://reviews.apache.org/r/11324/diff/ Testing --- Thanks, Dave Brosius

Review Request: remove bogus self assign to parent

= parent; even tho there isn't any non-field parent in the constructor... removed. Diffs - core/src/com/cloud/agent/api/storage/CreateEntityDownloadURLCommand.java d928e0c Diff: https://reviews.apache.org/r/11247/diff/ Testing --- Thanks, Dave Brosius

Review Request: when comparing scopes, compare scope ids by value, not reference.

with == which will work for Long cached values, but not others switched to use .equals Diffs - engine/api/src/org/apache/cloudstack/engine/subsystem/api/storage/AbstractScope.java c94db66 Diff: https://reviews.apache.org/r/11246/diff/ Testing --- Thanks, Dave Brosius

Re: Review Request: Nop assignment due to missing 'this.'

--- simple missed 'this.' causes self assignment, and not setting to field, patch adds Diffs - engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java 04714a6 Diff: https://reviews.apache.org/r/11245/diff/ Testing --- Thanks, Dave Brosius

Review Request: Nop assignment due to missing 'this.'

;this.' causes self assignment, and not setting to field, patch adds Diffs - engine/schema/src/com/cloud/network/dao/ExternalLoadBalancerDeviceVO.java 04714a6 Diff: https://reviews.apache.org/r/11245/diff/ Testing --- Thanks, Dave Brosius

Jira Karma

Greetings, Would someone be kind enough to give me Jira Karma to assign myself to issues? username: dbrosius