> On July 2, 2013, 7:11 a.m., daan Hoogland wrote: > > Your change seems fine. > > > > Did you regression test it? Or did you solve a problem with it?
Just noticed during code inspection - Dave ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12192/#review22650 ----------------------------------------------------------- On June 29, 2013, 9:08 p.m., Dave Brosius wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12192/ > ----------------------------------------------------------- > > (Updated June 29, 2013, 9:08 p.m.) > > > Review request for cloudstack. > > > Repository: cloudstack-git > > > Description > ------- > > code checks the parameter 'state' and if null, set it to Allocated, even > though that parameter is never accessed. Meant to set the field 'state'. > > > Diffs > ----- > > engine/schema/src/com/cloud/network/dao/NetworkVO.java 6580ea0 > > Diff: https://reviews.apache.org/r/12192/diff/ > > > Testing > ------- > > > Thanks, > > Dave Brosius > >
