Re: Review Request 28640: CLOUDSTACK-8010: [UI] Fixed unlocalized string "label.add.private.gateway"

2014-12-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28640/#review63908 --- Ship it! Ship It! - Brian Federle On Dec. 3, 2014, 9:44 a.m

Re: Review Request 28043: CLOUDSTACK 7915: Remove hard-coded values for Load Balancer algorithms in UI

2014-11-17 Thread Brian Federle
Balancer algorithms in UI - Brian Federle On Nov. 17, 2014, 6:26 p.m., Daniel Vega Simoes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 27991: CLOUDSTACK-7645: Use the localization function _l() instead of dictionary directly

2014-11-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27991/#review61491 --- Ship it! Ship It! - Brian Federle On Nov. 13, 2014, 2:55 p.m

Re: Review Request 27727: CLOUDSTACK-3528: [UI]list calls are in the processing state forever with invalid name provided with Account name search filter

2014-11-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27727/#review60842 --- Ship it! Ship It! - Brian Federle On Nov. 7, 2014, 2:29 p.m

Re: Review Request 27526: CLOUDSTACK-7831: Fixed unlocalized string on Advanced Network -> Network tab

2014-11-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27526/#review60823 --- Ship it! Ship It! - Brian Federle On Nov. 3, 2014, 4:11 p.m

Re: Review Request 27683: CLOUDSTACK-7318: [UI] Add error handler for VM snapshot creation

2014-11-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27683/#review60828 --- Ship it! Ship It! - Brian Federle On Nov. 6, 2014, 5:07 p.m

Re: Review Request 27878: CLOUDSTACK-7645: [UI] Fixed incorrect label issues caused the dictionary split

2014-11-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27878/#review60821 --- Ship it! Ship It! - Brian Federle On Nov. 11, 2014, 5:37 p.m

Re: Review Request 27863: CLOUDSTACK-7875: [UI] Wrong format check is being made on Create VPC box - DNS domain Information

2014-11-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27863/#review60817 --- Ship it! Ship It! - Brian Federle On Nov. 11, 2014, 11:33 a.m

Re: Review Request 27574: CLOUDSTACK-7645: [UI] Fix incorrect strings 'label.no' and 'label.added.network.offering'

2014-11-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27574/#review59836 --- Ship it! Ship It! - Brian Federle On Nov. 4, 2014, 4:55 p.m

Re: Review Request 27581: CLOUDSTACK-7838: UI - Update category names on Resources tab of a Zone

2014-11-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27581/#review59827 --- Ship it! Ship It! - Brian Federle On Nov. 4, 2014, 7 p.m

Re: Review Request 27583: CLOUDSTACK-7840: UI control tip for 'Add Primary Storage' -> 'Provider' seems wrong

2014-11-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27583/#review59829 --- Ship it! Ship It! - Brian Federle On Nov. 4, 2014, 7 p.m

Re: Review Request 27527: Fixing previous commit CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP

2014-11-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27527/#review59824 --- Ship it! Ship It! - Brian Federle On Nov. 3, 2014, 4:28 p.m

RE: UI: where has "Acquire new IP" button disappeared?

2014-10-30 Thread Brian Federle
I just cherry-picked and verified that commit in 4.4. -Brian -Original Message- From: Gabor Apati-Nagy Sent: Thursday, October 30, 2014 9:48 AM To: Brian Federle; dev@cloudstack.apache.org Subject: RE: UI: where has "Acquire new IP" button disappeared? Could someone cherry-pi

Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules

2014-10-29 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27300/#review59012 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m

Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields

2014-10-29 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27297/#review59007 --- Ship it! Ship It! - Brian Federle On Oct. 29, 2014, 3:17 p.m

Re: Review Request 27302: CLOUDSTACK-7808: Typo in Zone Creation Wizard

2014-10-28 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27302/#review58883 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m

Re: Review Request 27300: CLOUDSTACK-7766: Field Validations Missing for Ingress and Egress Rules

2014-10-28 Thread Brian Federle
Uncaught TypeError: Cannot read property 'call' of undefined -- I think this might be because your other patch for CLOUDSTACK-7765 wasn't applied yet (due to conflicts), but can you confirm if you are able to reproduce this issue or not, once fixing the other patch?

Re: Review Request 27297: CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields

2014-10-28 Thread Brian Federle
CLOUDSTACK-7765: Field Validations Missing for VPC IP Address Fields - Brian Federle On Oct. 28, 2014, 7:16 p.m., Gabor Apati-Nagy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 27296: CLOUDSTACK-7764: No IP Address Validations when Adding Networks

2014-10-28 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27296/#review58875 --- Ship it! Ship It! - Brian Federle On Oct. 28, 2014, 7:16 p.m

Re: Review Request 26693: CLOUDSTACK-7718: No Field Validations on Zone Form

2014-10-28 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26693/#review58873 --- Ship it! Ship It! - Brian Federle On Oct. 14, 2014, 6:12 p.m

Re: Review Request 26703: CLOUDSTACK-7720: No IP Address Validation for Acquire new secondary IP

2014-10-28 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26703/#review58871 --- Ship it! Ship It! - Brian Federle On Oct. 14, 2014, 6:12 p.m

Re: Review Request 26053: UI: Upgrade jquery-validate lib to the latest 1.13.0 version with the additional-methods included.

2014-10-27 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26053/#review58680 --- Ship it! Ship It! - Brian Federle On Oct. 27, 2014, 5:10 p.m

RE: UI: where has "Acquire new IP" button disappeared?

2014-10-27 Thread Brian Federle
Gabor, yes, that shouldn't be a problem to cherry-pick it into 4.4. -Brian From: Gabor Apati-Nagy Sent: Monday, October 27, 2014 9:26 AM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: RE: UI: where has "Acquire new IP" button d

Re: Review Request 26220: CLOUDSTACK-7645: [UI] Fixing incorrect labels, including instances of "???label.*???"

2014-10-02 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26220/#review55222 --- Ship it! Ship It! - Brian Federle On Oct. 1, 2014, 9:25 p.m

Re: Review Request 25707: CLOUDSTACK-7562: Details page for disk offerings only show details for write performance

2014-09-19 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25707/#review53963 --- Ship it! Ship It! - Brian Federle On Sept. 16, 2014, 7:37 p.m

Re: Review Request 25706: CLOUDSTACK-7561: UI: After creating a new account, the "Add Account" dialog remains open

2014-09-19 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25706/#review53960 --- Ship it! Ship It! - Brian Federle On Sept. 16, 2014, 7:36 p.m

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-17 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24090/#review53742 --- Ship it! Ship It! - Brian Federle On Sept. 12, 2014, 9:53 a.m

Re: Review Request 22143: CLOUDSTACK-6725: Fix: [OVS][UI] vm deployment wizard does not show all available zones in a region while deploying vm in a Regionlevel vpc

2014-09-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22143/#review53091 --- Ship it! Ship It! - Brian Federle On June 2, 2014, 5:07 p.m

Re: Review Request 22147: CLOUDSTACK-6722: Fix: [OVS][UI] Network created with StretchedL2Subnet is not available for vm deployement in other zones

2014-09-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22147/#review53085 --- Ship it! Ship It! - Brian Federle On June 2, 2014, 5:10 p.m

Re: Review Request 24090: Externalized the hard-coded strings from JavaScript files to resource bundles.

2014-09-10 Thread Brian Federle
latest master and regenerate patch. Thanks. error: patch failed: ui/scripts/vpc.js:698 error: ui/scripts/vpc.js: patch does not apply Patch failed at 0001 Fixes: Externalized hardcoded strings and splitted up dictionary file - Brian Federle On Sept. 8, 2014, 11:43 a.m., Vetrivel Chinnasamy

RE: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4

2014-08-26 Thread Brian Federle
Hi David, I just updated NOTICE. I verified that the content in LICENSE is still the same from the prior version. -Brian 182a0786bdab96b2bc582bce7b8e0fee685d8fd4 HEAD asf/master master Author: Brian Federle Date: Tue Aug 26 13:13:29 2014 -0700 Update NOTICE to account for updated jQuery

Re: Review Request 25029: UI: Upgrade jQuery from version 1.6.1 to 1.6.4

2014-08-26 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25029/#review51576 --- Ship it! Ship It! - Brian Federle On Aug. 25, 2014, 8:42 p.m

RE: [VOTE] Adapting git workflow for release branches

2014-08-19 Thread Brian Federle
Also a -1 on this, from all points made in previous replies. Thank you, Brian -Original Message- From: Jessica Wang [mailto:jessica.w...@citrix.com] Sent: Monday, August 18, 2014 9:52 AM To: dev@cloudstack.apache.org Cc: Edison Su; Min Chen; Sheng Yang; rohit.ya...@shapeblue.com Subject:

Re: Review Request 24504: CLOUDSTACK-7293: UI: Fixed localization issues on the login page

2014-08-15 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24504/#review50749 --- Ship it! Ship It! - Brian Federle On Aug. 8, 2014, 2:27 p.m

Re: Review Request 19675: [CLOUDSTACK-6228] Added the ability to show warning (exclamation mark) icon on confirmation dialogs

2014-08-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19675/#review50638 --- Ship it! Ship It! - Brian Federle On March 26, 2014, 10:47 a.m

Re: Review Request 24542: CLOUDSTACK-7302: UI: Removed Hover Interaction from breadcrumbs at top page

2014-08-12 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24542/#review50350 --- Ship it! Ship It! - Brian Federle On Aug. 11, 2014, 8:06 a.m

RE: [ACS4.5] GUI Question

2014-07-29 Thread Brian Federle
how the rest of UI handles API data -- parsing a JSON response and formatting for the user. -Brian -Original Message- From: Seif Eddine Jemli [mailto:seifeddineje...@gmail.com] Sent: Tuesday, July 29, 2014 3:15 PM To: Mike Tutkowski; Brian Federle; Alena Prokharchyk; dev@cloudstack.a

RE: [ACS4.5] GUI Question

2014-07-29 Thread Brian Federle
API calls. - You can then add more fields to the existing dialog(s), and edit their AJAX calls to read your new tag-type fields. Hope that helps. -Brian From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Monday, July 28, 2014 6:49 PM To: dev@cloudstack.apache.org Cc: Br

RE: "Accounts" -> "Add Account" UI Question

2014-05-13 Thread Brian Federle
oudStack Dev Cc: Brian Federle; Jessica Wang; Stephen Turner Subject: Re: "Accounts" -> "Add Account" UI Question Hi Thomas, Looks like a possible bug. CCing the UI team. They may be able to offer more info. On 13 May 2014 04:00, Thomas O'Dowd mailto:tpod...@cloudi

RE: [ACS4.4] Cherry pick for CLOUDSTACK-6483

2014-05-05 Thread Brian Federle
Daan just cp'd all my UI fixes now, so yours is ready to go in. -Brian From: Jessica Wang Sent: Monday, May 05, 2014 1:54 PM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: [ACS4.4] Cherry pick for CLOUDSTACK-6483 Hugo/Daan, Could you please cherry-pick the following commit

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

2014-05-05 Thread Brian Federle
...@gmail.com] Sent: Monday, May 05, 2014 1:28 PM To: Brian Federle Cc: dev Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b On Mon, May 5, 2014 at 9:36 PM, Brian Federle wrote: > 4d84970ddc91c2269807708e722942e9bc758185 doesn't apply/cherry-pick -- Daan

RE: git commit: updated refs/heads/4.4-forward to 259ce3b

2014-05-05 Thread Brian Federle
te request for that). Thanks Daan. -Brian -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, May 05, 2014 12:23 PM To: dev; Brian Federle Subject: Re: git commit: updated refs/heads/4.4-forward to 259ce3b On Mon, May 5, 2014 at 9

Re: Review Request 16002: CLOUDSTACK-3932 UI: Truncation issue occurred in secondary storage URL.

2014-05-05 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16002/#review42188 --- Ship it! Ship It! - Brian Federle On Dec. 6, 2013, 5:08 p.m

RE: old review https://reviews.apache.org/r/16002

2014-05-05 Thread Brian Federle
Yes, it looks like it indeed is still an issue in some cases. I'll take a look at it. Thanks, Brian -Original Message- From: Daan Hoogland [mailto:daan.hoogl...@gmail.com] Sent: Monday, May 05, 2014 11:19 AM To: Brian Federle; Jessica Wang Cc: dev Subject: old review

[ACS4.4] Cherry pick for CLOUDSTACK-6483

2014-05-02 Thread Brian Federle
Please cherry-pick 4.4-forward commits for CLOUDSTACK-6483 (in this order): 0b03609c45ecb5b4525e6a7b5216c70032d94a39 7daabf6515509dc276b968c6ca042cf964a328da 430d14b67608039159403036dae3dc7af1e590f5 Thank you, Brian

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/20391/#review41400 --- Ship it! Ship It! - Brian Federle On April 24, 2014, 9:47 p.m

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-24 Thread Brian Federle
> On April 22, 2014, 5:55 p.m., Brian Federle wrote: > > Gabor, for the most part the UI is good. However, I did notice the > > 'provider' fields on 'add VPC offering' are just simple text fields, > > instead of dropdowns -- is this intentional? >

Re: Review Request 20391: CLOUDSTACK-6255: UI for supporting region level VPC, distributed routing enabled VPC and stretched L2 neworks (ui for SDN)

2014-04-22 Thread Brian Federle
'provider' fields on 'add VPC offering' are just simple text fields, instead of dropdowns -- is this intentional? - Brian Federle On April 15, 2014, 10:41 p.m., Gabor Apati-Nagy wrote: > > --- > This is an a

RE: Best practice: Do not use innerHtml() property or it's equivalent jQuery .html() method

2014-04-17 Thread Brian Federle
2014 2:16 AM To: dev@cloudstack.apache.org Cc: Brian Federle Subject: RE: Best practice: Do not use innerHtml() property or it's equivalent jQuery .html() method Brian, didn't you fix most of these already? -- Stephen Turner -Original Message- From: Deme

Re: Review Request 12228: static resource compression

2014-04-02 Thread Brian Federle
. - Brian Federle On March 30, 2014, 8:08 p.m., Laszlo Hornyak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 19751: Fixed [CLOUDSTACK-5962]: Value of Global parameter "custom.diskoffering.size.min" is not reflected in UI during new instance creation

2014-04-01 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19751/#review39178 --- Ship it! Ship It! - Brian Federle On March 28, 2014, 2:45 p.m

Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)

2014-03-28 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19695/#review38912 --- Ship it! Ship It! - Brian Federle On March 28, 2014, 2:29 p.m

Re: Review Request 19695: CLOUDSTACK-6227 (Add copy-paste support for detail view fields)

2014-03-27 Thread Brian Federle
s.apache.org/r/19695/ > --- > > (Updated March 26, 2014, 6:47 p.m.) > > > Review request for cloudstack, Brian Federle and Jessica Wang. > > > Bugs: CLOUDSTACK-6227 > https://issues.apache.org/jira/browse/CL

Re: Review Request 19722: UI: Fixed truncated icon on confirmation dialog

2014-03-27 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19722/#review38817 --- Ship it! Ship It! - Brian Federle On March 27, 2014, 2:03 p.m

Re: Resetting a VM is broken?

2014-03-20 Thread Brian Federle
u continue you may lose data. >> Please confirm that you would like to proceed." >> >> -Brian >> >> On Mar 20, 2014, at 12:08 PM, Nux! wrote: >> >>> On 20.03.2014 18:55, Brian Federle wrote: >>>> Those suggestions sound g

Re: Resetting a VM is broken?

2014-03-20 Thread Brian Federle
, 2014, at 12:08 PM, Nux! wrote: > On 20.03.2014 18:55, Brian Federle wrote: >> Those suggestions sound good. Here are the changes I will make in the UI: >> - Change icon to use a ‘recycle’ symbol, to avoid confusion w/ reboot VM >> - Rename action(s) to reflect the name of the A

Re: Resetting a VM is broken?

2014-03-20 Thread Brian Federle
wll be destroyed and a new root >> disk will be attached to the VM." >> >> >> Harikrishna, >> do you any suggestion for the text in confirmation dialog? >> >> >> -Original Message- >> From: Jessica Wang [mailto:jessica.w...@citrix.

Re: Review Request 19463: UI: Applied localization function to labels on Zone Chart page

2014-03-20 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19463/#review37920 --- Ship it! Ship It! - Brian Federle On March 20, 2014, 2:11 p.m

Re: Resetting a VM is broken?

2014-03-20 Thread Brian Federle
>> the Reset Vm option is presented as a button unlike the icons I think this was because all the other icons we tried to represent this with were too confusing to users — they were clicking on 'reset VM' thinking it was ‘reboot VM’ — then as a last minute fix the decision was to just to show a

Re: Review Request 19037: Corrected the value of label.no.grouping in the resource files

2014-03-11 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/19037/#review36824 --- Ship it! Ship It! - Brian Federle On March 11, 2014, 2:52 p.m

Re: Review Request 18194: G11N: Fixed the Hardcoding Issue

2014-03-05 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18194/#review36277 --- Ship it! Ship It! - Brian Federle On March 5, 2014, 9:01 a.m

Re: Review Request 18695: Fix for CLOUDSTACK-4563: Initial zone wizard UI label issue

2014-03-03 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18695/#review35993 --- Ship it! Ship It! - Brian Federle On March 3, 2014, 4:44 p.m

Re: Review Request 18689: CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details.

2014-03-03 Thread Brian Federle
> On March 3, 2014, 6:07 p.m., Brian Federle wrote: > > Ship It! Also, note for next time: 'CS-19420' is an invalid bug ID. Please provide a bug that was created in the Apache JIRA. I created one for this and will ref the ID in the commit

Re: Review Request 18689: CS-19420: [UI] Fixed invalid field name (label.dynamically.scalable) on instance details.

2014-03-03 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18689/#review35989 --- Ship it! Ship It! - Brian Federle On March 3, 2014, 4:27 p.m

Re: Review Request 18432: Fixed some resource files issues

2014-02-25 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18432/#review35476 --- Ship it! Ship It! - Brian Federle On Feb. 24, 2014, 5:47 p.m

Re: Review Request 17541: Externalized the hard coded strings

2014-02-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17541/#review34496 --- Ship it! Ship It! - Brian Federle On Feb. 11, 2014, 8:29 a.m

RE: UI blocker

2014-01-17 Thread Brian Federle
17, 2014 11:53 AM To: dev@cloudstack.apache.org; Brian Federle Cc: Jessica Wang; Sonny Chhen Subject: Re: UI blocker On Jan 17, 2014, at 1:41 PM, Brian Federle wrote: > Sorry, but cosmetic issues are not blockers :) It would only be a blockers if > the functionality were NOT usable in any shape or form,

RE: UI blocker

2014-01-17 Thread Brian Federle
: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:56 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 2:48 PM, Brian Federle wrote: >>> Did you happen to check the View Users page ? the api/secr

RE: UI blocker

2014-01-16 Thread Brian Federle
I'll take a look at it. -Original Message- From: Sebastien Goasguen [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 11:17 AM To: Brian Federle Cc: dev@cloudstack.apache.org; Jessica Wang Subject: Re: UI blocker On Jan 16, 2014, at 1:39 PM, Brian Federle wrote: > Do

RE: UI blocker

2014-01-16 Thread Brian Federle
From: sebgoa [mailto:run...@gmail.com] Sent: Thursday, January 16, 2014 1:43 AM To: dev@cloudstack.apache.org Cc: Jessica Wang; Brian Federle Subject: UI blocker Hi, after testing 4.3 I entered a blocker due to UI issues: https://issues.apache.org/jira/browse/CLOUDSTACK-5882 It would be good to di

RE: Committer license for IntelliJ set to expire

2014-01-07 Thread Brian Federle
I'm using the committer license. -Brian -Original Message- From: Chip Childers [mailto:chipchild...@apache.org] Sent: Tuesday, January 07, 2014 7:18 AM To: dev@cloudstack.apache.org Subject: Committer license for IntelliJ set to expire Hey folks, The free license we have for IntelliJ f

Re: Review Request 16044: CLOUDSTACK-5388 Volume Snapshot UI does not provide option of adding quiesce vm parameter

2013-12-06 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16044/#review29910 --- Ship it! Ship It! - Brian Federle On Dec. 5, 2013, 9:28 p.m

Re: Review Request 16041: CLOUDSTACK-5384 UI dataProviders are unable to differentiate between load and refresh context

2013-12-05 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16041/#review29825 --- Ship it! Ship It! - Brian Federle On Dec. 5, 2013, 6:44 p.m

Re: Review Request 16001: ListViews marked with 'needsRefresh' do not have loading overlay removed on error

2013-12-04 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16001/#review29737 --- Ship it! Ship It! - Brian Federle On Dec. 4, 2013, 3:11 p.m

Re: Review Request 15362: Fixed issue with detail view fields marked as 'isPassword' not being obfuscated

2013-11-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15362/#review28893 --- Ship it! Ship It! - Brian Federle On Nov. 8, 2013, 8:33 p.m

RE: ui styling

2013-10-30 Thread Brian Federle
Hi Frankie, unfortunately that would be hard to do, since they were just incremental changes applied on master. I would have to cherry pick all the commits I did over time, which would take a while :). What you can try is copying the updated CSS files (/css), images (/images) and all scripts und

RE: Little GUI Issue

2013-10-28 Thread Brian Federle
Brian From: Mike Tutkowski [mailto:mike.tutkow...@solidfire.com] Sent: Monday, October 28, 2013 1:29 PM To: Brian Federle; dev@cloudstack.apache.org Subject: Little GUI Issue Hey Brian, I could log a JIRA ticket for this, if you'd like, but I believe I had logged one a while ago and it was

Re: Review Request 14782: [CLOUDSTACK-4910] Take VM snapshot instantly returns success regardless of actual result

2013-10-21 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14782/#review27252 --- Ship it! Ship It! - Brian Federle On Oct. 21, 2013, 3:27 p.m

RE: UI accounts wizard broken

2013-10-14 Thread Brian Federle
, 2013 5:25 AM To: Brian Federle Cc: Jessica Wang; Abhinandan Prateek; Pranav Saxena; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen Subject: Re: UI accounts wizard broken Generally, I'm thinking writing in a custom widget should only be for if a special layout or visual flow is n

RE: UI accounts wizard broken

2013-10-11 Thread Brian Federle
: Thursday, October 10, 2013 7:23 PM To: Jessica Wang; Abhinandan Prateek; Pranav Saxena Cc: Brian Federle; dev@cloudstack.apache.org; Animesh Chaturvedi; Sonny Chhen Subject: Re: UI accounts wizard broken Hi Brian, > I noticed that the 'add account' dialog was changed substantially

RE: UI accounts wizard broken

2013-10-10 Thread Brian Federle
: Abhinandan Prateek -Original Message- From: Brian Federle [mailto:brian.fede...@citrix.com] Sent: Thursday, October 10, 2013 12:46 PM To: dev@cloudstack.apache.org Cc: Animesh Chaturvedi; Jessica Wang; Sonny Chhen Subject: UI accounts wizard broken After reviewing the UI on the latest master, I

UI accounts wizard broken

2013-10-10 Thread Brian Federle
After reviewing the UI on the latest master, I noticed that the 'add account' dialog was changed substantially, and converted to a custom UI widget. Additionally, the password confirm field validation is broken, so I am unable to add a new account. Can I know the reason this was converted to a

Re: Review Request 12228: wip: static resource compression

2013-10-04 Thread Brian Federle
//reviews.apache.org/r/12228/ > --- > > (Updated Oct. 4, 2013, 8:19 p.m.) > > > Review request for cloudstack, Brian Federle and Prasanna Santhanam. > > > Repository: cloudstack-git > > > Descriptio

Re: Review Request 14285: Add multi-row action support to UI list views (CLOUDSTACK-1579)

2013-09-27 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14285/#review26456 --- Ship it! Ship It! - Brian Federle On Sept. 27, 2013, 8:34 p.m

Re: Review Request 13770: CLOUDSTACK-3363 UI > fix list Events/Alerts screen is in processing state forever with Delete Events/Alerts request having no filter

2013-09-27 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13770/#review26441 --- Ship it! Ship It! - Brian Federle On Aug. 28, 2013, 7:46 a.m

Re: Review Request 12228: static resource compression

2013-09-27 Thread Brian Federle
to give this a try as well if you want :) - Brian Federle On Sept. 24, 2013, 6:57 a.m., Laszlo Hornyak wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:/

RE: [DISCUSS] UI: New look and feel

2013-09-27 Thread Brian Federle
ly) On Thu, Sep 26, 2013 at 10:11:07PM +, Brian Federle wrote: > Hi all, > > In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' > of the current UI to give a better user experience and look and feel. This > will utilize SASS and a grid sy

RE: [DISCUSS] UI: New look and feel

2013-09-27 Thread Brian Federle
e.org Subject: Re: [DISCUSS] UI: New look and feel If you could use font icons, that would be really nice.. (MIT License) http://fortawesome.github.io/Font-Awesome/icons/ (Apache License) http://getbootstrap.com/components/#glyphicons On Fri, Sep 27, 2013 at 1:53 PM, Brian Federle wrote: > R

RE: [DISCUSS] UI: New look and feel

2013-09-27 Thread Brian Federle
Right now the plan was to remove the icons, though if people think that they are important to usability then we can definitely put them back in. I'm thinking flat icons though, which would look better with the new design. I'll play around with it and maybe post a screenshot with icons included.

RE: [DISCUSS] UI: New look and feel

2013-09-27 Thread Brian Federle
t for my site redesign proposal shortly) > > > On Thu, Sep 26, 2013 at 10:11:07PM +, Brian Federle wrote: >> Hi all, >> >> In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' >> of the current UI to give a better user exp

[DISCUSS] UI: New look and feel

2013-09-26 Thread Brian Federle
Hi all, In addition to the CSS code cleanup I'm working on, I am planning a 'reskin' of the current UI to give a better user experience and look and feel. This will utilize SASS and a grid system as I have discussed in the previous thread. I created a task in JIRA and wiki functional spec, whic

RE: [DISCUSS] CSS framework for CloudStack UI

2013-09-19 Thread Brian Federle
It'd be great if we can minimize them into a single file during build. Also, if we were to add any UI tests using libraries like jasmine, grunt makes it easy automate them. Shiva Teja On Wed, Sep 18, 2013 at 9:49 PM, Brian Federle wrote: > Yeah, I'm definitely thinking the newer spec

RE: [DISCUSS] CSS framework for CloudStack UI

2013-09-18 Thread Brian Federle
Yeah, I'm definitely thinking the newer spec, which is better for us anyway since it is backwards-compatible with existing CSS. What I'll do is setup a dummy branch, which basically renames cloudstack3.css to cloudstack.scss or something like that, without much modification right now, and then

RE: [DISCUSS] CSS framework for CloudStack UI

2013-09-17 Thread Brian Federle
On Thu, Aug 8, 2013 at 11:11 PM, Brian Federle wrote: > That sounds awesome, though I'm not too much of a guru with either > maven or grunt -- I would be glad to coordinate with anyone who wants > to take that on. > > -Brian > > -Original Message- > From: Am

RE: [VOTE] Apache Cloudstack 4.2.0

2013-08-26 Thread Brian Federle
013 3:56 PM To: Mike Tutkowski Cc: dev@cloudstack.apache.org; Brian Federle; Jessica Wang Subject: RE: [VOTE] Apache Cloudstack 4.2.0 Mike the commit message shows it is a merge "Merge remote-tracking branch 'upstream/4.2-forward' into 4.2-forward" Adding Brian and Jess

Re: Review Request 13128: Zone Chart Extension

2013-08-22 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13128/#review25435 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:37 p.m

RE: Git repo down error: no DAV locking support

2013-08-22 Thread Brian Federle
Same here. I've tried pushing to both master and 4.2-forward. I can git pull fine, but it just hangs forever when I try to git push. Maybe something up with the authentication system? -Brian -Original Message- From: Animesh Chaturvedi [mailto:animesh.chaturv...@citrix.com] Sent: Thursd

RE: 404 on some .css files

2013-08-15 Thread Brian Federle
Good catch, yeah the 404s are caused because those plugins do not have any .css file associated with them. I can probably just add a few blank .css files to silence the errors, though otherwise they are harmless. -Brian -Original Message- From: La Motta, David [mailto:david.lamo...@neta

Re: Review Request 13131: Default field identifier

2013-08-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13131/#review25155 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:38 p.m

Re: Review Request 13132: Field default value functions

2013-08-14 Thread Brian Federle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13132/#review25152 --- Ship it! Ship It! - Brian Federle On Aug. 2, 2013, 1:37 p.m

  1   2   >