----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/17541/#review34496 -----------------------------------------------------------
Ship it! Ship It! - Brian Federle On Feb. 11, 2014, 8:29 a.m., Vetrivel Chinnasamy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/17541/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2014, 8:29 a.m.) > > > Review request for cloudstack and Brian Federle. > > > Repository: cloudstack-git > > > Description > ------- > > Externalized hard coded strings > > > Diffs > ----- > > client/WEB-INF/classes/resources/messages.properties f1c166b > client/WEB-INF/classes/resources/messages_ja_JP.properties 4232449 > client/WEB-INF/classes/resources/messages_zh_CN.properties 7cb65d3 > ui/dictionary.jsp 16ecbab > ui/lib/jquery.validate.js 72296a6 > ui/scripts/accounts.js a15cc87 > ui/scripts/autoscaler.js ab1b459 > ui/scripts/domains.js 5d8fd68 > ui/scripts/installWizard.js dbea34e > ui/scripts/instances.js 3b1931b > ui/scripts/regions.js ac573b7 > ui/scripts/system.js 11dd0ba > ui/scripts/templates.js 8c63ce2 > > Diff: https://reviews.apache.org/r/17541/diff/ > > > Testing > ------- > > Local unit testing done by replacing the javascript, dictionary.jsp and > properties files. > > > Thanks, > > Vetrivel Chinnasamy > >