[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689332232 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/657 (JID-3

[GitHub] [cloudstack-primate] utchoang edited a comment on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
utchoang edited a comment on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689331061 @davidjumani I think this makes it possible for the user to go back to the previous list by clicking on the breadcrumb instead of using the browser's back butt

[GitHub] [cloudstack-primate] utchoang commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
utchoang commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689331061 @davidjumani I think this makes it possible for the user to go back to the previous list by clicking on the breadcrumb instead of using the browser's back button.

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689328965 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
davidjumani commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689328713 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani removed a comment on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
davidjumani removed a comment on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689324100 https://github.com/apache/cloudstack/pull/4311 This is an automated message from the Apach

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
blueorangutan commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689325055 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
davidjumani commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689324100 https://github.com/apache/cloudstack/pull/4311 This is an automated message from the Apache Git Se

[GitHub] [cloudstack-primate] davidjumani commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
davidjumani commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689323743 @utchoang It would be better to tweak the breadcrumb only if the user is in a detail view. When clicking the zone while listing the instances, the breadcrumb sh

[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-689321623 @davidjumani I've fixed it. Please review it again. Thanks. ![Screenshot_1](https://user-images.githubusercontent.com/13766648/92559482-dfb09b00-f29a-11ea-9062-9b26

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
blueorangutan commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689321173 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
Pearl1594 commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-689320721 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
blueorangutan commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689315854 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/672 (JID-3

[GitHub] [cloudstack-primate] davidjumani commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-08 Thread GitBox
davidjumani commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-689314468 Fixed in the backend via https://github.com/apache/cloudstack/pull/4311 This is an automated message fr

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry

2020-09-08 Thread GitBox
blueorangutan commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689313499 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/658 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
blueorangutan commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689311485 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
davidjumani commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-689311295 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #658: Fixes reload of page on session expiry

2020-09-08 Thread GitBox
blueorangutan commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689308818 @davidjumani a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. -

[GitHub] [cloudstack-primate] davidjumani commented on pull request #662: Refresh data every 30 seconds

2020-09-08 Thread GitBox
davidjumani commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-689308837 It makes sense where multiple users are logged in and make changes, so that the current user gets the most up to date info. Can close this if it is a niche case!

[GitHub] [cloudstack-primate] davidjumani commented on pull request #658: Fixes reload of page on session expiry

2020-09-08 Thread GitBox
davidjumani commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-689308431 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
davidjumani commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r485342832 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -25,17 +25,45 @@ size="middle" :scroll="{ y: 225 }" > +

[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
davidjumani commented on a change in pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r485342703 ## File path: src/views/compute/wizard/NetworkConfiguration.vue ## @@ -25,17 +25,45 @@ size="middle" :scroll="{ y: 225 }" > +

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
blueorangutan commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688921886 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/649 (JID-3

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
blueorangutan commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688915780 @Pearl1594 a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress. ---

[GitHub] [cloudstack-primate] Pearl1594 commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
Pearl1594 commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688915224 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the m

[PROPOSE] Code freeze for 4.15

2020-09-08 Thread Paul Angus
Hi all, Its around that time of year again. We owe the world a GA version of Primate + there is support for Ubuntu 20.04, CentOS 8 and XenServer/XCP-ng 8, a massive update to the vSphere capabilities and many fixes.. So, I'd like to propose a feature freeze in two or three weeks' time (dep

[GitHub] [cloudstack-primate] shwstppr commented on issue #660: [BUG] K8s version - various issues ?

2020-09-08 Thread GitBox
shwstppr commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-688799662 @rhtyd I don't think any changes will be needed in Primate. Though, maybe we can verify backend changes with Primate which should show better error messages and parameter

[GitHub] [cloudstack-primate] rhtyd commented on pull request #662: Refresh data every 30 seconds

2020-09-08 Thread GitBox
rhtyd commented on pull request #662: URL: https://github.com/apache/cloudstack-primate/pull/662#issuecomment-688780441 Can you advise a case where doing infinite refresh makes sense, and where the async event based refresh in the other PR doesn't fix refresh issue? -

[GitHub] [cloudstack-primate] rhtyd commented on pull request #658: Fixes reload of page on session expiry

2020-09-08 Thread GitBox
rhtyd commented on pull request #658: URL: https://github.com/apache/cloudstack-primate/pull/658#issuecomment-688780051 @davidjumani can you review as well? This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
rhtyd commented on a change in pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#discussion_r484818035 ## File path: src/config/section/storage.js ## @@ -101,6 +101,26 @@ export default { label: 'label.action.attach.disk', messa

[GitHub] [cloudstack-primate] rhtyd commented on pull request #649: Filter vms based on zones for attaching volumes

2020-09-08 Thread GitBox
rhtyd commented on pull request #649: URL: https://github.com/apache/cloudstack-primate/pull/649#issuecomment-688779313 @davidjumani can you review as well? This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-primate] rhtyd commented on issue #670: [BUG] Sensitive vcenter info should be hidden from the "user" role

2020-09-08 Thread GitBox
rhtyd commented on issue #670: URL: https://github.com/apache/cloudstack-primate/issues/670#issuecomment-688778520 @andrijapanicsb this is same as what you see in old UI, any exception thrown is usually shown as an alert which shows error from the backend API response ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #669: [BUG] VM Deployment wizard not listing existing "Instance Groups"

2020-09-08 Thread GitBox
rhtyd commented on issue #669: URL: https://github.com/apache/cloudstack-primate/issues/669#issuecomment-688778161 @davidjumani see the auto-complet-able a-input (see similar used in Role->rules) which can show a list of available VM instance groups to the user as well as allow any kind o

[GitHub] [cloudstack-primate] rhtyd commented on issue #660: [BUG] K8s version - various issues ?

2020-09-08 Thread GitBox
rhtyd commented on issue #660: URL: https://github.com/apache/cloudstack-primate/issues/660#issuecomment-688776649 Do we need to make any change in Primate @shwstppr cc @andrijapanicsb @davidjumani ? This is an automated me

[GitHub] [cloudstack-primate] rhtyd commented on issue #653: [BUG] Click Instance --> Click Volume = breadcrumb gone

2020-09-08 Thread GitBox
rhtyd commented on issue #653: URL: https://github.com/apache/cloudstack-primate/issues/653#issuecomment-688776341 @andrijapanicsb the intention was to use and encourage users to use the browser back button This is an autom

[GitHub] [cloudstack-primate] rhtyd commented on pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
rhtyd commented on pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672#issuecomment-688775985 @davidjumani can you review this? This is an automated message from the Apache Git Service. To respond t

[GitHub] [cloudstack-primate] rhtyd commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
rhtyd commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-688775384 @davidjumani please review this This is an automated message from the Apache Git Service. To respond to

[GitHub] [cloudstack-primate] rhtyd closed issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-08 Thread GitBox
rhtyd closed issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [cloudstack-primate] rhtyd commented on issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-08 Thread GitBox
rhtyd commented on issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671#issuecomment-688774544 Yes, thanks. Closing this on your remark. This is an automated message from the Apache Git Service. To respon

[GitHub] [cloudstack-primate] andrijapanicsb commented on issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-08 Thread GitBox
andrijapanicsb commented on issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671#issuecomment-688773870 If not possible to fix it easily - ok, let's close it. This is an automated message from the Apache

[GitHub] [cloudstack-primate] rhtyd commented on issue #671: [BUG] Refresh list of systemVMs if some are starting/stopping/destroying

2020-09-08 Thread GitBox
rhtyd commented on issue #671: URL: https://github.com/apache/cloudstack-primate/issues/671#issuecomment-688772974 @andrijapanicsb currently we don't have a event-based way to know if a resource state has changed, so we cannot know for all sorts of resources (including systemvms) - old UI

[GitHub] [cloudstack-primate] rhtyd edited a comment on issue #668: [FEATURE] Disable values starting with a space

2020-09-08 Thread GitBox
rhtyd edited a comment on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688768160 David checked and it's an issue at backend, fixing this in UI will still allow API to do this - so ideally the backend should trim the space. Note - in backend, all AP

[GitHub] [cloudstack-primate] rhtyd commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-08 Thread GitBox
rhtyd commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688768160 David checked and it's an issue at backend, fixing this in UI will still allow API to do this - so ideally the backend should trim the space. ---

[GitHub] [cloudstack-primate] rhtyd commented on issue #668: [FEATURE] Disable values starting with a space

2020-09-08 Thread GitBox
rhtyd commented on issue #668: URL: https://github.com/apache/cloudstack-primate/issues/668#issuecomment-688691387 @andrijapanicsb it may cause unexpected results in some cases, what is somebody wants to put space in front/end of a string input? Does old UI trim the space too ? I'm tentat

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-688684752 Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. QA: http://primate-qa.cloudstack.cloud:8080/client/pr/657 (JID-3

[GitHub] [cloudstack-primate] utchoang opened a new pull request #672: FIX - Breadcrumb gone

2020-09-08 Thread GitBox
utchoang opened a new pull request #672: URL: https://github.com/apache/cloudstack-primate/pull/672 @rhtyd cc @svenvogel Fixes #653 I fixed the error by saving breadcrumb data to `$store` and this is fine. But I'm not sure if it works well compared to the old logic. Please check

[GitHub] [cloudstack-primate] blueorangutan commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
blueorangutan commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-688677085 @utchoang a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.

[GitHub] [cloudstack-primate] utchoang commented on pull request #657: vm wizard: add MAC Address validator

2020-09-08 Thread GitBox
utchoang commented on pull request #657: URL: https://github.com/apache/cloudstack-primate/pull/657#issuecomment-688676677 @blueorangutan package This is an automated message from the Apache Git Service. To respond to the me