davidjumani commented on a change in pull request #657:
URL: https://github.com/apache/cloudstack-primate/pull/657#discussion_r485342703
##########
File path: src/views/compute/wizard/NetworkConfiguration.vue
##########
@@ -25,17 +25,45 @@
size="middle"
:scroll="{ y: 225 }"
>
+ <template slot="name" slot-scope="text, record">
+ <div>{{ text }}</div>
+ <small>{{ $t('label.cidr') + ': ' + record.cidr }}</small>
+ </template>
<template slot="ipAddress" slot-scope="text, record">
- <a-input
- style="width: 150px;"
- :placeholder="$t('label.ipaddress')"
- @change="($event) => updateNetworkData('ipAddress', record.id,
$event.target.value)" />
+ <a-form-item>
Review comment:
@utchoang Could you hide this if the network typle is L2, since they do
not have IP addresses ?
##########
File path: src/views/compute/wizard/NetworkConfiguration.vue
##########
@@ -25,17 +25,45 @@
size="middle"
:scroll="{ y: 225 }"
>
+ <template slot="name" slot-scope="text, record">
+ <div>{{ text }}</div>
+ <small>{{ $t('label.cidr') + ': ' + record.cidr }}</small>
+ </template>
<template slot="ipAddress" slot-scope="text, record">
- <a-input
- style="width: 150px;"
- :placeholder="$t('label.ipaddress')"
- @change="($event) => updateNetworkData('ipAddress', record.id,
$event.target.value)" />
+ <a-form-item>
Review comment:
@utchoang Could you hide this if the network type is L2, since they do
not have IP addresses ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
