Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162284601
LGTM. I am ok with this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project do
Github user anshul1886 commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-162284129
@ustcweizhou Closing this PR as #1168 fixes the same issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user anshul1886 closed the pull request at:
https://github.com/apache/cloudstack/pull/1166
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user anshul1886 commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1176#discussion_r46767279
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/XenServerGuru.java ---
@@ -185,7 +185,8 @@ public boolean trackVmHostChange() {
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162262512
More tests... On the same environment, but with hardware TRUE.
```
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765516
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46765484
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network netwo
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/1166#issuecomment-162249766
@anshul1886 Can you please close this PR or will you change to almost same
to #1168 ?
---
If your project is set up for it, you can reply to this email and hav
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/855#issuecomment-162243277
@anshul1886 I trust you are alright with this change in comment, are you?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162243159
Wilder can this one be on 4.6 please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your p
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761996
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761989
--- Diff: server/src/com/cloud/network/element/VpcVirtualRouterElement.java
---
@@ -479,48 +482,47 @@ public boolean applyIps(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761973
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -841,24 +857,26 @@ public VirtualRouterProvider addElement(final Long
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761967
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -751,13 +757,15 @@ public boolean savePassword(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761965
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -765,18 +773,23 @@ public boolean saveSSHKey(final Network network,
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761947
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -656,20 +660,22 @@ public static String getHAProxyStickinessCapabilit
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761941
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761920
--- Diff: server/src/com/cloud/network/element/VirtualRouterElement.java ---
@@ -509,10 +512,11 @@ public boolean applyIps(final Network network, fin
Github user wilderrodrigues commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761916
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(fin
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761845
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -488,50 +494,54 @@ public boolean applyPFRules(final Net
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162237998
@DaanHoogland
Agree... ;) Sometimes I find difficult to wear different hats, although I
could do it just fine. Should I change the title here and o
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761835
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -468,19 +470,23 @@ public boolean applyStaticNats(final
Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -445,13 +446,14 @@ public boolean applyIps(final Network
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162237710
I like the scrum style title but just to be nitpicking: isn't this more of
a network engineer feature instead of a developer tool?
---
If your project is set
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162234338
Yes we do, it might not be the final solution as per the discussion above
but it is an improvement.
---
If your project is set up for it, you can reply to this
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/1179#issuecomment-162233742
Ping @remibergsma @DaanHoogland @bhaisaab @karuturi @borisroman
@miguelaferreira
Could you please review this PR? I will execute more tests now.
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/1179
CLOUDSTACK-9106 - As a Developer I want the Redundant VPC private gateway
feature fixed
This PR fixes the Private Gateway feature when using Redundant VPCs.
In order to get it
Github user remibergsma commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/872#discussion_r46761289
--- Diff: systemvm/patches/debian/vpn/etc/ipsec.d/l2tp.conf ---
@@ -30,4 +33,6 @@ conn L2TP-PSK
#
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/977#issuecomment-162232240
@ustcweizhou Can you please rebase and resolve the conflict? I can then run
the tests again.
@wido @DaanHoogland Do we want this in 4.7?
---
If your pr
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1108
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1108#issuecomment-162231828
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162231638
Ok, I'll post results later
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162231372
@anshul1886 Please address comments made above. After that we can merge.
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1176#issuecomment-162231182
Run the tests again and it looks good.
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advan
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1124#issuecomment-162230888
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/840
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/937
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/840#issuecomment-162229695
LGTM based on these tests:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=true \
component/test_v
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162225746
ping @nvazquez would you be able to test this PR?
The new marvin test I added requires two hosts in order to test the NSX
tunnel between them.
---
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1178#issuecomment-162225661
As for testing, I've built the entire project executing all unit tests
(including the one I've added to prevent a regression on this issue), the
existing ma
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/1178
Prevent live-lock in NSX API client
The NSX api client relies on a sequence of responses to identify the need
to authenticate and to follow redirects. In order to avoid live-locks, the
Hi all.
My environment:
CloudStack 4.6.1
http://packages.shapeblue.com/cloudstack/upstream/centos7/4.6/
Hypervisor CentOS7/KVM
SystemVM
http://cloudstack.apt-get.eu/systemvm/4.6/systemvm64template-4.6.0-kvm.qcow2.bz2
Steps to reproduce:
1)Create VPC (Redundant VPC offering)
2)Create tier1 &
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162211138
I'm finishing my own test, and will test this PR asap.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHu
Github user jburwell commented on the pull request:
https://github.com/apache/cloudstack/pull/768#issuecomment-162211091
I will review the code later today/this evening. I will also verify that
all of our known issues have been addressed.
> On Dec 4, 2015, at 6:13 PM, Remi Be
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/1094#issuecomment-162187421
Hi @remibergsma @miguelaferreira
I've been working in marvin test file to cover this new features, those are
test03 y test04 in test/integration/smoke/tes
I'm loving it!
Hopefully the rVPC Private Gateway will be fixed within the next hour! Few
things were not anticipated on the Java side of the code. I have already
refactored the NicProfileHelper and some other classes. Deploying a DC and will
test it soon.
Cheers,
Wilder
Sent from my iPhone
46 matches
Mail list logo
