Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1179#discussion_r46761808
--- Diff:
plugins/network-elements/ovs/src/com/cloud/network/element/OvsElement.java ---
@@ -445,13 +446,14 @@ public boolean applyIps(final Network network,
return true;
}
- DataCenterVO dcVO = _dcDao.findById(network.getDataCenterId());
- NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
+ final DataCenterVO dcVO =
_dcDao.findById(network.getDataCenterId());
+ final NetworkTopology networkTopology =
_networkTopologyContext.retrieveNetworkTopology(dcVO);
- return networkTopology.associatePublicIP(network, ipAddress,
routers);
- } else {
- return false;
+ for (final DomainRouterVO domainRouterVO : routers) {
+ result = networkTopology.associatePublicIP(network,
ipAddress, domainRouterVO);
--- End diff --
will we forget all intermediate results and only return the last one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
