[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46115019 --- Diff: setup/db/db/schema-460to470.sql --- @@ -18,3 +18,5 @@ --; -- Schema upgrade from 4.6.0 to 4.7.0; --; + +ALTER TAB

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46115024 --- Diff: setup/db/db/schema-461to470.sql --- @@ -18,3 +18,5 @@ --; -- Schema upgrade from 4.6.1 to 4.7.0; --; + +ALTER TAB

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-160545614 @nvazquez I've just read through you code and I made some comments that I would be happy to discuss with you. Nice to see effort being put in unit t

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114822 --- Diff: setup/db/db/schema-460to470.sql --- @@ -18,3 +18,5 @@ --; -- Schema upgrade from 4.6.0 to 4.7.0; --; + +ALTER TAB

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114825 --- Diff: setup/db/db/schema-461to470.sql --- @@ -18,3 +18,5 @@ --; -- Schema upgrade from 4.6.1 to 4.7.0; --; + +ALTER TAB

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114748 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.ja

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114722 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkVlanIdCommandWrapper.ja

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114716 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114701 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/resource/wrapper/NiciraNvpConfigureSharedNetworkUuidCommandWrapper.java

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114646 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/guru/NiciraNvpGuestNetworkGuru.java --- @@ -102,11 +112,11 @@ publ

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114312 --- Diff: plugins/network-elements/nicira-nvp/src/main/java/com/cloud/network/element/NiciraNvpElement.java --- @@ -239,8 +244,51 @@ public bool

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114230 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -671,8 +672,19 @@ public void doI

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114108 --- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java --- @@ -102,6 +102,14 @@ @Param(description = "Id of the vm to whic

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114122 --- Diff: api/src/org/apache/cloudstack/api/response/NicResponse.java --- @@ -102,6 +102,14 @@ @Param(description = "Id of the vm to whic

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46114035 --- Diff: api/src/com/cloud/network/guru/NetworkGuruAdditionalFunctions.java --- @@ -0,0 +1,12 @@ +package com.cloud.network.guru; +

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46113829 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -671,8 +672,19 @@ public void doI

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46113758 --- Diff: engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java --- @@ -671,8 +672,19 @@ public void doI

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user miguelaferreira commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1094#discussion_r46113707 --- Diff: api/src/com/cloud/network/Networks.java --- @@ -251,6 +252,10 @@ public static URI fromString(String candidate) { i

[GitHub] cloudstack pull request: CLOUDSTACK-9094: Multiple threads are bei...

GitHub user harikrishna-patnala opened a pull request: https://github.com/apache/cloudstack/pull/1140 CLOUDSTACK-9094: Multiple threads are being used to collect the stats… CLOUDSTACK-9094: Multiple threads are being used to collect the stats from the same VR Same thread

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/834 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/834#issuecomment-160537225 @maneesha-p Probably not cleanly anymore. I'll give it a shot. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160532869 Yes, I understand and it makes sense to have that documented. It doesn't have to mean we phase out QueryService. This makes sense to be there for people with r

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

Github user harikrishna-patnala commented on the pull request: https://github.com/apache/cloudstack/pull/1139#issuecomment-160531359 Looks good to me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] cloudstack pull request: CLOUDSTACK-9092: L10n fix in "Add LDAP Ac...

GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/1139 CLOUDSTACK-9092: L10n fix in "Add LDAP Account page" fixed two strings on the "Add LDAP Account page" After the change: (with a test string in messages_ja_JP.properties file) ![scr

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-160517214 @bhaisaab why are we merging the feature branch into a 4.6.* maintenance/minor release branch. Shouldn't it be merged into a major release branch/maste

[GitHub] cloudstack pull request: [4.5] CLOUDSTACK-4787 - vmware diskcontro...

Github user sateesh-chodapuneedi commented on the pull request: https://github.com/apache/cloudstack/pull/1131#issuecomment-160517089 @bhaisaab why are we merging the feature breanch into a 4.5.* maintenance/minor release branch. Shouldn't it be merged into a major release branch/mast

Build failed in Jenkins: simulator-4.5-singlerun #280

See -- Started by upstream project "build-4.5-simulator" build number 334 originally caused by: Started by upstream project "build-4.5" build number 542 originally caused by: Started by an

Re: What SDN are you using?

Hm - Not a single mention of OpenvSwitch? I wonder why?... Eric Pretorious Portland, OR On Nov 29, 2015 11:20 AM, "Simon Weller" wrote: > Nux, > > The two most deployed SDN solutions are Vmware NSX-MH (Nicara) and Nuage > VSP (Alcatel-Lucent). Neither are cheap! > We've been evaluating whether

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1121#issuecomment-160514198 Verifying this is simple, just check the in the VM's virt xml (virsh edit domain, note the serial in the xml for the disk/volume) and ssh into the VM and check th

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-160514080 Thanks @remibergsma Ping @sateesh-chodapuneedi can you review this, and later if you want sent additional PRs with further changes etc. --- If your project i

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1117 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1117#issuecomment-160513890 Merging on 4.5, since the fix has been tested and merged on 4.6 --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1115#issuecomment-160513845 @remibergsma cool, @abhinandanprateek can you close this; as the other PR has been merged on 4.6 and will be fwd-merged on master to get the fix on master. --- I

[GitHub] cloudstack pull request: CLOUDSTACK-8866 : restart.retry.interval ...

Github user maneesha-p commented on the pull request: https://github.com/apache/cloudstack/pull/834#issuecomment-160512875 @remibergsma 2 LGTM s . Can this be merged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

Github user sanju1010 commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1122#discussion_r46107622 --- Diff: test/integration/component/test_tags.py --- @@ -2401,3 +2403,143 @@ def test_23_list_untagged_host_for_vm_migration(self): i

[GitHub] cloudstack pull request: [4.6.1] [4.7] CLOUDSTACK-9022: keep Destr...

Github user ustcweizhou commented on the pull request: https://github.com/apache/cloudstack/pull/1029#issuecomment-160467601 @remibergsma rebased with latest master. There is a conflict with 4.6 because of commit 1a64c247adbeb326f7ddbe6e4feaf3159e9e740d --- If your project is s

Re: What SDN are you using?

Nux, The two most deployed SDN solutions are Vmware NSX-MH (Nicara) and Nuage VSP (Alcatel-Lucent). Neither are cheap! We've been evaluating whether we're going to run a POC on Nuage, as it does have some very cool features including service chaining. Most of the other SDN plugins within CS are

[GitHub] cloudstack pull request: Update L10N resource files with 4.6 strin...

GitHub user milamberspace opened a pull request: https://github.com/apache/cloudstack/pull/1138 Update L10N resource files with 4.6 strings from Transifex (20151129) Small update of L10N files before the 4.6.1 release candidate cc @remibergsma You can merge this pull

What SDN are you using?

Hello, So besides the folks using Nicira, can anyone recommend any other SDN thing or should I stay with v(x)lans? I'm kind of removed from this side of things since my deployments tend to be with Security Grups in a single or few VLANs, any suggestions welcome, preferably free/foss. Lucian -

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160447903 @DaanHoogland I was talking about the implementation of APIs. Example, let's say you create a new module, call it Exampe. So we can list, create and delete Example. W

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160444699 @pdube, no, there is a page on cleaning up the API but as the semantic version scheme commands we should only do that cleaning up per version 5.0. see https://

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-160443626 @bhaisaab Let's find someone else who can review this.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1085 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-160442447 Functionality also works: ``` (local) � > list vlanipranges keyword=50 count = 1 vlaniprange: id = abdc0be9-6869-438b-9b10-16061bd0bdcb

[GitHub] cloudstack pull request: [4.6] Cannot list vlanipranges by keyword

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1085#issuecomment-160442363 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9064: The users should be able...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1116#issuecomment-160442050 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user pdube commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160441642 @DaanHoogland I did not find a guide to do it. I looked at the patterns I found in other modules, and imitated those. I found it confusing because there were a few di

[GitHub] cloudstack pull request: Add marvin test to verify if DomainAdmin ...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1122#discussion_r46095649 --- Diff: test/integration/component/test_tags.py --- @@ -2401,3 +2403,143 @@ def test_23_list_untagged_host_for_vm_migration(self):

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-160431637 @PaulAngus please respond to the comment by @jburwell. After that we can merge. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: Remove extraenous log dir and add catalin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1087#issuecomment-160431621 LGTM, tested on CentOS7: Logrotate is there: ``` [root@cs1 x86_64]# cat /etc/logrotate.d/cloudstack-catalina /var/log/cloudstack/manage

[GitHub] cloudstack pull request: 4.6 to master

Github user DaanHoogland closed the pull request at: https://github.com/apache/cloudstack/pull/1136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cloudstack pull request: 4.6 to master

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160418520 @bhaisaab you should not have merged #1119 as it is also in 4.6. This merge commit was wrong because of this isse and should have been fixed before merging. No

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/1134#issuecomment-160417989 Did a quick review and it looks great. One general remark; Let's keep interface as orthogonal as possible, i.e. use 'list' as the prefix for search functions a

Re: DevCloud deployment

Hi all, I found exception message in xcp-xapi.log [20151124T09:22:36.680Z|debug|devcloud|460 INET 127.0.0.1:80|host.call_plugin R:0bff3a505aba|dispatcher] Server_helpers.exec exception_handler: Got exception XENAPI_PLUGIN_FAILURE: [ non-zero exit; ; Traceback (most recent call last): File "/usr

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46092380 --- Diff: server/src/com/cloud/user/AccountManagerImpl.java --- @@ -2406,98 +2406,10 @@ public void buildACLSearchCriteria(SearchCriteria sc

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46092351 --- Diff: api/src/org/apache/cloudstack/query/QueryService.java --- @@ -131,9 +132,7 @@ ListResponse listIsos(ListIsosCmd cmd);

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46092314 --- Diff: api/src/org/apache/cloudstack/affinity/AffinityGroupService.java --- @@ -18,47 +18,36 @@ import java.util.List; +impo

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-4787 - vmware diskcontro...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1132#issuecomment-160392997 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: Reducing expunge delay and interval on de...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1135#issuecomment-160393076 FYI: @pdube I set all timers to 5 sec but that didn't result in a faster integration test run for me. --- If your project is set up for it, you can reply to th

Build failed in Jenkins: build-master-jdk18 #413

See Changes: [w.zhou] CLOUDSTACK-8958: add dedicated ips to domain (account for now) [w.zhou] CLOUDSTACK-8958: throw an exception if project account cannot be found [Rajani Karuturi] CLOUDSTACK-9081 Migration of vm across clust

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089207 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -761,6 +766,10 @@ public String toString() {

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089189 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -761,6 +766,10 @@ public String toString() {

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089183 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -419,7 +419,7 @@ public String toString() {

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user wido commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1121#discussion_r46089169 --- Diff: plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/LibvirtVMDef.java --- @@ -419,7 +419,7 @@ public String toString() {

[GitHub] cloudstack pull request: Debian/Ubuntu packaging issues

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1007 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [4.7] CLOUDSTACK-8958: add dedicated ips ...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1007#discussion_r46089078 --- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java --- @@ -3310,13 +3331,19 @@ public Vlan dedicatePublicIpRange(final Dedic

[GitHub] cloudstack pull request: CLOUDSTACK-9074: Support shared networkin...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1094#issuecomment-160391354 @miguelaferreira @wilderrodrigues Can one of you review this? Once done, I can run the integration tests again.Thanks! --- If your project is set up for it, yo

[GitHub] cloudstack pull request: 4.6 to master

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160391149 @bhaisaab The commit ID didn't change from the PR and your merge, that was fine. It was just different in 4.6 branch because the change was done combined with s

[GitHub] cloudstack pull request: Removal of DefaultUserAuthenticator empty...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.6 to master

Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160391011 @remibergsma I used the git pr tool so not sure how the commit ID changed, I merged the other PR because 4.6 merge on master chose the other change while merge con

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1121#issuecomment-160390932 Pinging @DaanHoogland @borisroman to do second review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Forgotten license added

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1137 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Forgotten license added

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1137#issuecomment-160390871 LGTM, just looked at the code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-9081 Migration of vm across cl...

Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/1118 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-9081 Migration of vm across cl...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1118#issuecomment-160390779 LGTM based on these tests (although I didn't test the actual change). ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,r

[GitHub] cloudstack pull request: [4.6] CLOUDSTACK-9083: Add disk serial to...

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1121#issuecomment-160390678 LGTM based on these tests: ``` nosetests --with-marvin --marvin-config=${marvinCfg} -s -a tags=advanced,required_hardware=true \ component/test_

[GitHub] cloudstack pull request: CLOUDSTACK-6276 Fixing affinity groups fo...

Github user remibergsma commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1134#discussion_r46088753 --- Diff: test/integration/component/test_affinity_groups_projects.py --- @@ -0,0 +1,1083 @@ +#!/usr/bin/env python +# Licensed to the Apache

[GitHub] cloudstack pull request: 4.6 to master

Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/1136#issuecomment-160390613 @bhaisaab The problem with your approach, to be honest, is that the commit ID changed. As this was a bit of a special case it may not be a problem. General spea