Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-149793103
Daan, I just edited the commit message to describe the issue.
This two issue looks small, but the functions are called by many other
functions. hence it may h
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149792585
Hi @karuturi ,
I did not change the code as I thought the work needed was more tests
related. I had a better look at PR #930 and will address your co
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149791585
@michaelandersen
Could you give some details on how you executed the tests? It looks like
env issues.
Did you...
* checked out the
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/958#issuecomment-149790526
I built ACS and the RPMs based on this PR, with 4 threads - as suggested in
@miguelaferreira's comment. All worked fine!
LGTM :+1:
Cheers,
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149790401
I tested this api just now,
It works fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. I
Github user karuturi commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149782673
The code concerns(incase of stop-start on a slow network and the changes of
outer while waiting infinitely) with it were not addressed.
I am ok with merging this
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42582358
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaBalanceDaoImpl.java ---
@@ -0,0 +1,199 @@
+//Licensed to the Apache Softw
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42581420
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42581161
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42581119
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/850#issuecomment-149744151
Do you guys really think that is a good idea to log exceptions in a test
case?
If the case is just to ignore them, it could be done without logging.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/937#issuecomment-149743155
Nice work
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-149742333
@ DaanHoogland,
I ran the tests from my Windows environments, after I did some work arounds
everything started passing the tests. The fixes I did I cre
Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/932#discussion_r42564487
--- Diff:
core/src/org/apache/cloudstack/agent/transport/AnswerArrayTypeAdaptor.java ---
@@ -0,0 +1,33 @@
+package org.apache.cloudstack.age
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149718198
It works fine for me:
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s -a
tags=advanced,required_hardware=false smoke/test_privategw_acl.p
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149706996
from the mgt server log:
WARN [c.c.a.d.ParamGenericValidationWorker]
(709693495@qtp-265638379-0:ctx-dfba94e8 ctx-8090674b ctx-c8da340d) Received
unknown
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149706469
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP
connection (1): cs2.cloud.lan
requests.packages.urllib3.connectionpool: DEBUG: "GET
/cl
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149706192
@remibergsma @wilderrodrigues LGTM'ed this one too soon, was a bit too
enthusiastic. sorry about that. Ran the test just now, but it's failing!
nos
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42553475
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software Foundatio
Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42552096
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software Foundatio
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/952#issuecomment-149694171
@remibergsma: why another run? Jenkins (and travis) is green
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user ustcweizhou commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149691403
why not add 'uuid' column in guest_os_type table?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/890#issuecomment-149677795
@borisroman,
Is this PR intended to fix the ordering of the response of
listGuestOsMappingCommand?
I did not see where you changed the ordering on
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/958#issuecomment-149610350
@miguelaferreira , yes this is one of the obstakels I encountered the last
few days.
LGTM, will test if I get a test env working.
Another one is the marv
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/959#issuecomment-149588601
Ping @karuturi @bvbharat @borisroman @wido @remibergsma @miguelaferreira
@DaanHoogland
Test Environment:
* Management Server + MySQL on Cen
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/959
CLOUDSTACK-8933 SSVm and CPVM do not survive a reboot from API
This closes PR #930 as well.
I Rebased @bvbharat's PR with latest Master and tested the SSVM/CPVM and
the routers:
Github user nvazquez commented on the pull request:
https://github.com/apache/cloudstack/pull/935#issuecomment-149582907
@miguelaferreira @remibergsma
Thanks again for your help! As you suggested I rebased master branch. I
also added a more detailed description of the patch on th
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149573159
@remibergsma @michaelandersen
I added the wrong ACS issue to the PR title and the commit. I already
edited the title, will now amend the commit and
Github user thinktwo commented on the pull request:
https://github.com/apache/cloudstack/pull/951#issuecomment-149560916
@remibergsma Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user miguelaferreira commented on the pull request:
https://github.com/apache/cloudstack/pull/958#issuecomment-149534258
ping @DaanHoogland this is the error you were asking me about right?
---
If your project is set up for it, you can reply to this email and have your
reply ap
GitHub user miguelaferreira opened a pull request:
https://github.com/apache/cloudstack/pull/958
cloud-apidoc module depends on cloud-client-ui
When building the cloud-apidoc module a script called `./build-apidoc.sh`
is executed with an argument that points to
`../../client/target
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-149531857
@wido Will do!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
On 19/10/15 23:10, ilya wrote:
Ronald,
Please see response in-line...
And you too :)
On 10/19/15 2:18 AM, Ronald van Zantvoort wrote:
On 16/10/15 00:21, ilya wrote:
I noticed several attempts to address the issue with KVM HA in Jira and
Dev ML. As we all know, there are many ways to solve
Github user wido commented on the pull request:
https://github.com/apache/cloudstack/pull/932#issuecomment-149531398
So, this PR is hard to test. For now I've verified that it compiles on my
Ubuntu desktop with Java 8 and all the Unit Tests succeed, so that's good.
Asking @bor
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/933#issuecomment-149515675
Although @michaelandersen did not change any router code, I ran some more
tests just to testify the rebase. It all looks good!
LGTM :+1:
Te
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/952#issuecomment-149508039
Please have a look at Jenkins and/or force push to trigger another run.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149506439
@michaelandersen Can you please let us know what you tested / reviewed?
Thanks!
---
If your project is set up for it, you can reply to this email and have your
Github user michaelandersen commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149500308
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/955#issuecomment-149494651
Hi @SudharmaJain,
Any test to cover your changes? In case no, how should we test this PR?
Which steps to follow?
Cheers,
Wilder
---
If
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/952#issuecomment-149487696
Run the tests and it LGTM :+1:
```
Test Remote Access VPN in VPC ... === TestName: test_vpc_remote_access_vpn
| Status : SUCCESS ===
ok
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149486636
Thanks, @borisroman !
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as w
that gives me a warm fuzzy feeling ;)
On Tue, Oct 20, 2015 at 11:04 AM, Boris Schrijver
wrote:
> Hi Dahn,
>
> I must admit, I ran into it a couple weeks ago. No idea how I fixed it...
>
> On October 20, 2015 at 10:42 AM Daan Hoogland
> wrote:
>
>
> H devs,
>
> During a build that works for coll
Github user borisroman commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149482385
@wilderrodrigues Ran tests. OK.
```
=== TestName: test_privategw_acl | Status : SUCCESS ===
ok
---
H devs,
During a build that works for colleagues on a clean virtual machine I get
an error on the marvin generated sources part. The error is clear about
what happened but the cause is a mistery. Can anyone point me to the right
direction?
thanks,
[INFO]
[INFO] --- exec-maven-plugin:1.2.1:exec (
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/957#issuecomment-149478991
Ping @remibergsma @michaelandersen @miguelaferreira @karuturi @DaanHoogland
@wido
Test results:
```
test_privategw_acl (integration.smo
GitHub user wilderrodrigues opened a pull request:
https://github.com/apache/cloudstack/pull/957
CLOUDSTACK-8933 - Improve the current test_privategw_acls.py
- Read cofiguration from the zone: template id; template id; and domain
id
- Create Account and VPC Offering
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/933#issuecomment-149475560
First round of tests:
```
Test to verify access to loadbalancer haproxy admin stats page ... ===
TestName: test02_internallb_haproxy_stats_on_all
Github user abhinandanprateek commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42466343
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/dao/QuotaUsageDaoImpl.java ---
@@ -0,0 +1,78 @@
+//Licensed to the Apache Software
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/954#issuecomment-149469471
Wei, this code looks sensible but can you ad a small explenation as it is
actually two small fixes. It is one a the test in a bunch PRs to me.
The jenkins fa
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149458795
Hi @bvbharat , @karuturi and @remibergsma
I will push a new PR based on this one, with a rebase on latest master and
test reports.
Cheers,
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/933#issuecomment-149457679
Thanks for the rebase, @michaelandersen
I will test this one as well!
---
If your project is set up for it, you can reply to this email and have yo
Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/952#issuecomment-149457564
Testing this one now!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
Github user bvbharatk commented on the pull request:
https://github.com/apache/cloudstack/pull/930#issuecomment-149456401
@karuturi @wilderrodrigues
Hi guys,
Thanks for taking this up and finalising. It would have taken at lest 4
days to start working on this again. appre
53 matches
Mail list logo
