Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/768#discussion_r42553475
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaConfig.java ---
@@ -0,0 +1,53 @@
+//Licensed to the Apache Software Foundation (ASF) under one
+//or more contributor license agreements. See the NOTICE file
+//distributed with this work for additional information
+//regarding copyright ownership. The ASF licenses this file
+//to you under the Apache License, Version 2.0 (the
+//"License"); you may not use this file except in compliance
+//with the License. You may obtain a copy of the License at
+//
+//http://www.apache.org/licenses/LICENSE-2.0
+//
+//Unless required by applicable law or agreed to in writing,
+//software distributed under the License is distributed on an
+//"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+//KIND, either express or implied. See the License for the
+//specific language governing permissions and limitations
+//under the License.
+
+package org.apache.cloudstack.quota.constant;
+
+import org.apache.cloudstack.framework.config.ConfigKey;
+
+public interface QuotaConfig {
+
+ public static final ConfigKey<Boolean> QuotaPluginEnabled = new
ConfigKey<Boolean>("Advanced", Boolean.class, "quota.enable.service", "false",
"Indicates whether Quota plugin is enabled or not",
+ true);
+
+ public static final ConfigKey<String> QuotaEnableEnforcement = new
ConfigKey<String>("Advanced", String.class, "quota.enable.enforcement", "false",
+ "Enable the usage quota enforcement, i.e. on true when
exceeding quota the respective account will be locked.", true);
+
+ public static final ConfigKey<String> QuotaCurrencySymbol = new
ConfigKey<String>("Advanced", String.class, "quota.currency.symbol", "R", "The
symbol for the currency in use to measure usage.",
+ true);
+
+ public static final ConfigKey<String> QuotaSmtpHost = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.host", "", "Quota
SMTP host for quota related emails", true);
+
+ public static final ConfigKey<String> QuotaSmtpTimeout = new
ConfigKey<String>("Advanced", String.class,
"quota.usage.smtp.connection.timeout", "60",
+ "Quota SMTP server connection timeout duration", true);
+
+ public static final ConfigKey<String> QuotaSmtpUser = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.user", "", "Quota
SMTP server username", true);
+
+ public static final ConfigKey<String> QuotaSmtpPassword = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.password", "",
"Quota SMTP server password", true);
+
+ public static final ConfigKey<String> QuotaSmtpPort = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.port", "", "Quota
SMTP port", true);
+
+ public static final ConfigKey<String> QuotaSmtpAuthType = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.useAuth", "",
+ "If true, use secure SMTP authentication when sending
emails.", true);
+
+ public static final ConfigKey<String> QuotaSmtpSender = new
ConfigKey<String>("Advanced", String.class, "quota.usage.smtp.sender", "",
+ "Sender of quota alert email (will be in the From header of
the email)", true);
+
--- End diff --
The
(specification)[https://cwiki.apache.org/confluence/display/CLOUDSTACK/Quota+Service+-+FS]
states that the following configuration options will be provided, but they are
not defined in this list:
* quota.period.type
* quota.period.config
* quota.activity.generate
* quota.email.outgoing.record
* quota.limit.critical
* quota.limit.incremental
Also, why have the alert.smtp.* options been replicated for quota
notifications? It seems unlikely that a user would have a different mail
infrastructures for alerts and quota notifications.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
