[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-27 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-143647389 Rebased the PR to current master. Regarding unit tests, method doesn't have input or output as a unit. It has output only in terms of DB updation so for m

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-09-27 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143645025 @remibergsma Rebased against the current master. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-27 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-143644210 @remibergsma Rebased against the master. Please have a look. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Blameless post mortem

2015-09-27 Thread Sanjeev N
I have a concern here. Some of us are actively involved in reviewing the PRs related to marvin tests(Enhancing existing tests/Adding new tests). If we have to test a PR it requires an environment to be created with actual resources and this is going to take lot of time. Some of the tests can run on

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143639563 LGTM on the basis of code. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

Re: Zone in RegisterTemplateCmd API

2015-09-27 Thread Rajani Karuturi
so many if-else statements :) I would prefer making zoneid optional and defaulting it to -1. simple and clear. ~Rajani On 26-Sep-2015, at 1:34 am, Boris Schrijver wrote: > Hi Patrick, > > We're using S3 and are facing the same issues. > > This would indeed be a very good idea. Though I

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-09-27 Thread pdion891
Github user pdion891 commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-143611856 @remibergsma I haven't test this PR yet on master. A previous fix has been pushed in the past to fix s2svpn in project but didn't completely fixed it. With this PR

[GitHub] cloudstack pull request: Fix dockerbuild because hardcoded filenam...

2015-09-27 Thread pdion891
GitHub user pdion891 opened a pull request: https://github.com/apache/cloudstack/pull/893 Fix dockerbuild because hardcoded filename for marvin This fix docker simulator build of latest 4.5.x. This PR only go in 4.5 branch. Thanks You can merge this pull request in

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143591694 @remibergsma done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fe

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

2015-09-27 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/890#issuecomment-143591008 @remibergsma Done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cloudstack pull request: [4.6]CLOUDSTACK-8912: Fixed listGuestOsMa...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/890#issuecomment-143590703 @borisroman Can you rebase against current master? Then we can run some tests. Thanks! --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-8728: Testcase to Verify if VR...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/684#issuecomment-143590546 @pritisarap12 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cloudstack pull request: CLOUDSTACK-8827: Move the VM snapshots st...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/793#issuecomment-143590468 @anshul1886 Any update on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/799#issuecomment-143590376 @sudhansu7 Any update on this? Please rebase against current master so we can run the tests. Also, squash teh commits (4 of them have the same title) int

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-143590314 @kansal Ok, please rebase against current master so we can run the tests against this branch. --- If your project is set up for it, you can reply to this email

[GitHub] cloudstack pull request: CLOUDSTACK-8847: ListServiceOfferings is ...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/823#issuecomment-143590275 @nitin-maharana Thanks! Can you please rebase against current master? How did you test this? --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: Fixed: Error given when creating VPN user...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/826#issuecomment-143590180 @kansal Thanks! Can you please rebase against current master? Then we can run the tests. How did you test this? --- If your project is set up for it, y

[GitHub] cloudstack pull request: CLOUDSTACK-8906: /var/log/cloud/ doesn't ...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/883#issuecomment-143590005 @SudharmaJain Can you please rebase against current master? Then we can run the tests. --- If your project is set up for it, you can reply to this email and hav

[GitHub] cloudstack pull request: CLOUDSTACK-8860: improve error messages i...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/864#issuecomment-143589960 @bvbharatk Thanks! Can you please rebase against current master? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cloudstack pull request: CLOUDSTACK-8793 Enable s2s VPN connection...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/879#issuecomment-143589882 @pdube Thanks! Can you please rebase against current master? Then we can run the tests to verify. --- If your project is set up for it, you can reply to this em

[GitHub] cloudstack pull request: CLOUDSTACK-8751 minimise downtime of netw...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/866#issuecomment-143589709 @bvbharatk Thanks! Can you please rebase against current master? If you do, we can run the tests. Did you run the BVT tests against this branch? Please p

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143589352 @resmo Thanks for the fix! Could you rebase against current master please? Then we'll be able to run some tests against this branch. --- If your project is set

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-143589309 @bhaisaab Yes we can consider including it. After rebasing this PR we can run the BVT tests against it to see if there are any issues. We need to be careful thou

[GitHub] cloudstack pull request: Strongswan vpn feature

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/872#issuecomment-143589238 @jayapalu Can you please rebase against current master? Did you run the BVT tests against this branch? If so, please post output. I'd recommend doing tha

[GitHub] cloudstack pull request: Jira: CLOUDSTACK-8812 / CentOS 7

2015-09-27 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/888#issuecomment-143589136 Hi @svenvogel Thanks! Can you please squash the 2 commits into 1 and also rebase with current master (make sure you have just one commit)? Then we'll be able to

[GitHub] cloudstack pull request: CLOUDSTACK-8910: The reserved_capacity fi...

2015-09-27 Thread SudharmaJain
GitHub user SudharmaJain opened a pull request: https://github.com/apache/cloudstack/pull/892 CLOUDSTACK-8910: The reserved_capacity field increases suddenly after… … a vmware host failure In case of vmware host failure, all the VMs including stopped VMs migrate to the

Re: Zone in RegisterTemplateCmd API

2015-09-27 Thread Patrick Dube
Hey Boris, I think that is a good alternative. It would make the API a bit more explicit, and improve the support for cross zone templates. I will log it as an improvement in JIRA. Regards, Patrick On Fri, Sep 25, 2015 at 4:05 PM Boris Schrijver wrote: > Hi Patrick, > > We're using S3 and are

Re: [j.bac.o] Jenkins jobs cleanup

2015-09-27 Thread Boris Schrijver
Hi Pierre-Luc, I've no objections. Besides the jobs for 4.3 and 4.4 I think there is need for some more cleanup on jenkins.buildacloud.org. We will need to index all current build jobs and reason or vote if the job is still wanted or necessary. I'm seeing a lot of jobs failing or not even running

Re: [j.bac.o] Jenkins jobs cleanup

2015-09-27 Thread Remi Bergsma
4.3 remove is fine with me. Sent from my iPhone > On 27 Sep 2015, at 16:39, Pierre-Luc Dion wrote: > > Hi, > > We recently ran out of space on jenkins master of j.bac.o [1]. Does anyone > would object if we removed all jobs for 4.3 builds ? I did some build jobs > for 4.6, I'll remove them as

[j.bac.o] Jenkins jobs cleanup

2015-09-27 Thread Pierre-Luc Dion
Hi, We recently ran out of space on jenkins master of j.bac.o [1]. Does anyone would object if we removed all jobs for 4.3 builds ? I did some build jobs for 4.6, I'll remove them as it look like we are using master for 4.6 builds for now. Any other suggestions? Thanks, [1] http://markmail.org/

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143549250 @karuturi @anshul1886 So, I 'll checked the handling again and what I see is, it will not work with this one line change only: ~~~ Date vmStateUpdateTime

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/836 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8905: Fixed hooking egress rul...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/881 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: Configured dnsmasq to listen on all inter...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/870 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8864: Not able to add TCP port...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/851 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8881: Fixed Static and PF conf...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/887 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/842 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8891: Fixed default iptables r...

2015-09-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143545153 Hi @remibergsma, @karuturi and @borisroman , Finally got most of the ACS working as it was 4 weeks ago! Below the tests I executed manually and via M

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143545134 Hi @wilderrodrigues @remibergsma, I've tested: component/test_vpc_routers.py component/test_vpc_offerings.py smoke/test_routers.py smoke/te

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143544132 @karuturi I understand what @anshul1886 trying to point out: the powerState should already be updated to the new state `powerReportMissing`. And because it ch

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143543608 Yes, @rajan! It will be stable today! I'm running the last test as we speak and will add the complete test report on the PR, so everybody can see wha

[GitHub] cloudstack pull request: [BLOCKER] Combined PRs that fix VR issues

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/887#issuecomment-143543557 Thanks for all the debugging and testing @remibergsma and @wilderrodrigues looking forward to see a stable master once again.. --- If your project is set up f

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143543503 @anshul1886 without the new method, how do you ensure that PowerStateUpdateTime is up to date for the vm? It may be a very old value and can be a false alarm(same i

[GitHub] cloudstack pull request: CLOUDSTACK-8848: ensure power state is up...

2015-09-27 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/885#issuecomment-143542706 code LGTM. I am facing some issues with my devcloud4 setup and hence couldnt run tests. --- If your project is set up for it, you can reply to this email and have