Github user wilderrodrigues commented on the pull request:

    https://github.com/apache/cloudstack/pull/887#issuecomment-143545153
  
    Hi @remibergsma, @karuturi and @borisroman ,
    
    Finally got most of the ACS working as it was 4 weeks ago! Below the tests 
I executed manually and via Marvin. It all looks fine!
    
    However, there is still 1 thing that nobody noticed - because they don't 
test - which concerns the Redundant VPC routers: we cannot ssh into VM in a 
rVPC, unfortunately!
    
    @isoutham wrote a nice test for that (component/test_vpc_redundnat.py) 
which was working really fine. Unfortunately I tried it now and also some 
manual tests, but the rVPC no longer works.
    
    I will create an issue for that and try to get it fixed.
    
    I would like to suggest that for any router related changes the following 
tests are *always* executed:
    
    * component/test_vpc_redundant.py  - hardware=true
      * Feature currently broken.
    * component/test_routers_iptables_default_policy.py  - hardware=true
    * component/test_vpc_router_nics.py - hardware=true
    * smoke/test_network_acl.py - hardware=true
    * component/test_vpc_offerings.py - hardware=false
    * component/test_vpc_routers.py - hardware=false
    * smoke/test_routers.py - hardware=false
    * smoke/test_privategw_acl.py - hardware=false
    * smoke/test_reset_vm_on_reboot.py - hardware=false
    * smoke/test_vm_life_cycle.py - hardware=false
    * smoke/test_vpc_vpn.py - hardware=false
    * smoke/test_service_offerings.py - hardware=false
    
    The PR 887 LATM - Look AWESOME to Me!
    
    Cheers,
    Wilder 
    
    P.S.: I already executed all tests below, but I will continue for a bit 
more and will edit the PR comment later. Please, go ahead and merge it!
    
    * Environment
      * KVM on CentOS 7.1
      * Management Server on CentOS 7.1
      * Agent and Common packages built from source 
    
    *Manual tests*
    
    - Isolated network / VM / egress / FW / PF
    ````
    [root@cs1 integration]# ssh root@192.168.23.5
    The authenticity of host '192.168.23.5 (192.168.23.5)' can't be established.
    ECDSA key fingerprint is 52:b5:5e:21:78:d8:89:fc:95:1c:68:02:55:01:44:b7.
    Are you sure you want to continue connecting (yes/no)? yes
    Warning: Permanently added '192.168.23.5' (ECDSA) to the list of known 
hosts.
    root@192.168.23.5's password: 
    # ping 8.8.8.8
    PING 8.8.8.8 (8.8.8.8): 56 data bytes
    64 bytes from 8.8.8.8: seq=0 ttl=47 time=10.619 ms
    64 bytes from 8.8.8.8: seq=1 ttl=47 time=11.346 ms
    64 bytes from 8.8.8.8: seq=2 ttl=47 time=11.934 ms
    ^C
    --- 8.8.8.8 ping statistics ---
    3 packets transmitted, 3 packets received, 0% packet loss
    round-trip min/avg/max = 10.619/11.299/11.934 ms
    # 
    
    ```
    - VPC network / Tier / ACL / VM / PubIP / PF
    [wrodrigues@mct-wrodrigues-g9 ~]$ ssh root@192.168.23.6
    The authenticity of host '192.168.23.6 (192.168.23.6)' can't be established.
    ECDSA key fingerprint is bf:bb:32:27:b4:91:38:38:3e:dd:8f:e3:ad:9b:9f:26.
    Are you sure you want to continue connecting (yes/no)? yes
    Warning: Permanently added '192.168.23.6' (ECDSA) to the list of known 
hosts.
    root@192.168.23.6's password: 
    # ls -lart
    total 9
    -rw-r--r--    1 root     root            78 Dec  1  2014 .bash_profile
    -rw-r--r--    1 root     root           175 Dec  1  2014 .bash_logout
    -rw-r--r--    1 root     root             0 Dec  1  2014 .bash_history
    drwxr-xr-x   19 root     root          1024 Sep 27 00:06 ..
    -rw-------    1 root     root             9 Sep 27 00:10 .ash_history
    drwx------    2 root     root          1024 Sep 27 00:10 .
    # ping 8.8.8.8
    PING 8.8.8.8 (8.8.8.8): 56 data bytes
    64 bytes from 8.8.8.8: seq=0 ttl=47 time=10.768 ms
    64 bytes from 8.8.8.8: seq=1 ttl=47 time=11.036 ms
    64 bytes from 8.8.8.8: seq=2 ttl=47 time=13.196 ms
    ^C
    --- 8.8.8.8 ping statistics ---
    3 packets transmitted, 3 packets received, 0% packet loss
    round-trip min/avg/max = 10.768/11.666/13.196 ms
    
    "Marvin tests*
    
    ```
    Test router internal advanced zone ... === TestName: 
test_02_router_internal_adv | Status : SUCCESS ===
    ok
    Test restart network ... === TestName: test_03_restart_network_cleanup | 
Status : SUCCESS ===
    ok
    Test router basic setup ... === TestName: test_05_router_basic | Status : 
SUCCESS ===
    ok
    Test router advanced setup ... === TestName: test_06_router_advanced | 
Status : SUCCESS ===
    ok
    Test stop router ... === TestName: test_07_stop_router | Status : SUCCESS 
===
    ok
    Test start router ... === TestName: test_08_start_router | Status : SUCCESS 
===
    ok
    Test reboot router ... === TestName: test_09_reboot_router | Status : 
SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 7 tests in 615.524s
    
    OK
    /tmp//MarvinLogs/test_routers_PXXUZO/results.txt (END)
    
    
    Test start/stop of router after addition of one guest network ... === 
TestName: test_01_start_stop_router_after_addition_of_one_guest_network | 
Status : SUCCESS ===
    ok
    Test reboot of router after addition of one guest network ... === TestName: 
test_02_reboot_router_after_addition_of_one_guest_network | Status : SUCCESS ===
    ok
    Test to change service offering of router after addition of one guest 
network ... === TestName: 
test_04_chg_srv_off_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
    ok
    Test destroy of router after addition of one guest network ... === 
TestName: test_05_destroy_router_after_addition_of_one_guest_network | Status : 
SUCCESS ===
    ok
    Test to stop and start router after creation of VPC ... === TestName: 
test_01_stop_start_router_after_creating_vpc | Status : SUCCESS ===
    ok
    Test to reboot the router after creating a VPC ... === TestName: 
test_02_reboot_router_after_creating_vpc | Status : SUCCESS ===
    ok
    Tests to change service offering of the Router after ... === TestName: 
test_04_change_service_offerring_vpc | Status : SUCCESS ===
    ok
    Test to destroy the router after creating a VPC ... === TestName: 
test_05_destroy_router_after_creating_vpc | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 8 tests in 1474.059s
    
    OK
    /tmp//MarvinLogs/test_vpc_routers_QZKIAB/results.txt (END)
    
    
    Test VPN in VPC ... === TestName: test_vpc_remote_access_vpn | Status : 
SUCCESS ===
    ok
    Test VPN in VPC ... === TestName: test_vpc_site2site_vpn | Status : SUCCESS 
===
    ok
    
    ----------------------------------------------------------------------
    Ran 2 tests in 936.917s
    
    OK
    /tmp//MarvinLogs/test_vpc_vpn_MHQ125/results.txt (END)
    
    
    VPN remote access user limit tests ... === TestName: test_01_VPN_user_limit 
| Status : SUCCESS ===
    ok
    Test create VPN when L2TP port in use ... === TestName: 
test_02_use_vpn_port | Status : SUCCESS ===
    ok
    Test create NAT rule when VPN when L2TP enabled ... === TestName: 
test_03_enable_vpn_use_port | Status : SUCCESS ===
    ok
    Test add new users to existing VPN ... === TestName: test_04_add_new_users 
| Status : SUCCESS ===
    ok
    Test add duplicate user to existing VPN ... === TestName: 
test_05_add_duplicate_user | Status : SUCCESS ===
    ok
    Test as global admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_06_add_VPN_user_global_admin | Status : SUCCESS ===
    ok
    Test as domain admin, add a new VPN user to an existing VPN entry ... === 
TestName: test_07_add_VPN_user_domain_admin | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 7 tests in 2370.893s
    
    OK
    /tmp//MarvinLogs/test_vpn_users_BPZS7G/results.txt (END)
    
    
    test_privategw_acl (integration.smoke.test_privategw_acl.TestPrivateGwACL) 
... === TestName: test_privategw_acl | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 276.807s
    
    OK
    /tmp//MarvinLogs/test_privategw_acl_E1SFE8/results.txt (END)
    
    
    Test network ACL lists and items in VPC ... === TestName: test_network_acl 
| Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 347.838s
    
    OK
    /tmp//MarvinLogs/test_network_acl_GRU2PJ/results.txt (END)
    
    
    Create a vpc with two networks with two vms in each network ... === 
TestName: test_01_VPC_nics_after_destroy | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 1 test in 1246.437s
    
    OK
    /tmp//MarvinLogs/test_vpc_router_nics_W2BCYT/results.txt (END)
    
    
    Test to create service offering ... === TestName: 
test_01_create_service_offering | Status : SUCCESS ===
    ok
    Test to update existing service offering ... === TestName: 
test_02_edit_service_offering | Status : SUCCESS ===
    ok
    Test to delete service offering ... === TestName: 
test_03_delete_service_offering | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 3 tests in 463.478s
    
    OK
    /tmp//MarvinLogs/test_service_offerings_PYXAFK/results.txt (END)
    
    
    Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName: 
test_02_routervm_iptables_policies | Status : SUCCESS ===
    ok
    Test iptables default INPUT/FORWARD policies on VPC router ... === 
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
    ok
    
    ----------------------------------------------------------------------
    Ran 2 tests in 755.749s
    
    OK
    /tmp//MarvinLogs/test_routers_iptables_default_policy_PG0N56/results.txt 
(END)
    
    
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to