[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-16 Thread kansal
Github user kansal commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140984295 @remibergsma I tested it on my local setup and worked fine. Maybe you can also check to make sure I haven't missed anything. --- If your project is set up for it, yo

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/845#issuecomment-140983817 @borisroman Please ping me if this PR is ready to be tested. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140983520 @resmo You're right and I wasn't clear enough I guess. Because I think the 'PowerReportMissing' comes from the VM on the hypervisor that you are migrating _to_,

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-16 Thread borisroman
Github user borisroman commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/845#discussion_r39714178 --- Diff: engine/schema/src/com/cloud/network/dao/IPAddressDaoImpl.java --- @@ -282,6 +289,14 @@ public IPAddressVO findByVmIp(String vmIp) { }

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-16 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-140915157 @ DaanHoogland, I understand you, I just commented that to show to @nitin-maharana that “we” (I) understand that writing a test case to a method like t

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-140910285 @rafaelweingartner we keep growing methods and not writing unit tests. Thus our code base is worsening in quality or at least in maintainability. However trivia

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread resmo
Github user resmo commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140879864 @remibergsma does not look related to me, the keyword seems to be PowerReportMissing. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cloudstack pull request: [4.6][BLOCKER]CLOUDSTACK-8763: Resolved P...

2015-09-16 Thread borisroman
GitHub user borisroman opened a pull request: https://github.com/apache/cloudstack/pull/845 [4.6][BLOCKER]CLOUDSTACK-8763: Resolved POD/ZONE deletion failure. Instead of having both checkIfPodIsDeletable() and checkIfZoneIsDeletable have there own SQL query, I've refactored them so

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140867296 @DaanHoogland @resmo Not sure if this is related, but in 4.4 (and running XenServer/KVM probably any hypervisor) I see sometimes alerts when a router is live-mig

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-16 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/790#issuecomment-140866855 Both are valid solutions for the very same problem, we would have to choose between one of them. @nitin-maharana said that he tested with the other solutio

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/790#issuecomment-140862396 @nitin-maharana I see also PR #775, can this be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140858308 Did anyone validate the functionality or do you want me to do that? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140842317 @wido Yep, works fine now! ``` + exit 0 RPM Build Done ``` Here they are: ``` [root@cs4 packaging]# ls -la ../dist/rpmbu

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-16 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/844#issuecomment-140833060 Apache Jenkins build reports 5 failing tests (https://builds.apache.org/job/cloudstack-pull-analysis/575/testReport/) https://cloud.githubuserconten

[GitHub] cloudstack pull request: CLOUDSTACK-8805: Domains become inactive ...

2015-09-16 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/775#issuecomment-140824594 @DaanHoogland and @nitin-maharana, I was thinking about this PR. I do not think that it is easy to write unit test for this. First the method is hu

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140791892 @koushik-das could you comment, please. Regarding power off and no power state equal in some case might make sense but in general it certainly doesn't as we hav

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140777872 @bhaisaab Updated the PR. Tests run fine now. Thanks for your time! --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cloudstack pull request: CLOUDSTACK-8872: Replaced all occurences ...

2015-09-16 Thread borisroman
Github user borisroman commented on the pull request: https://github.com/apache/cloudstack/pull/832#issuecomment-140758129 Hi @wilderrodrigues Thank you for your extensive comment. I've read through the thread you mentioned and added the required Jira ticket and PR descriptio

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140746033 @remibergsma Thank you for testing. Stupid mistake indeed. That should be fixed now. I checked on a CentOS 7 machine: ``` + exit 0 RPM Build Do

[GitHub] cloudstack pull request: CLOUDSTACK-8855 Improve Error Message for...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/837#issuecomment-140745806 @bvbharatk Any advise on how to test this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/839#issuecomment-140743582 @karuturi Please have a look, seems like a small bug fix that can go into 4.6 --- If your project is set up for it, you can reply to this email and have your re

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/839#issuecomment-140743242 - Deployed Advanced zone with two KVM clusters - Created redundant router offering - Created network - Created VM in network Two routers were

Usage service not working in CS 4.3.1

2015-09-16 Thread anil lakineni
Dears, >From past three days, I have been facing issues with usage service in CS4.3.1 with Xen host 6.2.0 In the CS mgmt server when check with usage service status, it is saying running. But usage records are not generating in the cloud_usage In the management-server.log I am getting below erro

[GitHub] cloudstack pull request: CLOUDSTACK-7985: assignVM in Advanced zon...

2015-09-16 Thread ustcweizhou
GitHub user ustcweizhou opened a pull request: https://github.com/apache/cloudstack/pull/844 CLOUDSTACK-7985: assignVM in Advanced zone with Security Groups This commit contains the following changes: (1) implementation of assignVM in Advanced zone with Security Groups (2) ke

[GitHub] cloudstack pull request: CLOUDSTACK-8854: Apple Mac OS/X VM get cr...

2015-09-16 Thread sureshanaparti
Github user sureshanaparti commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/828#discussion_r39624157 --- Diff: vmware-base/src/com/cloud/hypervisor/vmware/util/VmwareHelper.java --- @@ -598,6 +601,19 @@ public static void setBasicVmConfig(VirtualM

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-16 Thread rafaelweingartner
Github user rafaelweingartner closed the pull request at: https://github.com/apache/cloudstack/pull/778 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140729493 Also, what if the protocol version is greater than 6; what's the idea behind using protocol version to determine which data-structure type to use? --- If your proj

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-16 Thread rafaelweingartner
Github user rafaelweingartner commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140729409 Dear @wilderrodrigues, As I said I get your point and the moment that you guys are on closing a version. A mistake was made, the moment I noticed

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140729245 @jayapalu isn't nethash type not supported on XenServer 6.2? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-16 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140727278 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread jayapalu
Github user jayapalu commented on the pull request: https://github.com/apache/cloudstack/pull/843#issuecomment-140724480 @bhaisaab can you please review this PR --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] cloudstack pull request: Security group ingress/egress issues with...

2015-09-16 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/843 Security group ingress/egress issues with xenserver 6.2 There is issue with the xenserver 6.2 ipset type nethash. Fixed it by adding nethash for ipset version 6 which is xenserver 6.5. For ipse

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140719214 @wido No luck yet: ``` error: File not found: /data/git/cs2/cloudstack/dist/rpmbuild/BUILDROOT/cloudstack-4.6.0-SNAPSHOT.el7.centos.x86_64/usr/sbin/c

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-140715229 mm.. I really think we should change the way we generate password both for uservms and systemvms. May be would could track that separately and for now increase the

3 weeks away from CCC Dublin

2015-09-16 Thread Sebastien Goasguen
Hi everyone, We are 3 weeks away to CCC Dublin. Many thanks to our sponsors: -Citrix -Cloud Foundry -Nuage Networks -Cloudian -ShapeBlue -Soldfire -iKoula -LPI-Japan -PCextreme I look forward to seeing you all there, don’t forget to register you still have time. Cheers, -Sebastien

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rene Moser
On 09/16/2015 11:46 AM, Anshul Gangwar wrote: > It’s not difficult to find a good grace period. It will simply depend on your > Hypervisor settings how it is configured for HA. You can easily figure out > for how much time there will be no VM on any Host from your settings and > simply put 2-3

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-140711369 I would avoid adding one more global setting; maybe what we can do is add like a static multiplier to the global setting value "vm.password.length" and use that as

Build failed in Jenkins: build-master-slowbuild #2320

2015-09-16 Thread jenkins
See Changes: [sureshkumar.anaparti] CLOUDSTACK-8820: Showing error when try to add advance zone using VMWare ESXi 6.0 host [wido] CLOUDSTACK-8625: Systemd profile for CloudStack Agent [wido] CLOUDSTACK-8443: Install the s

Build failed in Jenkins: build-systemvm-master #626

2015-09-16 Thread jenkins
See Changes: [sureshkumar.anaparti] CLOUDSTACK-8820: Showing error when try to add advance zone using VMWare ESXi 6.0 host [wido] CLOUDSTACK-8625: Systemd profile for CloudStack Agent [wido] CLOUDSTACK-8443: Install the sys

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Anshul Gangwar
I don’t think there was any discussion around this. Kelven have made fixes around VMSync. So to find details look into FS https://cwiki.apache.org/confluence/display/CLOUDSTACK/FS+-+VMSync+improvement . Regards, Anshul On 16-Sep-2015, at 3:32 PM, Daan Hoogland mailto:daan.hoogl...@gmail.com>>

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi
Github user karuturi commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-140696212 should we add another global setting for systemvm password length (like vm.password.length for uservms) and use it to generate systemvm passwords? --- If your proj

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Daan Hoogland
On Wed, Sep 16, 2015 at 11:46 AM, Anshul Gangwar wrote: > It’s not difficult to find a good grace period. It will simply depend on > your Hypervisor settings how it is configured for HA. You can easily figure > out for how much time there will be no VM on any Host from your settings > and simply

[GitHub] cloudstack pull request: CLOUDSTACK-8843: Fixed issue in default i...

2015-09-16 Thread jayapalu
GitHub user jayapalu opened a pull request: https://github.com/apache/cloudstack/pull/842 CLOUDSTACK-8843: Fixed issue in default iptables rules on shared network VR On basic zone share network VR default iptables rules are not applied correctly. Due to this ssh to VR got failed.

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Anshul Gangwar
It’s not difficult to find a good grace period. It will simply depend on your Hypervisor settings how it is configured for HA. You can easily figure out for how much time there will be no VM on any Host from your settings and simply put 2-3 times of that period as grace period. It seems you hav

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-16 Thread SudharmaJain
Github user SudharmaJain commented on the pull request: https://github.com/apache/cloudstack/pull/836#issuecomment-140687549 @bhaisaab, using service conntrackd status don't provide the status and always gives the usage information for conntrackd. So i have added the changes by starti

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/841#issuecomment-140684521 I think the PasswordGenerator.generateRandomPassword (from utils) is not secure at all for small lengths (such as the default 6), since it's not really random ("ran

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rene Moser
Hi René On 09/16/2015 10:17 AM, Anshul Gangwar wrote: > Currently we report only PowerOn VMs and do not report PowerOff VMs that's > why we consider Missing and PowerOff as same And that's how most of the code > is written for VM sync and each Hypervisor resource has same understanding. > This

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread remibergsma
Github user remibergsma commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140678150 @wido Sure, will do my tests again today! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Remi Bergsma
If we all go for it, fix the blocker issues and test 4.6, then we should be able to do it! The CCCEU conference is in ~4 weeks, seems like a great deadline to work towards. But again, we all need to work together to make it happen. Let’s not forget that making master stable is hard. Just as hard

[GitHub] cloudstack pull request: Cloudstack 8868: use PasswordGenerator.ge...

2015-09-16 Thread karuturi
GitHub user karuturi opened a pull request: https://github.com/apache/cloudstack/pull/841 Cloudstack 8868: use PasswordGenerator.generateRandomPassword() to generate systemvm passwords generateRandomPassword() is supposed to create root user passwords. Right now it is only used on

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140676140 @bhaisaab Tnx! I tested it on a CentOS 7 system: ``` [root@vm-d818122e-51ca-479f-9618-051b4eed7c10 system]# systemctl status cloudstack-usage cloudstack

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Anshul Gangwar
Please find my answers inline Regards, Anshul On 16-Sep-2015, at 1:53 PM, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: On Wed, Sep 16, 2015 at 10:17 AM, Anshul Gangwar mailto:anshul.gang...@citrix.com>> wrote: Currently we report only PowerOn VMs and do not report PowerOff VMs that's

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140675342 @wido looks similar so looking at the changes LGTM, but I lack infra and time to test it out right now --- If your project is set up for it, you can reply to this

[GitHub] cloudstack pull request: CLOUDSTACK-8840: Systemd service for the ...

2015-09-16 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/820#issuecomment-140675073 @remibergsma @bhaisaab Could you take a look? It's almost similar to the Agent systemd profile :) --- If your project is set up for it, you can reply to this email and

Re: VPC router issue

2015-09-16 Thread Rajani Karuturi
Raja, Do you know the commit ids between the last successful and first failed builds? ~Rajani On 16-Sep-2015, at 10:05 am, Raja Pullela wrote: > Hi Wilder, BTW, I just checked my setup and it was passing on Sep 9th and > was regressed after that. > > Thanks for checking this out, > Raja >

[GitHub] cloudstack pull request: CLOUDSTACK-8852 Database shows that manag...

2015-09-16 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/840 CLOUDSTACK-8852 Database shows that management server is UP when it i… …s actually stopped from the CCP GUI This was happening as the stop method in clusterMnanagerImpl was not

[GitHub] cloudstack pull request: CLOUDSTACK-8851 Redundant VR getting star...

2015-09-16 Thread bvbharatk
GitHub user bvbharatk opened a pull request: https://github.com/apache/cloudstack/pull/839 CLOUDSTACK-8851 Redundant VR getting started in the same cluster or h… we are not populating the deployment destination of the previous rvr in the avoid set of the rvr that is being created.

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

2015-09-16 Thread wido
Github user wido commented on the pull request: https://github.com/apache/cloudstack/pull/831#issuecomment-140669424 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

Re: VPC router issue

2015-09-16 Thread Wilder Rodrigues
Thanks for the effort, Raja! I’m testing other PRs trying to find where the problem was introduced. Will keep you posted. Cheers, Wilder On 16 Sep 2015, at 06:35, Raja Pullela mailto:raja.pull...@citrix.com>> wrote: Hi Wilder, BTW, I just checked my setup and it was passing on Sep 9th and w

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Daan Hoogland
On Wed, Sep 16, 2015 at 10:17 AM, Anshul Gangwar wrote: > Currently we report only PowerOn VMs and do not report PowerOff VMs that's > why we consider Missing and PowerOff as same ​This is not the behavior reported in the ticket. It is intermittend.​ > And that's how most of the code is writte

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Anshul Gangwar
Currently we report only PowerOn VMs and do not report PowerOff VMs that's why we consider Missing and PowerOff as same And that's how most of the code is written for VM sync and each Hypervisor resource has same understanding. This will effect HA and many more unknown places. So please do not e

[GitHub] cloudstack pull request: CLOUDSTACK-8848: extra state to handle; n...

2015-09-16 Thread anshul1886
Github user anshul1886 commented on the pull request: https://github.com/apache/cloudstack/pull/829#issuecomment-140665483 Currently we report only PowerOn VMs and do not report PowerOff VMs that's why we consider Missing and PowerOff as same And that's how whole code is written and e

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Daan Hoogland
I think you are being an optimist saying 2-4 weeks but I second the attempt. +1 On Wed, Sep 16, 2015 at 10:07 AM, Rohit Yadav wrote: > Based on some discussion from slack, I think there is no harm in > experimenting this for let’s say 2-4 weeks; at worst we would have blocked > people from mergi

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Wilder Rodrigues
Then we create a 4.6.0 branch, fix all of it and allow people to continue to merge broken code on master. Once we merge 4.6 back to master, most probably the 4.6 stuff won’t work anymore. I have seen it before. I would still say +1 for the freeze and suggest that we get the contributors aligned

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Rohit Yadav
Based on some discussion from slack, I think there is no harm in experimenting this for let’s say 2-4 weeks; at worst we would have blocked people from merging new features etc. Remi/Rajani - do you think we can pull this off (fix blockers and do a 4.6.0 release) in next 2-4 weeks? On 16-Sep-2

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Sebastien Goasguen
> On Sep 16, 2015, at 9:58 AM, Daan Hoogland wrote: > > On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav > wrote: > >> 1. Only BLOCKER fixes to master. If there's something else that needs to >> get in, it can be discussed with the RMs on a case-by-case basis. >> >> >> -1 -ish >> What you’re eff

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Daan Hoogland
On Wed, Sep 16, 2015 at 9:38 AM, Rohit Yadav wrote: > 1. Only BLOCKER fixes to master. If there's something else that needs to > get in, it can be discussed with the RMs on a case-by-case basis. > > > -1 -ish > What you’re effectively saying is to freeze/block master from new changes > until 4.6.

Build failed in Jenkins: build-4.5 #529

2015-09-16 Thread jenkins
See Changes: [Rohit Yadav] tools/appliance: update Debian 7 iso URLs based on 615261 -- [...truncated 3676 lines...] [INFO] Surefire report directory:

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/824 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140659167 @DaanHoogland I think that will work; and also the stubs would allow 4.5.3 users to upgrade to 4.6.0 provided there is no schema changes between 4.5.2 and 4.6.0 (wh

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-140658229 I agree with @rafaelweingartner that this can have (and deserves) a unit test maybe it can even be generalized to dynamically find nic prefixes or at least have

[GitHub] cloudstack pull request: Changed variable s_logger to non-static a...

2015-09-16 Thread wilderrodrigues
Github user wilderrodrigues commented on the pull request: https://github.com/apache/cloudstack/pull/778#issuecomment-140658135 All, Given the current blocker issues we have to fix on master in order to release 4.6.0 and the fact that those changes don't really improve the cur

Re: [DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Rohit Yadav
On 16-Sep-2015, at 1:06 pm, Daan Hoogland mailto:daan.hoogl...@gmail.com>> wrote: so two questions: - is this a blocker? A missing state handler is definitely a corner case, and IMO a blocker (so, for both 4.6.0 and future 4.5.3). - is the ignoring after logging the appropriate way to handle

Build failed in Jenkins: build-4.5 #528

2015-09-16 Thread jenkins
See Changes: [Rohit Yadav] CLOUDSTACK-8820: Showing error when try to add advance zone using VMWare ESXi 6.0 host [Rohit Yadav] CLOUDSTACK-8820: Updated the code for vCenter6 data center support. --

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Rohit Yadav
On 16-Sep-2015, at 11:47 am, Rajani Karuturi mailto:raj...@apache.org>> wrote: Here is what we propose: 1. Only BLOCKER fixes to master. If there's something else that needs to get in, it can be discussed with the RMs on a case-by-case basis. -1 -ish What you’re effectively saying is to freeze

[DISCUSS][PROPOSAL]missing power state reports from hypervisors on VMs ([BLOCKER]?)

2015-09-16 Thread Daan Hoogland
Ladies and gentlemen, A ticket was entered by Rene Moser [1] on the way ACS handles missing power state reports. His issue is that VMs ma at times be regarded as off while they are registered as running and actually running as well. The missing report has to be handled in some way so right now it

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-16 Thread Rajani Karuturi
completely agree. We lack dev support for fixing and testing networking issues :( PS: I feel like there should be document in github describing contributor / reviewer / jira guidelines ~Rajani On Wed, Sep 16, 2015 at 12:51 PM, Wilder Rodrigues < wrodrig...@schubergphilis.com> wrote: > Hi all,

[GitHub] cloudstack pull request: CLOUDSTACK-8815 : Issues with cloudstack-...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/799#issuecomment-140654799 @sudhansu7 holding merging this PR, until we've the CentOS7 files fixed --- If your project is set up for it, you can reply to this email and have your reply appear

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Wilder Rodrigues
I just replied the other email about the VRs, where I actually mentioned the current mess that our github is due to the number of PRs and lack of proper reviews. So, +100 for that approach! If one cannot test a PR, so do not LGTM it! I would also add that a PR shall contain: 1. Jira ticket 2.

[GitHub] cloudstack pull request: CLOUDSTACK-8820: Support for VMware vCent...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/806 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [BLOCKER] - Guest VMs are not getting IPs as the DHCP port is not opened in VR

2015-09-16 Thread Wilder Rodrigues
Hi all, I did not say that the issues are not VR related, because they are. What I said was to not try fixing it by calling the bash scripts form within the python files. Those changes landed on master a few months ago, or more. The thing is that most of us rely on the simulator and there was

[GitHub] cloudstack pull request: changed the systemvm base iso file from d...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/833 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8867: Added retry logic to rec...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/835#discussion_r39599783 --- Diff: services/console-proxy/server/src/com/cloud/consoleproxy/ConsoleProxyClientParam.java --- @@ -115,7 +115,7 @@ public void setLocale(String

[PROPOSAL]VMware cluster level traffic override settings design change

2015-09-16 Thread Suresh Kumar Anaparti
Hi All, Currently, in cloudstack, the support for cluster level override settings (introduced in 4.2.0 with VMware DVS Integration) for guest and public traffic types blocks support for multiple physical networks defined in the zone for these traffic types over VMware deployments. It is require

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Miguel Ferreira
I totally agree with this proposal. By the way, until there is a reliable CI build, PR reviews should always follow point 2. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com On 16 Sep 2015, at 08:17, Rajani Karuturi mailto:raj...@apache.org>> wr

Re: [PROPOSAL] stable master and 4.6 release

2015-09-16 Thread Daan Hoogland
I agree with our esteemed RMs and want to add that it might be usefull to mark any PR with [4.6] or [future] so it is clear to everybody what it is intended for. On Wed, Sep 16, 2015 at 8:17 AM, Rajani Karuturi wrote: > Hi all, > There is little progress on 4.6 blockers this week. To release 4.6

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cloudstack/pull/813 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-16 Thread miguelaferreira
Github user miguelaferreira commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140650784 @bhaisaab I would say unit-tests are necessary to any software project this big, and with this many independent contributions. You putting the issue of askin

[GitHub] cloudstack pull request: CLOUDSTACK-8838: Allow ensX enoX enpX enx...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/812#issuecomment-140650851 LGTM, given the if conditions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cloudstack pull request: CLOUDSTACK-8625: Systemd profile for Clou...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/813#issuecomment-140650649 LGTM :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] cloudstack pull request: CLOUDSTACK-8841: Storage XenMotion from X...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/815#issuecomment-140650617 LGTM cc @abhinandanprateek --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cloudstack pull request: Fixed: Network Update from RVR offering t...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/818#issuecomment-140650519 LGTM, @kansal can you git commit --amend the message to reflect the JIRA ID --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cloudstack pull request: 4.5.3 upgradepath for master branch

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/824#issuecomment-140650501 provided we release 4.5.3 before 4.6.0; LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140650340 Also there seems to be a license header issue (missing new line between header and package definition in the utils class). --- If your project is set up for it, yo

[GitHub] cloudstack pull request: CLOUDSTACK-8850: revertSnapshot command d...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/831#issuecomment-140650077 LGTM cc @wilderrodrigues @wido @ustcweizhou --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cloudstack pull request: CLOUDSTACK-8834: Fixed unable to download...

2015-09-16 Thread DaanHoogland
Github user DaanHoogland commented on the pull request: https://github.com/apache/cloudstack/pull/804#issuecomment-140649852 Forgive me for my double negative in, "Be assured that I won't :-1: on this.", I did mean to say that I won't stop others merging it, as @bhaisaab explained. I

[GitHub] cloudstack pull request: CLOUDSTACK-8863: VM doesn't reconnect to ...

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/836#discussion_r39598913 --- Diff: systemvm/patches/debian/config/opt/cloud/bin/vr_cfg.sh --- @@ -93,4 +93,16 @@ done < $cfg #remove the configuration file, log file should h

[GitHub] cloudstack pull request: CLOUDSTACK-8857 listProjects doesn't retu...

2015-09-16 Thread bvbharatk
Github user bvbharatk commented on the pull request: https://github.com/apache/cloudstack/pull/838#issuecomment-140649167 @wilderrodrigues this jira ticket will give some insight on how to test it. https://issues.apache.org/jira/browse/CLOUDSTACK-8857 --- If your project is

[GitHub] cloudstack pull request: Cherry-pick PR #795 into 4.5 branch.

2015-09-16 Thread bhaisaab
Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/817#issuecomment-140648696 @borisroman not sure about the apache repo error, I'm having build failures when building locally due to getPreferredCharset method not avialable in StringUtils cla