I just replied the other email about the VRs, where I actually mentioned the current mess that our github is due to the number of PRs and lack of proper reviews.
So, +100 for that approach! If one cannot test a PR, so do not LGTM it! I would also add that a PR shall contain: 1. Jira ticket 2. Proper description of what it fixes/improves 3. Unit and/or Integration tests 4. And was tested by the committer!! Although we already said that, I now feel the need to repeat it. Cheers, Wilder On 16 Sep 2015, at 09:15, Miguel Ferreira <mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com>> wrote: I totally agree with this proposal. By the way, until there is a reliable CI build, PR reviews should always follow point 2. Cheers, \ Miguel Ferreira mferre...@schubergphilis.com<mailto:mferre...@schubergphilis.com><mailto:mferre...@schubergphilis.com> On 16 Sep 2015, at 08:17, Rajani Karuturi <raj...@apache.org<mailto:raj...@apache.org><mailto:raj...@apache.org>> wrote: Hi all, There is little progress on 4.6 blockers this week. To release 4.6, we all should come together and fix the blockers. In recent days, master has broken multiple times with compilation failures/regressions. If master breaks, time spent on figuring out what happened and fixing it is time *not* spent on 4.6. Here is what we propose: 1. Only BLOCKER fixes to master. If there's something else that needs to get in, it can be discussed with the RMs on a case-by-case basis. 2. Atleast one of the reviewers of a PR should do the actual tests. We do not have good CI in place and travis just does simulator tests. Until we have a real hypervisor CI in place, manually testing the PR is a must. Also, LGTM(or +1) should be accompanied with whats tested and why you are giving LGTM. Let us all work together on getting 4.6 out. Thanks Regards from the 4.6 RMs, Remi and Rajani. On Thu, Sep 10, 2015 at 2:52 PM, Remi Bergsma <rberg...@schubergphilis.com<mailto:rberg...@schubergphilis.com><mailto:rberg...@schubergphilis.com>> wrote: Hi all, A lot of work is being done to make 4.6 ready for a release. It's great to see it's getting better every day! Today Rajani and myself looked at all blocker and critical issues on 4.6. We decided to bump some of them to blocker. Two more issues need to verified against current master. In case still broken, they will be marked blocker as well. This means we'll have 6-8 blocker issues to resolve. Most of them are virtual router related and we feel we cannot do a RC without properly fixing them. If you have some time, please: Look at the 4.6 release dashboard: https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12326765 Fix one of the blockers (or critical issues): https://issues.apache.org/jira/browse/CLOUDSTACK-8697?filter=12332940 It also helps if people help reviewing PRs: https://github.com/apache/cloudstack/pulls Apart from these issues, 4.6 (aka master) is pretty stable. Feel free to test-drive it and verify your key functionality. Thanks! Regards from the 4.6 RMs, Rajani / Remi
